Josef Bacik
a47bd78d0c
btrfs: sysfs: use NOFS for device creation ...
Dave hit this splat during testing btrfs/078:
======================================================
WARNING: possible circular locking dependency detected
5.8.0-rc6-default+ #1191 Not tainted
------------------------------------------------------
kswapd0/75 is trying to acquire lock:
ffffa040e9d04ff8 (&delayed_node->mutex){+.+.}-{3:3}, at: __btrfs_release_delayed_node.part.0+0x3f/0x310 [btrfs]
but task is already holding lock:
ffffffff8b0c8040 (fs_reclaim){+.+.}-{0:0}, at: __fs_reclaim_acquire+0x5/0x30
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (fs_reclaim){+.+.}-{0:0}:
__lock_acquire+0x56f/0xaa0
lock_acquire+0xa3/0x440
fs_reclaim_acquire.part.0+0x25/0x30
__kmalloc_track_caller+0x49/0x330
kstrdup+0x2e/0x60
__kernfs_new_node.constprop.0+0x44/0x250
kernfs_new_node+0x25/0x50
kernfs_create_link+0x34/0xa0
sysfs_do_create_link_sd+0x5e/0xd0
btrfs_sysfs_add_devices_dir+0x65/0x100 [btrfs]
btrfs_init_new_device+0x44c/0x12b0 [btrfs]
btrfs_ioctl+0xc3c/0x25c0 [btrfs]
ksys_ioctl+0x68/0xa0
__x64_sys_ioctl+0x16/0x20
do_syscall_64+0x50/0xe0
entry_SYSCALL_64_after_hwframe+0x44/0xa9
-> #1 (&fs_info->chunk_mutex){+.+.}-{3:3}:
__lock_acquire+0x56f/0xaa0
lock_acquire+0xa3/0x440
__mutex_lock+0xa0/0xaf0
btrfs_chunk_alloc+0x137/0x3e0 [btrfs]
find_free_extent+0xb44/0xfb0 [btrfs]
btrfs_reserve_extent+0x9b/0x180 [btrfs]
btrfs_alloc_tree_block+0xc1/0x350 [btrfs]
alloc_tree_block_no_bg_flush+0x4a/0x60 [btrfs]
__btrfs_cow_block+0x143/0x7a0 [btrfs]
btrfs_cow_block+0x15f/0x310 [btrfs]
push_leaf_right+0x150/0x240 [btrfs]
split_leaf+0x3cd/0x6d0 [btrfs]
btrfs_search_slot+0xd14/0xf70 [btrfs]
btrfs_insert_empty_items+0x64/0xc0 [btrfs]
__btrfs_commit_inode_delayed_items+0xb2/0x840 [btrfs]
btrfs_async_run_delayed_root+0x10e/0x1d0 [btrfs]
btrfs_work_helper+0x2f9/0x650 [btrfs]
process_one_work+0x22c/0x600
worker_thread+0x50/0x3b0
kthread+0x137/0x150
ret_from_fork+0x1f/0x30
-> #0 (&delayed_node->mutex){+.+.}-{3:3}:
check_prev_add+0x98/0xa20
validate_chain+0xa8c/0x2a00
__lock_acquire+0x56f/0xaa0
lock_acquire+0xa3/0x440
__mutex_lock+0xa0/0xaf0
__btrfs_release_delayed_node.part.0+0x3f/0x310 [btrfs]
btrfs_evict_inode+0x3bf/0x560 [btrfs]
evict+0xd6/0x1c0
dispose_list+0x48/0x70
prune_icache_sb+0x54/0x80
super_cache_scan+0x121/0x1a0
do_shrink_slab+0x175/0x420
shrink_slab+0xb1/0x2e0
shrink_node+0x192/0x600
balance_pgdat+0x31f/0x750
kswapd+0x206/0x510
kthread+0x137/0x150
ret_from_fork+0x1f/0x30
other info that might help us debug this:
Chain exists of:
&delayed_node->mutex --> &fs_info->chunk_mutex --> fs_reclaim
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(fs_reclaim);
lock(&fs_info->chunk_mutex);
lock(fs_reclaim);
lock(&delayed_node->mutex);
*** DEADLOCK ***
3 locks held by kswapd0/75:
#0 : ffffffff8b0c8040 (fs_reclaim){+.+.}-{0:0}, at: __fs_reclaim_acquire+0x5/0x30
#1 : ffffffff8b0b50b8 (shrinker_rwsem){++++}-{3:3}, at: shrink_slab+0x54/0x2e0
#2 : ffffa040e057c0e8 (&type->s_umount_key#26){++++}-{3:3}, at: trylock_super+0x16/0x50
stack backtrace:
CPU: 2 PID: 75 Comm: kswapd0 Not tainted 5.8.0-rc6-default+ #1191
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-59-gc9ba527-rebuilt.opensuse.org 04/01/2014
Call Trace:
dump_stack+0x78/0xa0
check_noncircular+0x16f/0x190
check_prev_add+0x98/0xa20
validate_chain+0xa8c/0x2a00
__lock_acquire+0x56f/0xaa0
lock_acquire+0xa3/0x440
? __btrfs_release_delayed_node.part.0+0x3f/0x310 [btrfs]
__mutex_lock+0xa0/0xaf0
? __btrfs_release_delayed_node.part.0+0x3f/0x310 [btrfs]
? __lock_acquire+0x56f/0xaa0
? __btrfs_release_delayed_node.part.0+0x3f/0x310 [btrfs]
? lock_acquire+0xa3/0x440
? btrfs_evict_inode+0x138/0x560 [btrfs]
? btrfs_evict_inode+0x2fe/0x560 [btrfs]
? __btrfs_release_delayed_node.part.0+0x3f/0x310 [btrfs]
__btrfs_release_delayed_node.part.0+0x3f/0x310 [btrfs]
btrfs_evict_inode+0x3bf/0x560 [btrfs]
evict+0xd6/0x1c0
dispose_list+0x48/0x70
prune_icache_sb+0x54/0x80
super_cache_scan+0x121/0x1a0
do_shrink_slab+0x175/0x420
shrink_slab+0xb1/0x2e0
shrink_node+0x192/0x600
balance_pgdat+0x31f/0x750
kswapd+0x206/0x510
? _raw_spin_unlock_irqrestore+0x3e/0x50
? finish_wait+0x90/0x90
? balance_pgdat+0x750/0x750
kthread+0x137/0x150
? kthread_stop+0x2a0/0x2a0
ret_from_fork+0x1f/0x30
This is because we're holding the chunk_mutex while adding this device
and adding its sysfs entries. We actually hold different locks in
different places when calling this function, the dev_replace semaphore
for instance in dev replace, so instead of moving this call around
simply wrap it's operations in NOFS.
CC: stable@vger.kernel.org # 4.14+
Reported-by: David Sterba <dsterba@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2020-07-27 12:55:46 +02:00
2020-03-27 09:29:56 +00:00
2020-04-20 15:45:22 -06:00
2020-04-20 15:45:22 -06:00
2020-07-15 15:49:04 -07:00
2020-07-08 08:27:56 +02:00
2020-04-20 15:45:22 -06:00
2020-07-27 12:55:46 +02:00
2020-07-08 08:27:56 +02:00
2020-06-01 13:22:53 +02:00
2020-07-23 15:44:11 -05:00
2020-05-05 09:22:21 -06:00
2020-06-01 15:45:27 -07:00
2020-04-20 15:45:22 -06:00
2020-06-01 12:10:17 -07:00
2020-04-27 09:34:55 +02:00
2020-06-05 16:43:16 -07:00
2020-06-01 15:45:27 -07:00
2020-07-09 10:14:29 +03:00
2020-06-24 09:47:44 +08:00
2020-07-21 10:44:19 +09:00
2020-06-09 09:39:14 -07:00
2020-06-15 09:32:10 -07:00
2020-06-09 11:28:59 -07:00
2020-06-04 19:06:25 -07:00
2020-06-03 16:27:18 -07:00
2020-07-15 14:18:20 +02:00
2020-07-07 23:40:12 +02:00
2020-06-02 15:29:19 -07:00
2020-05-22 08:45:46 -06:00
2020-03-29 23:23:00 +02:00
2020-06-06 10:08:17 -07:00
2020-06-09 09:39:14 -07:00
2020-06-13 12:44:30 -07:00
2020-06-02 15:29:19 -07:00
2020-06-15 09:32:10 -07:00
2020-06-15 23:08:31 -05:00
2020-06-02 20:11:35 -07:00
2020-06-09 09:39:14 -07:00
2020-07-17 14:47:38 -04:00
2020-07-22 16:47:14 -04:00
2020-06-10 19:14:17 -07:00
2020-06-14 01:57:21 +09:00
2020-06-14 01:57:21 +09:00
2020-06-02 12:21:36 -07:00
2020-06-26 00:27:37 -07:00
2020-06-02 10:59:07 -07:00
2020-06-05 16:44:36 -07:00
2020-07-16 07:24:47 +02:00
2020-07-03 23:20:14 -07:00
2020-06-01 16:18:46 -07:00
2020-06-02 10:59:07 -07:00
2020-04-27 02:07:40 -04:00
2020-06-04 13:53:10 -07:00
2020-06-14 01:57:21 +09:00
2020-07-24 12:42:41 -07:00
2020-06-05 14:05:57 -07:00
2020-04-20 15:45:22 -06:00
2020-06-02 10:59:11 -07:00
2020-06-02 15:29:19 -07:00
2020-03-25 11:50:48 +01:00
2020-05-07 08:45:47 -06:00
2020-05-12 16:44:00 -07:00
2020-06-22 19:22:57 -07:00
2020-07-20 17:59:31 +09:00
2020-06-15 23:08:25 -05:00
2020-06-03 23:16:55 -04:00
2020-05-07 16:55:47 -05:00
2020-06-10 16:02:54 -07:00
2020-06-10 16:02:54 -07:00
2020-06-04 19:18:29 -07:00
2020-06-10 16:02:54 -07:00
2020-06-04 19:18:29 -07:00
2020-06-04 19:18:29 -07:00
2020-06-18 09:24:35 -06:00
2020-06-02 10:59:07 -07:00
2020-05-14 16:44:23 +02:00
2020-06-05 13:45:21 -07:00
2020-06-09 09:39:14 -07:00
2020-04-02 19:15:03 -07:00
2020-06-03 16:27:18 -07:00
2020-06-14 09:47:25 -07:00
2020-04-27 02:07:40 -04:00
2020-05-06 22:33:43 -04:00
2020-05-14 10:00:35 -07:00
2020-06-09 09:39:14 -07:00
2020-06-29 09:40:55 -07:00
2020-05-19 18:29:36 -04:00
2020-04-10 15:36:22 -07:00
2020-05-14 16:44:25 +02:00
2020-04-02 09:35:26 -07:00
2020-06-05 16:19:28 -07:00
2020-06-05 16:26:36 -07:00
2020-06-05 16:19:28 -07:00
2020-07-23 11:20:55 -06:00
2020-06-15 08:51:34 -06:00
2020-06-15 08:51:38 -06:00
2020-06-03 23:16:55 -04:00
2020-06-14 01:57:21 +09:00
2020-06-14 01:57:21 +09:00
2020-05-22 08:45:46 -06:00
2020-06-11 10:33:13 -07:00
2020-05-14 16:44:24 +02:00
2020-06-02 10:59:07 -07:00
2020-06-08 11:04:19 -07:00
2020-07-14 14:45:41 +02:00
2020-05-13 11:41:22 +02:00
2020-06-02 12:21:36 -07:00
2020-06-13 09:56:21 -07:00
2020-04-27 10:37:14 -04:00
2020-06-08 11:04:19 -07:00
2020-06-04 13:54:34 -07:00
2020-07-08 08:27:57 +02:00
2020-05-01 20:29:54 -04:00
2020-05-29 19:10:42 -04:00
2020-06-04 19:06:25 -07:00
2020-06-13 09:56:21 -07:00
2020-06-02 19:45:12 -07:00
2020-06-10 16:09:11 -07:00
2020-06-09 15:40:50 -07:00
2020-06-09 09:39:14 -07:00
2020-05-14 16:44:24 +02:00
2020-04-09 15:33:09 -04:00
a47bd78d0c