linux

iv/linux

History

Linus Torvalds 0b832a4b93 Revert "ext2/ext3/ext4: add block bitmap validation"

This reverts commit 7c9e69faa28027913ee059c285a5ea8382e24b5d, fixing up
conflicts in fs/ext4/balloc.c manually.

The cost of doing the bitmap validation on each lookup - even when the
bitmap is cached - is absolutely prohibitive.  We could, and probably
should, do it only when adding the bitmap to the buffer cache.  However,
right now we are better off just reverting it.

Peter Zijlstra measured the cost of this extra validation as a 85%
decrease in cached iozone, and while I had a patch that took it down to
just 17% by not being _quite_ so stupid in the validation, it was still
a big slowdown that could have been avoided by just doing it right.

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>
Cc: Andreas Dilger <adilger@clusterfs.com>
Cc: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2007-11-13 08:09:11 -08:00

acl.c

Introduce is_owner_or_cap() to wrap CAP_FOWNER use with fsuid check

2007-07-17 12:00:03 -07:00

acl.h

[PATCH] ext4: rename ext4 symbols to avoid duplication of ext3 symbols

2006-10-11 11:14:15 -07:00

balloc.c

Revert "ext2/ext3/ext4: add block bitmap validation"

2007-11-13 08:09:11 -08:00

bitmap.c

fs: mark nibblemap const