Eric Dumazet
a54754ec98
netfilter: nftables: avoid overflows in nft_hash_buckets() ...
Number of buckets being stored in 32bit variables, we have to
ensure that no overflows occur in nft_hash_buckets()
syzbot injected a size == 0x40000000 and reported:
UBSAN: shift-out-of-bounds in ./include/linux/log2.h:57:13
shift exponent 64 is too large for 64-bit type 'long unsigned int'
CPU: 1 PID: 29539 Comm: syz-executor.4 Not tainted 5.12.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
dump_stack+0x141/0x1d7 lib/dump_stack.c:120
ubsan_epilogue+0xb/0x5a lib/ubsan.c:148
__ubsan_handle_shift_out_of_bounds.cold+0xb1/0x181 lib/ubsan.c:327
__roundup_pow_of_two include/linux/log2.h:57 [inline]
nft_hash_buckets net/netfilter/nft_set_hash.c:411 [inline]
nft_hash_estimate.cold+0x19/0x1e net/netfilter/nft_set_hash.c:652
nft_select_set_ops net/netfilter/nf_tables_api.c:3586 [inline]
nf_tables_newset+0xe62/0x3110 net/netfilter/nf_tables_api.c:4322
nfnetlink_rcv_batch+0xa09/0x24b0 net/netfilter/nfnetlink.c:488
nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:612 [inline]
nfnetlink_rcv+0x3af/0x420 net/netfilter/nfnetlink.c:630
netlink_unicast_kernel net/netlink/af_netlink.c:1312 [inline]
netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1338
netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1927
sock_sendmsg_nosec net/socket.c:654 [inline]
sock_sendmsg+0xcf/0x120 net/socket.c:674
____sys_sendmsg+0x6e8/0x810 net/socket.c:2350
___sys_sendmsg+0xf3/0x170 net/socket.c:2404
__sys_sendmsg+0xe5/0x1b0 net/socket.c:2433
do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
Fixes: 0ed6389c483d ("netfilter: nf_tables: rename set implementations")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2021-05-07 10:01:29 +02:00
2021-03-24 17:52:11 -07:00
2021-03-28 17:56:56 -07:00
2021-04-26 12:00:00 -07:00
2021-02-12 16:40:28 -08:00
2021-01-29 18:24:05 -08:00
2021-03-30 16:54:50 -07:00
2021-04-09 20:48:35 -07:00
2021-04-29 11:57:23 -07:00
2021-03-26 20:41:52 -07:00
2021-01-27 17:04:12 -08:00
2021-04-29 15:33:17 -07:00
2021-02-15 13:21:48 -08:00
2021-04-25 19:43:00 +02:00
2021-03-25 17:05:07 -07:00
2021-04-29 11:57:23 -07:00
2021-01-27 17:03:52 -08:00
2021-04-09 16:34:56 -07:00
2021-03-30 16:54:50 -07:00
2021-01-27 17:04:12 -08:00
2021-04-28 14:06:45 -07:00
2021-04-13 14:35:02 -07:00
2021-04-19 16:23:32 -07:00
2021-05-03 13:33:54 -07:00
2021-04-07 14:43:28 -07:00
2021-01-27 17:04:12 -08:00
2021-05-03 23:04:01 +02:00
2021-04-29 15:34:15 -07:00
2021-03-28 17:31:13 -07:00
2021-03-28 17:31:13 -07:00
2021-01-04 10:05:50 +01:00
2021-04-27 14:23:13 -07:00
2021-03-28 17:56:55 -07:00
2021-03-23 14:14:50 -07:00
2021-04-27 14:16:14 -07:00
2021-04-29 11:57:23 -07:00
2021-04-06 22:42:16 +02:00
2021-04-27 14:17:00 -07:00
2021-04-26 12:00:00 -07:00
2021-04-09 20:48:35 -07:00
2021-05-07 10:01:29 +02:00
2021-04-29 11:57:23 -07:00
2021-04-16 17:01:04 -07:00
2021-04-28 13:59:08 -07:00
2021-04-29 11:57:23 -07:00
2021-04-29 15:31:53 -07:00
2021-04-14 14:34:38 -07:00
2021-03-14 15:00:43 -07:00
2021-04-26 12:00:00 -07:00
2021-04-29 11:57:23 -07:00
2021-04-20 16:44:04 -07:00
2021-03-10 12:45:15 -08:00
2021-04-29 11:57:23 -07:00
2021-04-29 15:31:53 -07:00
2021-05-03 13:36:21 -07:00
2021-04-27 14:17:50 -07:00
2021-04-06 11:24:31 -04:00
2021-02-14 17:38:11 -08:00
2021-04-29 11:57:23 -07:00
2021-04-27 14:15:19 -07:00
2021-01-24 14:27:18 +01:00
2021-04-30 15:00:59 -07:00
2021-04-29 11:57:23 -07:00
2021-03-28 17:31:13 -07:00
2021-04-23 09:50:35 +02:00
2021-04-19 12:49:29 +02:00
2021-04-28 14:06:45 -07:00
2021-01-27 17:03:52 -08:00
2021-03-25 16:56:27 -07:00
2021-04-12 13:27:11 -07:00
a54754ec98