linux

iv/linux

History

Alexander Lobakin a6016aac52 dma: fix DMA sync for drivers not calling dma_set_mask*()

There are several reports that the DMA sync shortcut broke non-coherent
devices.
dev->dma_need_sync is false after the &device allocation and if a driver
didn't call dma_set_mask*(), it will still be false even if the device
is not DMA-coherent and thus needs synchronizing. Due to historical
reasons, there's still a lot of drivers not calling it.
Invert the boolean, so that the sync will be performed by default and
the shortcut will be enabled only when calling dma_set_mask*().

Reported-by: Steven Price <steven.price@arm.com>
Closes: https://lore.kernel.org/lkml/010686f5-3049-46a1-8230-7752a1b433ff@arm.com
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Closes: https://lore.kernel.org/lkml/46160534-5003-4809-a408-6b3a3f4921e9@samsung.com
Fixes: f406c8e4b770. ("dma: avoid redundant calls for sync operations")
Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Steven Price <steven.price@arm.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

2024-05-09 19:00:29 +02:00

coherent.c

dma-mapping: clear dev->dma_mem to NULL after freeing it

2023-12-15 12:32:45 +01:00

contiguous.c

mm/cma: drop CONFIG_CMA_DEBUG

2024-02-22 10:24:53 -08:00

debug.c

dma-mapping fixes for Linux 6.8

2024-01-18 16:49:34 -08:00

debug.h

dma-debug: teach add_dma_entry() about DMA_ATTR_SKIP_CPU_SYNC