688bbe398c
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). In the error path emit an error message replacing the (less useful) message by the core. Apart from the improved error message there is no change in behaviour. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/c15ffc57efebc5da3f7e6dd558d69181e129cafe.1701619134.git.u.kleine-koenig@pengutronix.de Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
125 lines
3.2 KiB
C
125 lines
3.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Detection routine for the NCR53c710 based Amiga SCSI Controllers for Linux.
|
|
* Amiga Technologies A4000T SCSI controller.
|
|
*
|
|
* Written 1997 by Alan Hourihane <alanh@fairlite.demon.co.uk>
|
|
* plus modifications of the 53c7xx.c driver to support the Amiga.
|
|
*
|
|
* Rewritten to use 53c700.c by Kars de Jong <jongk@linux-m68k.org>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/init.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/slab.h>
|
|
#include <asm/amigahw.h>
|
|
#include <asm/amigaints.h>
|
|
#include <scsi/scsi_host.h>
|
|
#include <scsi/scsi_transport_spi.h>
|
|
|
|
#include "53c700.h"
|
|
|
|
|
|
static struct scsi_host_template a4000t_scsi_driver_template = {
|
|
.name = "A4000T builtin SCSI",
|
|
.proc_name = "A4000t",
|
|
.this_id = 7,
|
|
.module = THIS_MODULE,
|
|
};
|
|
|
|
|
|
#define A4000T_SCSI_OFFSET 0x40
|
|
|
|
static int __init amiga_a4000t_scsi_probe(struct platform_device *pdev)
|
|
{
|
|
struct resource *res;
|
|
phys_addr_t scsi_addr;
|
|
struct NCR_700_Host_Parameters *hostdata;
|
|
struct Scsi_Host *host;
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
if (!res)
|
|
return -ENODEV;
|
|
|
|
if (!request_mem_region(res->start, resource_size(res),
|
|
"A4000T builtin SCSI"))
|
|
return -EBUSY;
|
|
|
|
hostdata = kzalloc(sizeof(struct NCR_700_Host_Parameters),
|
|
GFP_KERNEL);
|
|
if (!hostdata) {
|
|
dev_err(&pdev->dev, "Failed to allocate host data\n");
|
|
goto out_release;
|
|
}
|
|
|
|
scsi_addr = res->start + A4000T_SCSI_OFFSET;
|
|
|
|
/* Fill in the required pieces of hostdata */
|
|
hostdata->base = ZTWO_VADDR(scsi_addr);
|
|
hostdata->clock = 50;
|
|
hostdata->chip710 = 1;
|
|
hostdata->dmode_extra = DMODE_FC2;
|
|
hostdata->dcntl_extra = EA_710;
|
|
|
|
/* and register the chip */
|
|
host = NCR_700_detect(&a4000t_scsi_driver_template, hostdata,
|
|
&pdev->dev);
|
|
if (!host) {
|
|
dev_err(&pdev->dev,
|
|
"No host detected; board configuration problem?\n");
|
|
goto out_free;
|
|
}
|
|
|
|
host->this_id = 7;
|
|
host->base = scsi_addr;
|
|
host->irq = IRQ_AMIGA_PORTS;
|
|
|
|
if (request_irq(host->irq, NCR_700_intr, IRQF_SHARED, "a4000t-scsi",
|
|
host)) {
|
|
dev_err(&pdev->dev, "request_irq failed\n");
|
|
goto out_put_host;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, host);
|
|
scsi_scan_host(host);
|
|
return 0;
|
|
|
|
out_put_host:
|
|
scsi_host_put(host);
|
|
out_free:
|
|
kfree(hostdata);
|
|
out_release:
|
|
release_mem_region(res->start, resource_size(res));
|
|
return -ENODEV;
|
|
}
|
|
|
|
static void __exit amiga_a4000t_scsi_remove(struct platform_device *pdev)
|
|
{
|
|
struct Scsi_Host *host = platform_get_drvdata(pdev);
|
|
struct NCR_700_Host_Parameters *hostdata = shost_priv(host);
|
|
struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
|
|
scsi_remove_host(host);
|
|
NCR_700_release(host);
|
|
kfree(hostdata);
|
|
free_irq(host->irq, host);
|
|
release_mem_region(res->start, resource_size(res));
|
|
}
|
|
|
|
static struct platform_driver amiga_a4000t_scsi_driver = {
|
|
.remove_new = __exit_p(amiga_a4000t_scsi_remove),
|
|
.driver = {
|
|
.name = "amiga-a4000t-scsi",
|
|
},
|
|
};
|
|
|
|
module_platform_driver_probe(amiga_a4000t_scsi_driver, amiga_a4000t_scsi_probe);
|
|
|
|
MODULE_AUTHOR("Alan Hourihane <alanh@fairlite.demon.co.uk> / "
|
|
"Kars de Jong <jongk@linux-m68k.org>");
|
|
MODULE_DESCRIPTION("Amiga A4000T NCR53C710 driver");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:amiga-a4000t-scsi");
|