WANG Cong
a700cf26a3
ping: fix a null pointer dereference ...
[ Upstream commit 73d2c6678e6c3af7e7a42b1e78cd0211782ade32 ]
Andrey reported a kernel crash:
general protection fault: 0000 [#1 ] SMP KASAN
Dumping ftrace buffer:
(ftrace buffer empty)
Modules linked in:
CPU: 2 PID: 3880 Comm: syz-executor1 Not tainted 4.10.0-rc6+ #124
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
task: ffff880060048040 task.stack: ffff880069be8000
RIP: 0010:ping_v4_push_pending_frames net/ipv4/ping.c:647 [inline]
RIP: 0010:ping_v4_sendmsg+0x1acd/0x23f0 net/ipv4/ping.c:837
RSP: 0018:ffff880069bef8b8 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffff880069befb90 RCX: 0000000000000000
RDX: 0000000000000018 RSI: ffff880069befa30 RDI: 00000000000000c2
RBP: ffff880069befbb8 R08: 0000000000000008 R09: 0000000000000000
R10: 0000000000000002 R11: 0000000000000000 R12: ffff880069befab0
R13: ffff88006c624a80 R14: ffff880069befa70 R15: 0000000000000000
FS: 00007f6f7c716700(0000) GS:ffff88006de00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000004a6f28 CR3: 000000003a134000 CR4: 00000000000006e0
Call Trace:
inet_sendmsg+0x164/0x5b0 net/ipv4/af_inet.c:744
sock_sendmsg_nosec net/socket.c:635 [inline]
sock_sendmsg+0xca/0x110 net/socket.c:645
SYSC_sendto+0x660/0x810 net/socket.c:1687
SyS_sendto+0x40/0x50 net/socket.c:1655
entry_SYSCALL_64_fastpath+0x1f/0xc2
This is because we miss a check for NULL pointer for skb_peek() when
the queue is empty. Other places already have the same check.
Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind")
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-02-18 15:11:43 +01:00
2016-09-19 20:19:34 +02:00
2016-09-23 13:47:44 -04:00
2016-10-20 14:32:22 -04:00
2016-09-10 21:19:10 -07:00
2016-09-10 21:19:10 -07:00
2017-02-04 09:47:09 +01:00
2016-12-02 10:46:59 +01:00
2016-11-22 22:50:46 +01:00
2017-02-04 09:47:10 +01:00
2016-12-05 14:48:48 -05:00
2017-02-18 15:11:40 +01:00
2017-01-26 08:24:46 +01:00
2017-02-18 15:11:41 +01:00
2016-12-03 23:54:25 -05:00
2016-11-29 20:37:26 -05:00
2017-02-04 09:47:11 +01:00
2017-02-18 15:11:43 +01:00
2016-10-18 10:28:18 -04:00
2016-07-08 13:23:12 +02:00
2017-02-18 15:11:43 +01:00
2017-02-18 15:11:43 +01:00
2016-09-23 06:46:57 -04:00
2017-01-19 20:18:04 +01:00
2016-10-07 15:36:58 -07:00
2016-11-30 14:14:08 -05:00
2016-09-10 23:12:53 -07:00
2016-09-17 10:05:05 -04:00
2017-02-14 15:25:38 -08:00
2016-09-19 20:19:34 +02:00
2017-02-04 09:47:11 +01:00
2016-10-20 11:23:08 -04:00
2016-11-24 14:43:35 +01:00
2016-12-05 19:43:42 -05:00
2016-07-11 02:02:03 +02:00
2017-02-04 09:47:09 +01:00
2017-02-18 15:11:43 +01:00
2016-12-02 13:29:26 -05:00
2016-07-13 11:53:40 -07:00
2016-10-13 08:43:17 +01:00
2017-02-18 15:11:41 +01:00
2017-02-18 15:11:42 +01:00
2016-10-12 01:51:49 -04:00
2017-02-09 08:08:27 +01:00
2016-10-19 10:58:04 -04:00
2016-12-02 14:03:20 -05:00
2017-02-04 09:47:10 +01:00
2017-01-09 08:32:23 +01:00
2017-02-14 15:25:37 -08:00
2016-09-09 18:13:30 -07:00
2016-11-30 10:58:53 +01:00
2016-08-17 19:36:23 -04:00
2016-08-17 19:36:23 -04:00
2016-11-17 00:00:23 -05:00
2016-10-06 09:52:23 -07:00
a700cf26a3