The reg in the example "<0x5fc10000 0x1000>, <0x5fc20000 0x800>" is wrong. The register region of this controller is much smaller, and there is no other hardware register interleaved. There is no good reason to split it into two regions. Just use a single, contiguous register region. While I am here, I made the 'dma-channels' property mandatory because otherwise there is no way to determine the number of the channels. Please note the original binding was merged recently. Since there is no user yet, this change has no actual impact. Fixes: b9fb56b6ba8a ("dt-bindings: dmaengine: Add UniPhier external DMA controller bindings") Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20200401032150.19767-1-yamada.masahiro@socionext.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
63 lines
1.4 KiB
YAML
63 lines
1.4 KiB
YAML
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
|
|
%YAML 1.2
|
|
---
|
|
$id: http://devicetree.org/schemas/dma/socionext,uniphier-xdmac.yaml#
|
|
$schema: http://devicetree.org/meta-schemas/core.yaml#
|
|
|
|
title: Socionext UniPhier external DMA controller
|
|
|
|
description: |
|
|
This describes the devicetree bindings for an external DMA engine to perform
|
|
memory-to-memory or peripheral-to-memory data transfer capable of supporting
|
|
16 channels, implemented in Socionext UniPhier SoCs.
|
|
|
|
maintainers:
|
|
- Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
|
|
|
|
allOf:
|
|
- $ref: "dma-controller.yaml#"
|
|
|
|
properties:
|
|
compatible:
|
|
const: socionext,uniphier-xdmac
|
|
|
|
reg:
|
|
maxItems: 1
|
|
|
|
interrupts:
|
|
maxItems: 1
|
|
|
|
"#dma-cells":
|
|
const: 2
|
|
description: |
|
|
DMA request from clients consists of 2 cells:
|
|
1. Channel index
|
|
2. Transfer request factor number, If no transfer factor, use 0.
|
|
The number is SoC-specific, and this should be specified with
|
|
relation to the device to use the DMA controller.
|
|
|
|
dma-channels:
|
|
minimum: 1
|
|
maximum: 16
|
|
|
|
additionalProperties: false
|
|
|
|
required:
|
|
- compatible
|
|
- reg
|
|
- interrupts
|
|
- "#dma-cells"
|
|
- dma-channels
|
|
|
|
examples:
|
|
- |
|
|
xdmac: dma-controller@5fc10000 {
|
|
compatible = "socionext,uniphier-xdmac";
|
|
reg = <0x5fc10000 0x5300>;
|
|
interrupts = <0 188 4>;
|
|
#dma-cells = <2>;
|
|
dma-channels = <16>;
|
|
};
|
|
|
|
...
|