a720c0644d
Updates free/devm_free.cocci to recognize functions added by: - commit64c862a839('devres: add kernel standard devm_k.alloc functions') - commite31108cad3('devres: introduce API "devm_kstrdup"') - commit3046365bb4('devres: introduce API "devm_kmemdup') - commit43339bed70('devres: Add devm_get_free_pages API') - commit75f2a4ead5('devres: Add devm_kasprintf and devm_kvasprintf API') See also Documentation/driver-model/devres.txt Cc: Joe Perches <joe@perches.com> Cc: Manish Badarkhe <badarkhe.manish@gmail.com> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Eli Billauer <eli.billauer@gmail.com> Cc: Himangi Saraogi <himangi774@gmail.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Wolfram Sang <w.sang@pengutronix.de> Cc: Daniel Thompson <daniel.thompson@linaro.org> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com> Signed-off-by: Michal Marek <mmarek@suse.com>
94 lines
2.0 KiB
Plaintext
94 lines
2.0 KiB
Plaintext
/// Find uses of standard freeing functons on values allocated using devm_
|
|
/// functions. Values allocated using the devm_functions are freed when
|
|
/// the device is detached, and thus the use of the standard freeing
|
|
/// function would cause a double free.
|
|
/// See Documentation/driver-model/devres.txt for more information.
|
|
///
|
|
/// A difficulty of detecting this problem is that the standard freeing
|
|
/// function might be called from a different function than the one
|
|
/// containing the allocation function. It is thus necessary to make the
|
|
/// connection between the allocation function and the freeing function.
|
|
/// Here this is done using the specific argument text, which is prone to
|
|
/// false positives. There is no rule for the request_region and
|
|
/// request_mem_region variants because this heuristic seems to be a bit
|
|
/// less reliable in these cases.
|
|
///
|
|
// Confidence: Moderate
|
|
// Copyright: (C) 2011 Julia Lawall, INRIA/LIP6. GPLv2.
|
|
// Copyright: (C) 2011 Gilles Muller, INRIA/LiP6. GPLv2.
|
|
// URL: http://coccinelle.lip6.fr/
|
|
// Comments:
|
|
// Options: --no-includes --include-headers
|
|
|
|
virtual org
|
|
virtual report
|
|
virtual context
|
|
|
|
@r depends on context || org || report@
|
|
expression x;
|
|
@@
|
|
|
|
(
|
|
x = devm_kmalloc(...)
|
|
|
|
|
x = devm_kvasprintf(...)
|
|
|
|
|
x = devm_kasprintf(...)
|
|
|
|
|
x = devm_kzalloc(...)
|
|
|
|
|
x = devm_kmalloc_array(...)
|
|
|
|
|
x = devm_kcalloc(...)
|
|
|
|
|
x = devm_kstrdup(...)
|
|
|
|
|
x = devm_kmemdup(...)
|
|
|
|
|
x = devm_get_free_pages(...)
|
|
|
|
|
x = devm_request_irq(...)
|
|
|
|
|
x = devm_ioremap(...)
|
|
|
|
|
x = devm_ioremap_nocache(...)
|
|
|
|
|
x = devm_ioport_map(...)
|
|
)
|
|
|
|
@pb@
|
|
expression r.x;
|
|
position p;
|
|
@@
|
|
|
|
(
|
|
* kfree@p(x)
|
|
|
|
|
* kzfree@p(x)
|
|
|
|
|
* free_pages@p(x, ...)
|
|
|
|
|
* free_page@p(x)
|
|
|
|
|
* free_irq@p(x)
|
|
|
|
|
* iounmap@p(x)
|
|
|
|
|
* ioport_unmap@p(x)
|
|
)
|
|
|
|
@script:python depends on org@
|
|
p << pb.p;
|
|
@@
|
|
|
|
msg="WARNING: invalid free of devm_ allocated data"
|
|
coccilib.org.print_todo(p[0], msg)
|
|
|
|
@script:python depends on report@
|
|
p << pb.p;
|
|
@@
|
|
|
|
msg="WARNING: invalid free of devm_ allocated data"
|
|
coccilib.report.print_report(p[0], msg)
|
|
|