iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/block
History
Ming Lei bc8859174d blk-mq: initialize mq kobjects in blk_mq_init_allocated_queue() 
[ Upstream commit 737f98cfe7de8df7433a4d846850aa8efa44bd48 ]

Both q->mq_kobj and sw queues' kobjects should have been initialized
once, instead of doing that each add_disk context.

Also this patch removes clearing of ctx in blk_mq_init_cpu_queues()
because percpu allocator fills zero to allocated variable.

This patch fixes one issue[1] reported from Omar.

[1] kernel wearning when doing unbind/bind on one scsi-mq device

[   19.347924] kobject (ffff8800791ea0b8): tried to init an initialized object, something is seriously wrong.
[   19.349781] CPU: 1 PID: 84 Comm: kworker/u8:1 Not tainted 4.10.0-rc7-00210-g53f39eeaa263 #34
[   19.350686] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.1-20161122_114906-anatol 04/01/2014
[   19.350920] Workqueue: events_unbound async_run_entry_fn
[   19.350920] Call Trace:
[   19.350920]  dump_stack+0x63/0x83
[   19.350920]  kobject_init+0x77/0x90
[   19.350920]  blk_mq_register_dev+0x40/0x130
[   19.350920]  blk_register_queue+0xb6/0x190
[   19.350920]  device_add_disk+0x1ec/0x4b0
[   19.350920]  sd_probe_async+0x10d/0x1c0 [sd_mod]
[   19.350920]  async_run_entry_fn+0x48/0x150
[   19.350920]  process_one_work+0x1d0/0x480
[   19.350920]  worker_thread+0x48/0x4e0
[   19.350920]  kthread+0x101/0x140
[   19.350920]  ? process_one_work+0x480/0x480
[   19.350920]  ? kthread_create_on_node+0x60/0x60
[   19.350920]  ret_from_fork+0x2c/0x40

Cc: Omar Sandoval <osandov@osandov.com>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Tested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-12-14 09:28:21 +01:00
..
partitions
partitions/efi: Fix integer overflow in GPT size calculation
2017-10-08 10:26:06 +02:00
badblocks.c
badblocks: badblocks_set/clear update unacked_exist
2016-10-21 15:45:47 -06:00
bio-integrity.c
block: rename bio bi_rw to bi_opf
2016-08-07 14:41:02 -06:00
bio.c
bio_copy_user_iov(): don't ignore ->iov_offset
2017-10-18 09:35:41 +02:00
blk-cgroup.c
blkcg: Unlock blkcg_pol_mutex only once when cpd == NULL
2016-09-30 10:31:20 +02:00
blk-core.c
block: Fix a race between blk_cleanup_queue() and timeout handling
2017-11-30 08:39:06 +00:00
blk-exec.c
block: Fix spelling in a source code comment
2016-07-20 21:28:22 -06:00
blk-flush.c
block: flush: fix IO hang in case of flood fua req
2016-10-26 07:49:27 -06:00
blk-integrity.c
block: fix blk_integrity_register to use template's interval_exp if not 0
2017-05-20 14:28:36 +02:00
blk-ioc.c
mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd
2015-11-06 17:50:42 -08:00
blk-lib.c
block: require write_same and discard requests align to logical block size
2016-10-11 15:06:30 -07:00
blk-map.c
Don't feed anything but regular iovec's to blk_rq_map_user_iov
2016-12-07 08:23:35 -08:00
blk-merge.c
block: make sure a big bio is split into at most 256 bvecs
2016-08-24 08:17:24 -06:00
blk-mq-cpumap.c
blk-mq: allow the driver to pass in a queue mapping
2016-09-15 08:42:03 -06:00
blk-mq-pci.c
blk-mq-pci: add a fallback when pci_irq_get_affinity returns NULL
2017-08-24 17:12:20 -07:00
blk-mq-sysfs.c
blk-mq: initialize mq kobjects in blk_mq_init_allocated_queue()
2017-12-14 09:28:21 +01:00
blk-mq-tag.c
Merge branch 'for-4.9/block-irq' of git://git.kernel.dk/linux-block
2016-10-09 17:29:33 -07:00
blk-mq-tag.h
Merge branch 'for-4.9/block-irq' of git://git.kernel.dk/linux-block
2016-10-09 17:29:33 -07:00
blk-mq.c
blk-mq: initialize mq kobjects in blk_mq_init_allocated_queue()
2017-12-14 09:28:21 +01:00
blk-mq.h
blk-mq: initialize mq kobjects in blk_mq_init_allocated_queue()
2017-12-14 09:28:21 +01:00
blk-settings.c
block: kill off q->flush_flags
2016-04-13 13:33:19 -06:00
blk-softirq.c
This adds a new gcc plugin named "latent_entropy". It is designed to
2016-10-15 10:03:15 -07:00
blk-sysfs.c
blk-mq: register device instead of disk
2016-09-21 07:56:16 -06:00
blk-tag.c
block: support different tag allocation policy
2015-01-23 14:15:46 -07:00
blk-throttle.c
blk-throttle: Extend slice if throttle group is not empty
2016-09-19 15:12:41 -06:00
blk-timeout.c
block: Fix a race between blk_cleanup_queue() and timeout handling
2017-11-30 08:39:06 +00:00
blk.h
blk-mq: remove ->map_queue
2016-09-15 08:42:03 -06:00
bounce.c
Merge branch 'for-linus' of git://git.kernel.dk/linux-block
2015-09-19 18:57:09 -07:00
bsg-lib.c
Revert "bsg-lib: don't free job in bsg_prepare_job"
2017-10-21 17:21:33 +02:00
bsg.c
sg_write()/bsg_write() is not fit to be called under KERNEL_DS
2017-01-09 08:32:25 +01:00
cfq-iosched.c
cfq-iosched: fix the delay of cfq_group's vdisktime under iops mode
2017-06-14 15:05:58 +02:00
cmdline-parser.c
block: remove unrelated header files and export symbol
2014-01-21 20:18:26 -08:00
compat_ioctl.c
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
deadline-iosched.c
block: do not merge requests without consulting with io scheduler
2016-07-20 21:35:12 -06:00
elevator.c
block: Fix secure erase
2016-08-16 09:16:51 -06:00
genhd.c
block: fix bdi vs gendisk lifetime mismatch
2016-08-04 14:19:16 -06:00
ioctl.c
block: invalidate the page cache when issuing BLKZEROOUT
2016-10-11 15:06:30 -07:00
ioprio.c
block: fix use-after-free in sys_ioprio_get()
2016-07-01 08:39:24 -06:00
Kconfig
Merge branch 'for-4.9/block-irq' of git://git.kernel.dk/linux-block
2016-10-09 17:29:33 -07:00
Kconfig.iosched
blkcg: make CONFIG_BLK_CGROUP bool
2012-03-06 21:27:21 +01:00
Makefile
Merge branch 'for-4.9/block-smp' of git://git.kernel.dk/linux-block
2016-10-09 17:32:20 -07:00
noop-iosched.c
elevator: use list_{first,prev,next}_entry
2015-11-16 15:21:48 -07:00
partition-generic.c
block: get rid of blk_integrity_revalidate()
2017-05-14 14:00:22 +02:00
scsi_ioctl.c
block: allow WRITE_SAME commands with the SG_IO ioctl
2017-03-22 12:43:38 +01:00
t10-pi.c
block: Consolidate static integrity profile properties
2015-10-21 14:42:38 -06:00