iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers
History
Lyude Paul a7e3ad5fdc drm/vblank: Use spin_(un)lock_irq() in drm_crtc_vblank_off() 
This got me confused for a bit while looking over this code: I had been
planning on adding some blocking function calls into this function, but
seeing the irqsave/irqrestore variants of spin_(un)lock() didn't make it
very clear whether or not that would actually be safe.

So I went ahead and reviewed every single driver in the kernel that uses
this function, and they all fall into three categories:

* Driver probe code
* ->atomic_disable() callbacks
* Legacy modesetting callbacks

All of these will be guaranteed to have IRQs enabled, which means it's
perfectly safe to block here. Just to make things a little less
confusing to others in the future, let's switch over to
spin_lock_irq()/spin_unlock_irq() to make that fact a little more
obvious.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Daniel Vetter <daniel@ffwll.ch>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Dave Airlie <airlied@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200627194657.156514-3-lyude@redhat.com
2020-07-16 18:16:31 -04:00
..
accessibility
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
acpi
libnvdimm for 5.8
2020-06-13 13:04:36 -07:00
amba
ARM: tegra: Replace zero-length array with flexible-array
2020-06-15 23:08:28 -05:00
android
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
ata
libata-5.8-2020-06-19
2020-06-19 13:09:40 -07:00
atm
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
auxdisplay
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
base
linux-kselftest-kunit-5.8-rc1
2020-06-09 10:04:47 -07:00
bcma
…
block
block-5.8-2020-06-19
2020-06-19 13:11:26 -07:00
bluetooth
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-06-03 16:27:18 -07:00
bus
Char/Misc driver patches for 5.8-rc1
2020-06-07 10:59:32 -07:00
cdrom
Merge branch 'work.sysctl' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-06-10 16:05:54 -07:00
char
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2020-06-21 10:01:03 -07:00
clk
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
clocksource
clocksource/drivers/timer-riscv: Use per-CPU timer interrupt
2020-06-09 19:11:22 -07:00
connector
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
counter
…
cpufreq
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
cpuidle
- Add the hwmon support on the i.MX SC (Anson Huang)
2020-06-12 14:10:21 -07:00
crypto
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2020-06-21 10:01:03 -07:00
dax
device-dax: add memory via add_memory_driver_managed()
2020-06-04 19:06:23 -07:00
dca
…
devfreq
…
dio
maccess: rename probe_kernel_{read,write} to copy_{from,to}_kernel_nofault
2020-06-17 10:57:41 -07:00
dma
dmaengine: tegra-apb: Replace zero-length array with flexible-array
2020-06-15 23:08:32 -05:00
dma-buf
dma-buf: fix dma-fence-chain out of order test
2020-07-02 15:21:40 +02:00
edac
Kbuild updates for v5.8 (2nd)
2020-06-13 13:29:16 -07:00
eisa
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
extcon
extcon: arizona: Fix runtime PM imbalance on error
2020-05-29 17:36:02 +09:00
firewire
firewire: ohci: Replace zero-length array with flexible-array
2020-06-15 23:08:31 -05:00
firmware
firmware: pcdp: Replace zero-length array with flexible-array
2020-06-15 23:08:32 -05:00
fpga
Char/Misc driver patches for 5.8-rc1
2020-06-07 10:59:32 -07:00
fsi
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
gnss
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
gpio
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
gpu
drm/vblank: Use spin_(un)lock_irq() in drm_crtc_vblank_off()
2020-07-16 18:16:31 -04:00
greybus
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
hid
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
hsi
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
hv
hyperv-next for 5.8
2020-06-03 15:00:05 -07:00
hwmon
Merge branch 'x86/entry' into ras/core
2020-06-11 15:17:57 +02:00
hwspinlock
…
hwtracing
stm class: Replace zero-length array with flexible-array
2020-06-15 23:08:32 -05:00
i2c
i2c: smbus: Fix spelling mistake in the comments
2020-06-19 10:09:16 +02:00
i3c
…
ide
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
idle
…
iio
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
infiniband
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
input
maccess: rename probe_kernel_{read,write} to copy_{from,to}_kernel_nofault
2020-06-17 10:57:41 -07:00
interconnect
More power management updates for 5.8-rc1
2020-06-10 14:04:39 -07:00
iommu
Kbuild updates for v5.8 (2nd)
2020-06-13 13:29:16 -07:00
ipack
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
irqchip
clocksource/drivers/timer-riscv: Use per-CPU timer interrupt
2020-06-09 19:11:22 -07:00
isdn
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
leds
LEDs pull request for 5.8-rc1.
2020-06-04 11:03:45 -07:00
lightnvm
for-5.8/block-2020-06-01
2020-06-02 15:29:19 -07:00
macintosh
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
mailbox
mailbox: qcom: Add ipq6018 apcs compatible
2020-06-10 22:43:57 -05:00
mcb
…
md
bcache: pr_info() format clean up in bcache_device_init()
2020-06-14 16:47:56 -06:00
media
media: pwc: Replace zero-length array with flexible-array
2020-06-15 23:08:32 -05:00
memory
…
memstick
…
message
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
mfd
mfd: mt6360: Fix register driver NULL pointer by adding driver name
2020-06-16 09:32:43 +01:00
misc
maccess: rename probe_kernel_{read,write} to copy_{from,to}_kernel_nofault
2020-06-17 10:57:41 -07:00
mmc
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
most
…
mtd
This pull request contains a single change for UBI:
2020-06-10 13:24:40 -07:00
mux
…
net
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-06-16 17:44:54 -07:00
nfc
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
ntb
NTB: perf: Fix race condition when run with ntb_test
2020-06-05 20:02:09 -04:00
nubus
…
nvdimm
nvdimm/region: always show the 'align' attribute
2020-06-17 14:08:31 -07:00
nvme
Kbuild updates for v5.8 (2nd)
2020-06-13 13:29:16 -07:00
nvmem
…
of
of_graph: add of_graph_is_present()
2020-07-01 10:49:02 +02:00
opp
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
oprofile
oprofile: Replace zero-length array with flexible-array
2020-06-15 23:08:32 -05:00
parisc
…
parport
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
pci
Kbuild updates for v5.8 (2nd)
2020-06-13 13:29:16 -07:00
pcmcia
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
perf
arm64 merge window fixes for -rc1
2020-06-11 12:53:23 -07:00
phy
phy: samsung: Replace zero-length array with flexible-array
2020-06-15 23:08:32 -05:00
pinctrl
pinctrl: single: fix function name in documentation
2020-06-20 22:41:32 +02:00
platform
Kbuild updates for v5.8 (2nd)
2020-06-13 13:29:16 -07:00
pnp
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
power
power supply and reset changes for the v5.8 series
2020-06-10 11:28:35 -07:00
powercap
Kbuild updates for v5.8 (2nd)
2020-06-13 13:29:16 -07:00
pps
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
ps3
…
ptp
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
pwm
pwm: Add missing "CONFIG_" prefix
2020-06-04 19:09:28 +02:00
rapidio
rapidio: Replace zero-length array with flexible-array
2020-06-15 23:08:32 -05:00
ras
…
regulator
Merge remote-tracking branch 'regulator/for-5.8' into regulator-linus
2020-06-01 13:01:44 +01:00
remoteproc
remoteproc updates for v5.8
2020-06-08 13:01:08 -07:00
reset
Char/Misc driver patches for 5.8-rc1
2020-06-07 10:59:32 -07:00
rpmsg
remoteproc updates for v5.8
2020-06-08 13:01:08 -07:00
rtc
RTC for 5.8
2020-06-07 16:11:23 -07:00
s390
s390/qdio: warn about unexpected SLSB states
2020-06-17 23:05:05 +02:00
sbus
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
scsi
scsi: Wire up ata_scsi_dma_need_drain for SAS HBA drivers
2020-06-15 23:40:43 -04:00
sfi
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
sh
…
siox
…
slimbus
…
soc
soc: ti: Replace zero-length array with flexible-array
2020-06-15 23:08:32 -05:00
soundwire
…
spi
Char/Misc driver patches for 5.8-rc1
2020-06-07 10:59:32 -07:00
spmi
…
ssb
…
staging
Kbuild updates for v5.8 (2nd)
2020-06-13 13:29:16 -07:00
target
Kbuild updates for v5.8 (2nd)
2020-06-13 13:29:16 -07:00
tc
…
tee
mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
2020-06-09 09:39:14 -07:00
thermal
- Add the hwmon support on the i.MX SC (Anson Huang)
2020-06-12 14:10:21 -07:00
thunderbolt
USB/PHY driver updates for 5.8-rc1
2020-06-07 09:42:16 -07:00
tty
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
uio
…
usb
Kbuild updates for v5.8 (2nd)
2020-06-13 13:29:16 -07:00
vdpa
ifcvf: implement config interrupt in IFCVF
2020-06-06 16:26:47 -04:00
vfio
kernel: better document the use_mm/unuse_mm API contract
2020-06-10 19:14:18 -07:00
vhost
Kbuild updates for v5.8 (2nd)
2020-06-13 13:29:16 -07:00
video
fbdev: sm712fb: set error code in probe
2020-07-10 16:17:29 +02:00
virt
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
virtio
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
visorbus
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
vlynq
…
vme
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
w1
w1: Replace zero-length array with flexible-array
2020-06-15 23:08:32 -05:00
watchdog
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
xen
The X86 entry, exception and interrupt code rework
2020-06-13 10:05:47 -07:00
zorro
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
Kconfig
…
Makefile
…