Dave Wysochanski
618b65dbde
SUNRPC: Handle 0 length opaque XDR object data properly ...
[ Upstream commit e4a7d1f7707eb44fd953a31dd59eff82009d879c ]
When handling an auth_gss downcall, it's possible to get 0-length
opaque object for the acceptor. In the case of a 0-length XDR
object, make sure simple_get_netobj() fills in dest->data = NULL,
and does not continue to kmemdup() which will set
dest->data = ZERO_SIZE_PTR for the acceptor.
The trace event code can handle NULL but not ZERO_SIZE_PTR for a
string, and so without this patch the rpcgss_context trace event
will crash the kernel as follows:
[ 162.887992] BUG: kernel NULL pointer dereference, address: 0000000000000010
[ 162.898693] #PF: supervisor read access in kernel mode
[ 162.900830] #PF: error_code(0x0000) - not-present page
[ 162.902940] PGD 0 P4D 0
[ 162.904027] Oops: 0000 [#1 ] SMP PTI
[ 162.905493] CPU: 4 PID: 4321 Comm: rpc.gssd Kdump: loaded Not tainted 5.10.0 #133
[ 162.908548] Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011
[ 162.910978] RIP: 0010:strlen+0x0/0x20
[ 162.912505] Code: 48 89 f9 74 09 48 83 c1 01 80 39 00 75 f7 31 d2 44 0f b6 04 16 44 88 04 11 48 83 c2 01 45 84 c0 75 ee c3 0f 1f 80 00 00 00 00 <80> 3f 00 74 10 48 89 f8 48 83 c0 01 80 38 00 75 f7 48 29 f8 c3 31
[ 162.920101] RSP: 0018:ffffaec900c77d90 EFLAGS: 00010202
[ 162.922263] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00000000fffde697
[ 162.925158] RDX: 000000000000002f RSI: 0000000000000080 RDI: 0000000000000010
[ 162.928073] RBP: 0000000000000010 R08: 0000000000000e10 R09: 0000000000000000
[ 162.930976] R10: ffff8e698a590cb8 R11: 0000000000000001 R12: 0000000000000e10
[ 162.933883] R13: 00000000fffde697 R14: 000000010034d517 R15: 0000000000070028
[ 162.936777] FS: 00007f1e1eb93700(0000) GS:ffff8e6ab7d00000(0000) knlGS:0000000000000000
[ 162.940067] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 162.942417] CR2: 0000000000000010 CR3: 0000000104eba000 CR4: 00000000000406e0
[ 162.945300] Call Trace:
[ 162.946428] trace_event_raw_event_rpcgss_context+0x84/0x140 [auth_rpcgss]
[ 162.949308] ? __kmalloc_track_caller+0x35/0x5a0
[ 162.951224] ? gss_pipe_downcall+0x3a3/0x6a0 [auth_rpcgss]
[ 162.953484] gss_pipe_downcall+0x585/0x6a0 [auth_rpcgss]
[ 162.955953] rpc_pipe_write+0x58/0x70 [sunrpc]
[ 162.957849] vfs_write+0xcb/0x2c0
[ 162.959264] ksys_write+0x68/0xe0
[ 162.960706] do_syscall_64+0x33/0x40
[ 162.962238] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[ 162.964346] RIP: 0033:0x7f1e1f1e57df
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-02-13 13:52:56 +01:00
2020-11-05 11:43:20 +01:00
2021-01-17 14:05:31 +01:00
2020-08-11 15:33:40 +02:00
2020-10-01 13:17:58 +02:00
2020-07-31 18:39:31 +02:00
2020-12-02 08:49:50 +01:00
2020-12-30 11:51:05 +01:00
2019-07-25 18:00:41 -07:00
2020-04-21 09:04:53 +02:00
2020-12-21 13:27:04 +01:00
2019-10-28 13:33:41 -07:00
2020-12-11 13:23:32 +01:00
2020-11-05 11:43:34 +01:00
2021-02-10 09:25:32 +01:00
2021-01-23 15:57:59 +01:00
2020-06-17 16:40:32 +02:00
2020-01-04 19:18:58 +01:00
2020-04-23 10:36:45 +02:00
2020-09-23 12:40:33 +02:00
2020-01-09 10:20:06 +01:00
2020-04-21 09:04:44 +02:00
2020-03-18 07:17:44 +01:00
2019-09-26 08:56:17 +02:00
2021-02-10 09:25:32 +01:00
2021-02-03 23:25:55 +01:00
2020-12-08 10:40:23 +01:00
2019-09-27 10:27:14 +02:00
2021-02-13 13:52:54 +01:00
2020-07-22 09:32:47 +02:00
2021-02-10 09:25:28 +01:00
2020-10-01 13:17:15 +02:00
2021-02-13 13:52:55 +01:00
2020-10-01 13:18:17 +02:00
2019-12-18 16:08:42 +01:00
2021-01-12 20:16:13 +01:00
2021-02-03 23:25:59 +01:00
2020-11-24 13:28:57 +01:00
2020-07-22 09:32:46 +02:00
2020-04-29 16:33:08 +02:00
2021-02-03 23:26:01 +01:00
2020-12-08 10:40:27 +01:00
2020-09-09 19:12:29 +02:00
2019-10-28 13:33:41 -07:00
2019-12-04 22:30:54 +01:00
2020-09-26 18:03:15 +02:00
2020-08-05 09:59:44 +02:00
2020-11-24 13:29:05 +01:00
2020-12-08 10:40:23 +01:00
2021-02-10 09:25:27 +01:00
2021-01-27 11:47:54 +01:00
2021-01-23 15:58:00 +01:00
2020-11-24 13:28:58 +01:00
2021-02-13 13:52:56 +01:00
2021-02-07 15:35:46 +01:00
2021-01-23 15:58:00 +01:00
2020-12-08 10:40:23 +01:00
2020-10-01 13:17:31 +02:00
2020-11-10 12:37:30 +01:00
2019-08-10 15:25:47 -07:00
2021-02-03 23:25:56 +01:00
2020-12-08 10:40:26 +01:00
2020-12-30 11:50:53 +01:00
2021-02-03 23:25:59 +01:00
2020-08-21 13:05:25 +02:00
2020-04-01 11:02:18 +02:00
2020-08-19 08:16:22 +02:00
618b65dbde