linux

iv/linux

History

Mayank Rana 96bd39df29 usb: dwc3: gadget: Fix list_del corruption in dwc3_ep_dequeue

dwc3_ep_dequeue() waits for completion of End Transfer command using
wait_event_lock_irq(), which will release the dwc3->lock while waiting
and reacquire after completion. This allows a potential race condition
with ep_disable() which also removes all requests from started_list
and pending_list.

The check for NULL r->trb should catch this but currently it exits to
the wrong 'out1' label which calls dwc3_gadget_giveback(). Since its
list entry was already removed, if CONFIG_DEBUG_LIST is enabled a
'list_del corruption' bug is thrown since its next/prev pointers are
already LIST_POISON1/2. If r->trb is NULL it should simply exit to
'out0'.

Fixes: cf3113d893d4 ("usb: dwc3: gadget: properly increment dequeue pointer on ep_dequeue")
Cc: stable@vger.kernel.org # v4.12+
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
Signed-off-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

2018-04-25 14:26:26 +03:00

core.c

usb: changes for v4.17 merge window

2018-03-23 13:33:09 +01:00

core.h

usb: dwc3: Dump LSP and BMU debug info

2018-03-22 10:49:02 +02:00

debug.h

usb: dwc3: debug: decode a few more features

2017-12-11 12:36:48 +02:00

debugfs.c

usb: dwc3: Dump LSP and BMU debug info