John Fastabend a922afb64d ixgbe: do not stop tx queues in ixgbe_set_tso
Disabling TSO can cause the dev_watchdog timer to be triggered because
when TSO is disabled netif_tx_stop_all_queues is called.  If the watchdog
timer fires while the queues are stopped and traffic has not recently been
sent on a paticular queue this is falsly identified as a hang and
ndo_tx_timeout() is called.  This is ocossionally seen during testing.

This removes the netif_tx_stop_all_queues() it is not needed.  The scheduler
submits skb's with dev_hard_start_xmit(), this checks if netif_needs_gso and
if so it calls dev_gso_segment.  Disabling TSO will cause dev_hard_start_xmit()
to do the gso processing.   However ixgbe does not use the features flags to
determine if it needs to use tso or not instead it uses skb->gso_size so
ixgbe will process these frames correctly regardless of the netdev features
flag.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2010-02-26 02:10:11 -08:00
..
2010-01-03 21:42:50 -08:00
2010-02-18 14:47:48 -08:00
2010-02-18 14:47:48 -08:00
2009-09-01 01:13:50 -07:00
2010-02-18 14:47:48 -08:00
2010-02-18 14:47:48 -08:00
2010-02-18 14:47:48 -08:00
2010-02-18 14:47:48 -08:00
2010-02-08 22:44:18 -08:00
2009-04-04 16:51:14 -07:00
2010-02-16 15:19:03 -08:00
2009-08-12 23:03:00 -07:00
2010-02-17 13:35:44 -08:00
2010-02-17 13:35:44 -08:00
2010-02-17 13:35:44 -08:00
2009-11-05 20:00:29 -08:00
2009-10-11 23:30:16 -07:00
2009-10-11 23:30:16 -07:00
2009-11-11 19:22:21 -08:00
2009-10-11 11:20:58 -07:00
2010-02-26 02:08:47 -08:00
2009-04-16 02:20:08 -07:00
2009-09-07 01:56:52 -07:00
2009-11-20 15:35:04 -08:00
2009-10-13 11:48:18 -07:00
2009-10-20 19:11:06 -07:00
2010-01-09 23:00:32 -08:00
2010-01-28 06:01:35 -08:00
2009-04-16 02:20:21 -07:00
2009-12-26 20:38:23 -08:00
2010-01-18 00:29:19 -08:00
2009-04-29 17:32:34 -07:00
2010-02-26 02:08:47 -08:00
2009-10-01 15:14:54 -07:00
2010-02-12 16:21:01 -08:00
2009-12-11 16:16:33 -08:00
2009-03-27 00:46:48 -07:00
2010-02-26 02:08:42 -08:00
2010-02-17 17:27:40 -08:00
2010-02-17 16:35:17 -08:00
2009-11-26 15:51:29 -08:00
2009-01-11 00:06:36 -08:00