Alexei Starovoitov b9979db834 bpf: Fix propagation of bounds from 64-bit min/max into 32-bit and var_off. ...

Before this fix:
166: (b5) if r2 <= 0x1 goto pc+22
from 166 to 189: R2=invP(id=1,umax_value=1,var_off=(0x0; 0xffffffff))

After this fix:
166: (b5) if r2 <= 0x1 goto pc+22
from 166 to 189: R2=invP(id=1,umax_value=1,var_off=(0x0; 0x1))

While processing BPF_JLE the reg_set_min_max() would set true_reg->umax_value = 1
and call __reg_combine_64_into_32(true_reg).

Without the fix it would not pass the condition:
if (__reg64_bound_u32(reg->umin_value) && __reg64_bound_u32(reg->umax_value))

since umin_value == 0 at this point.
Before commit 10bf4e83167c the umin was incorrectly ingored.
The commit 10bf4e83167c fixed the correctness issue, but pessimized
propagation of 64-bit min max into 32-bit min max and corresponding var_off.

Fixes: 10bf4e83167c ("bpf: Fix propagation of 32 bit unsigned bounds from 64 bit bounds")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/20211101222153.78759-1-alexei.starovoitov@gmail.com

2021-11-01 18:05:11 -07:00

..

.gitignore

.gitignore: add SPDX License Identifier

2020-03-25 11:50:48 +01:00

and.c

bpf, selftests: Adjust few selftest outcomes wrt unreachable code

2021-06-14 23:06:38 +02:00

array_access.c

bpf: Fix propagation of bounds from 64-bit min/max into 32-bit and var_off.

2021-11-01 18:05:11 -07:00

atomic_and.c

bpf, x86: Fix BPF_FETCH atomic and/or/xor with r0 as src

2021-02-22 18:03:11 +01:00

atomic_bounds.c

bpf: Propagate stack bounds to registers in atomics w/ BPF_FETCH

2021-02-02 18:23:29 -08:00

atomic_cmpxchg.c

selftests/bpf: Some more atomic tests

2021-10-20 18:09:08 -07:00

atomic_fetch_add.c

bpf: Add tests for new BPF atomic operations

2021-01-14 18:34:29 -08:00

atomic_fetch.c

selftests/bpf: Some more atomic tests

2021-10-20 18:09:08 -07:00

atomic_invalid.c

selftests/bpf: Some more atomic tests

2021-10-20 18:09:08 -07:00

atomic_or.c

bpf: Explicitly zero-extend R0 after 32-bit cmpxchg

2021-03-04 19:06:03 -08:00

atomic_xchg.c

bpf: Add tests for new BPF atomic operations

2021-01-14 18:34:29 -08:00

atomic_xor.c

selftests/bpf: Fix endianness issues in atomic tests

2021-02-10 11:55:22 -08:00

basic_call.c

…

basic_instr.c

selftests: bpf: add tests for shifts by zero

2019-07-03 11:14:28 +02:00

basic_stack.c

selftest/bpf: Adjust expected verifier errors

2021-02-10 10:44:19 -08:00

basic_stx_ldx.c

…

basic.c

selftests/bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

2020-10-06 20:16:57 -07:00

bounds_deduction.c

bpf: Update selftests to reflect new error states

2021-04-16 23:52:15 +02:00

bounds_mix_sign_unsign.c

bpf: Update selftests to reflect new error states

2021-04-16 23:52:15 +02:00

bounds.c

bpf, selftests: Adjust few selftest outcomes wrt unreachable code

2021-06-14 23:06:38 +02:00

bpf_get_stack.c

bpf/selftests: Add bpf_get_task_stack retval bounds verifier test

2021-04-19 18:23:33 -07:00

calls.c

bpf: selftests: Add selftests for module kfunc support

2021-10-05 17:07:42 -07:00

cfg.c

selftests/bpf: fix tests

2019-06-19 02:22:52 +02:00

cgroup_inv_retcode.c

selftests: bpf: break up the rest of test_verifier

2019-01-27 21:37:45 -08:00

cgroup_skb.c

…

cgroup_storage.c

…

const_or.c

selftest/bpf: Adjust expected verifier errors

2021-02-10 10:44:19 -08:00

ctx_sk_lookup.c

selftests: bpf: Don't run sk_lookup in verifier tests

2021-03-04 19:11:30 -08:00

ctx_sk_msg.c

selftests/bpf: add "any alignment" annotation for some tests

2019-02-05 16:56:10 +01:00

ctx_skb.c

selftests/bpf: Use __BYTE_ORDER__

2021-10-25 20:39:42 -07:00

ctx.c

bpf: Rename BPF_XADD and prepare to encode other atomics in .imm

2021-01-14 18:34:29 -08:00

d_path.c

selftests/bpf: Add verifier test for d_path helper

2020-08-25 15:41:15 -07:00

dead_code.c

selftests, bpf: Test that dead ldx_w insns are accepted

2021-08-13 17:46:26 +02:00

direct_packet_access.c

bpf: Rename BPF_XADD and prepare to encode other atomics in .imm

2021-01-14 18:34:29 -08:00

direct_stack_access_wraparound.c

…

direct_value_access.c

selftests/bpf: Mark tests that require unaligned memory access

2020-11-18 17:45:35 -08:00

div0.c

…

div_overflow.c

bpf: fix div64 overflow tests to properly detect errors

2019-06-13 23:07:00 +02:00

event_output.c

selftests/bpf: Fix cgroup sockopt verifier test

2020-07-11 01:32:15 +02:00

helper_access_var_len.c

selftest/bpf: Adjust expected verifier errors

2021-02-10 10:44:19 -08:00

helper_packet_access.c

…

helper_value_access.c

bpf, selftests: Use bpf_probe_read_kernel

2020-06-02 21:04:04 +02:00

int_ptr.c

selftest/bpf: Adjust expected verifier errors

2021-02-10 10:44:19 -08:00

jit.c

bpf, x64: Save bytes for DIV by reducing reg copies

2021-10-06 15:24:36 +02:00

jmp32.c

bpf, selftests: Adjust few selftest outcomes wrt unreachable code

2021-06-14 23:06:38 +02:00

jset.c

bpf, selftests: Adjust few selftest outcomes wrt unreachable code

2021-06-14 23:06:38 +02:00

jump.c

bpf: add various test cases for backward jumps

2019-05-13 01:08:55 +02:00

junk_insn.c

…

ld_abs.c

selftests: bpf: break up the rest of test_verifier

2019-01-27 21:37:45 -08:00

ld_dw.c

selftests/bpf: synthetic tests to push verifier limits

2019-04-04 01:27:38 +02:00

ld_imm64.c

selftests/bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

2020-10-06 20:16:57 -07:00

ld_ind.c

…

leak_ptr.c

bpf: Rename BPF_XADD and prepare to encode other atomics in .imm

2021-01-14 18:34:29 -08:00

loops1.c

bpf: Add loop test case with 32 bit reg comparison against 0

2019-10-04 12:27:36 -07:00

lwt.c

selftests/bpf: Use __BYTE_ORDER__

2021-10-25 20:39:42 -07:00

map_in_map.c

…

map_ptr_mixing.c

bpf: Support access to bpf map fields

2020-06-22 22:22:58 +02:00

map_ptr.c

bpf: Update selftests to reflect new error states

2021-04-16 23:52:15 +02:00

map_ret_val.c

…

masking.c

selftests: bpf: break up the rest of test_verifier

2019-01-27 21:37:45 -08:00

meta_access.c

bpf: Rename BPF_XADD and prepare to encode other atomics in .imm

2021-01-14 18:34:29 -08:00

perf_event_sample_period.c

selftests/bpf: Use __BYTE_ORDER__

2021-10-25 20:39:42 -07:00

precise.c

bpf, selftests: Use bpf_probe_read_kernel

2020-06-02 21:04:04 +02:00

prevent_map_lookup.c

selftests/bpf: Test that lookup on SOCKMAP/SOCKHASH is allowed

2020-04-29 23:30:59 +02:00

raw_stack.c

selftest/bpf: Adjust expected verifier errors

2021-02-10 10:44:19 -08:00

raw_tp_writable.c

selftests/bpf: Mark tests that require unaligned memory access

2020-11-18 17:45:35 -08:00

ref_tracking.c

selftests/bpf: Mark tests that require unaligned memory access

2020-11-18 17:45:35 -08:00

regalloc.c

selftests/bpf: Mark tests that require unaligned memory access

2020-11-18 17:45:35 -08:00

runtime_jit.c

bpf: Add further test_verifier cases for record_func_key

2019-12-19 13:39:22 -08:00

scale.c

selftests/bpf: two scale tests

2019-04-16 10:18:15 +02:00

search_pruning.c

selftests: bpf: break up the rest of test_verifier

2019-01-27 21:37:45 -08:00

sock.c

bpf: selftest: Ensure the return value of bpf_skc_to helpers must be checked

2020-10-19 15:57:42 -07:00

spill_fill.c

bpf: selftest: Add verifier tests for <8-byte scalar spill and refill

2021-09-26 13:07:28 -07:00

spin_lock.c

selftests/bpf: add "any alignment" annotation for some tests

2019-02-05 16:56:10 +01:00

stack_ptr.c

bpf, selftests: Adjust few selftest result_unpriv outcomes

2021-05-25 22:08:53 +02:00

subreg.c

selftests: bpf: complete sub-register zero extension checks

2019-05-29 13:31:05 +02:00

uninit.c

…

unpriv.c

bpf, selftests: Adjust few selftest outcomes wrt unreachable code

2021-06-14 23:06:38 +02:00

value_adj_spill.c

…

value_illegal_alu.c

bpf: Rename BPF_XADD and prepare to encode other atomics in .imm

2021-01-14 18:34:29 -08:00

value_or_null.c

bpf: Selftests, verifier case for non null pointer map value branch

2020-05-21 17:44:25 -07:00

value_ptr_arith.c

bpf, selftests: Add test cases for pointer alu from multiple paths

2021-07-16 16:57:07 +02:00

value.c

…

var_off.c

selftest/bpf: Verifier tests for var-off access

2021-02-10 10:44:19 -08:00

wide_access.c

selftests/bpf: Mark tests that require unaligned memory access

2020-11-18 17:45:35 -08:00

xadd.c

bpf: Rename BPF_XADD and prepare to encode other atomics in .imm

2021-01-14 18:34:29 -08:00

xdp_direct_packet_access.c

selftests: bpf: break up the rest of test_verifier

2019-01-27 21:37:45 -08:00

xdp.c

selftests: bpf: break up the rest of test_verifier

2019-01-27 21:37:45 -08:00