iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Jiri Pirko 94e2557d08 net: sched: move block device tracking into tcf_block_get/put_ext() 
Inserting the device to block xarray in qdisc_create() is not suitable
place to do this. As it requires use of tcf_block() callback, it causes
multiple issues. It is called for all qdisc types, which is incorrect.

So, instead, move it to more suitable place, which is tcf_block_get_ext()
and make sure it is only done for qdiscs that use block infrastructure
and also only for blocks which are shared.

Symmetrically, alter the cleanup path, move the xarray entry removal
into tcf_block_put_ext().

Fixes: 913b47d3424e ("net/sched: Introduce tc block netdev tracking infra")
Reported-by: Ido Schimmel <idosch@nvidia.com>
Closes: https://lore.kernel.org/all/ZY1hBb8GFwycfgvd@shredder/
Reported-by: Kui-Feng Lee <sinquersw@gmail.com>
Closes: https://lore.kernel.org/all/ce8d3e55-b8bc-409c-ace9-5cf1c4f7c88e@gmail.com/
Reported-and-tested-by: syzbot+84339b9e7330daae4d66@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/0000000000007c85f5060dcc3a28@google.com/
Reported-and-tested-by: syzbot+806b0572c8d06b66b234@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/00000000000082f2f2060dcc3a92@google.com/
Reported-and-tested-by: syzbot+0039110f932d438130f9@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/0000000000007fbc8c060dcc3a5c@google.com/
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Victor Nogueira <victor@mojatatu.com>
Tested-by: Victor Nogueira <victor@mojatatu.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2024-01-05 11:19:08 +00:00
..
6lowpan
…
9p
net: 9p: avoid freeing uninit memory in p9pdu_vreadf
2023-12-13 05:44:30 +09:00
802
net: fill in MODULE_DESCRIPTION()s under net/802*
2023-10-28 11:29:28 +01:00
8021q
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2023-12-21 22:17:23 +01:00
appletalk
net: remove SOCK_DEBUG leftovers
2023-12-26 20:31:01 +00:00
atm
atm: Fix Use-After-Free in do_vcc_ioctl
2023-12-12 13:14:08 +01:00
ax25
net: implement lockless SO_PRIORITY
2023-10-01 19:09:54 +01:00
batman-adv
batman-adv: Switch to linux/array_size.h
2023-11-14 08:16:34 +01:00
bluetooth
Bluetooth: Fix atomicity violation in {min,max}_key_size_set
2023-12-22 13:00:36 -05:00
bpf
bpf: Fix dtor CFI
2023-12-15 16:25:55 -08:00
bpfilter
…
bridge
bridge: cfm: fix enum typo in br_cc_ccm_tx_parse
2023-12-26 22:38:13 +00:00
caif
…
can
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2023-10-12 17:07:34 -07:00
ceph
This update includes the following changes:
2023-11-02 16:15:30 -10:00
core
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2024-01-04 18:06:46 -08:00
dcb
…
dccp
net: remove SOCK_DEBUG leftovers
2023-12-26 20:31:01 +00:00
devlink
devlink: extend multicast filtering by port index
2023-12-19 15:31:40 +01:00
dns_resolver
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2024-01-04 18:06:46 -08:00
dsa
net: rename dsa_realloc_skb to skb_ensure_writable_head_tail
2023-12-27 13:08:09 +00:00
ethernet
…
ethtool
Revert "Introduce PHY listing and link_topology tracking"
2024-01-04 16:05:47 -08:00
handshake
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2023-10-26 13:46:28 -07:00
hsr
net: hsr: Add support for MC filtering at the slave device
2023-11-22 10:51:32 +00:00
ieee802154
mac802154: Avoid new associations while disassociating
2023-12-15 11:14:57 +01:00
ife
net: sched: ife: fix potential use-after-free
2023-12-15 10:50:18 +00:00
ipv4
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2024-01-04 18:06:46 -08:00
ipv6
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2024-01-04 18:06:46 -08:00
iucv
iucv: make iucv_bus const
2023-12-29 07:46:38 +00:00
kcm
net: kcm: fix direct access to bv_len
2024-01-03 18:37:22 -08:00
key
…
l2tp
ipv6: annotate data-races around np->ucast_oif
2023-12-11 10:59:17 +00:00
l3mdev
…
lapb
…
llc
llc: verify mac len before reading mac header
2023-11-01 22:21:32 -07:00
mac80211
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2024-01-04 18:06:46 -08:00
mac802154
mac802154: Avoid new associations while disassociating
2023-12-15 11:14:57 +01:00
mctp
mctp: perform route lookups under a RCU read-side lock
2023-10-10 19:43:22 -07:00
mpls
…
mptcp
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2024-01-04 18:06:46 -08:00
ncsi
net/ncsi: Add NC-SI 1.2 Get MC MAC Address command
2023-11-18 15:00:51 +00:00
netfilter
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2024-01-04 18:06:46 -08:00
netlabel
…
netlink
genetlink: Use internal flags for multicast groups
2023-12-29 08:43:59 +00:00
netrom
net: implement lockless SO_PRIORITY
2023-10-01 19:09:54 +01:00
nfc
nfc: Do not send datagram if socket state isn't LLCP_BOUND
2023-12-25 07:29:04 +00:00
nsh
…
openvswitch
net/sched: act_ct: Always fill offloading tuple iifidx
2023-11-08 17:47:08 -08:00
packet
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2023-12-07 17:53:17 -08:00
phonet
…
psample
genetlink: Use internal flags for multicast groups
2023-12-29 08:43:59 +00:00
qrtr
net: qrtr: ns: Return 0 if server port is not present
2024-01-01 18:41:29 +00:00
rds
ipv6: annotate data-races around np->mcast_oif
2023-12-11 10:59:17 +00:00
rfkill
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2023-12-21 22:17:23 +01:00
rose
net/rose: fix races in rose_kill_by_device()
2023-12-15 11:59:53 +00:00
rxrpc
rxrpc: Defer the response to a PING ACK until we've parsed it
2023-11-17 02:50:33 +00:00
sched
net: sched: move block device tracking into tcf_block_get/put_ext()
2024-01-05 11:19:08 +00:00
sctp
sctp: fix busy polling
2024-01-04 10:29:18 +00:00
smc
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2024-01-04 18:06:46 -08:00
strparser
…
sunrpc
nfsd-6.7 fixes:
2023-12-20 11:16:50 -08:00
switchdev
…
tipc
tipc: Remove some excess struct member documentation
2023-12-22 23:14:43 +00:00
tls
net: tls, update curr on splice as well
2023-12-07 09:52:28 -08:00
unix
bpf, sockmap: af_unix stream sockets need to hold ref for pair sock
2023-11-30 00:25:16 +01:00
vmw_vsock
vsock/virtio: use skb_frag_*() helpers
2024-01-03 18:37:16 -08:00
wireless
Just a couple of more things over the holidays:
2024-01-04 17:00:08 -08:00
x25
net: remove SOCK_DEBUG leftovers
2023-12-26 20:31:01 +00:00
xdp
netdev
2023-12-18 16:46:08 -08:00
xfrm
bpf: xfrm: Add bpf_xdp_get_xfrm_state() kfunc
2023-12-14 17:12:49 -08:00
compat.c
…
devres.c
…
Kconfig
net: add skb_segment kunit test
2023-10-11 10:39:01 +01:00
Kconfig.debug
…
Makefile
…
socket.c
net: Save and restore msg_namelen in sock_sendmsg
2024-01-03 11:37:57 +00:00
sysctl_net.c
…