linux/Documentation
Paul Bolle aa98a28563 Documentation/misc-devices/mei/mei-amt-version.c: remove unneeded call of mei_deinit()
Building mei-amt-version.o triggers a GCC warning:
    Documentation/misc-devices/mei/mei-amt-version.c: In function 'main':
    Documentation/misc-devices/mei/mei-amt-version.c:103:5: warning: 'acmd.fd' is used uninitialized in this function [-Wuninitialized]
      if (cl->fd != -1)
         ^
    Documentation/misc-devices/mei/mei-amt-version.c:443:21: note: 'acmd.fd' was declared here
      struct amt_host_if acmd;
                         ^

GCC is correct. See, the call chain that GCC detects must be
    main()
        amt_host_if_init()
            mei_init()
                mei_deinit()

But when we enter mei_deinit() struct amt_host_if acmd is still
unitialized. That makes the test for (effectively) amt_host_if->mei_cl->fd
bogus.

But it turns out that call of mei_deinit() isn't needed at all. All of
the members of mei_cl will be set later in mei_init() and none will be
used before they are set. So we can simply drop this call of
mei_deinit().

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Cc: Tomas Winkler <tomas.winkler@intel.com>
Reported-by: David Howells <dhowells@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08 15:20:20 -08:00
..
2013-12-18 16:51:15 -08:00
2013-11-12 15:01:39 +09:00
2013-04-02 09:39:55 -07:00
2013-10-17 21:18:32 +02:00
2013-11-27 11:03:38 -08:00
2013-01-10 01:27:46 +01:00
2013-07-25 12:34:15 +02:00
2013-09-15 17:41:30 -04:00
2013-10-16 13:35:02 -07:00
2013-11-14 11:04:40 -08:00
2012-07-29 21:11:05 -03:00
2013-09-25 12:34:32 +01:00
2012-12-05 23:52:10 +00:00
2013-10-24 10:51:33 +02:00
2013-09-05 16:36:21 -06:00