linux/arch/arm/mach-omap1
Janusz Krzysztofik ab6ead7d07 ARM: OMAP1: ams-delta: Fix impossible .irq < 0
Since the very beginning, unsigned int .irq member of struct
plat_serial8250_port introduced by commit eff443df679e ("OMAP1:
AMS_DELTA: add modem support") was statically initialized to a negative
value -EINVAL.  Moreover, commit 0812db943748 ("ARM: OMAP1: ams-delta:
assign MODEM IRQ from GPIO descriptor") has introduced some new code
which checks for that member carrying a negative value which is
impossible.

Use IRQ_NOTCONNECTED instead of -EINVAL. Also, drop the valueless check
and let the modem device be registered regardless of .irq value, and
the value handled by "serial8250" driver.

Fixes: 0812db943748 ("ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Tony Lindgren <tony@atomide.com>
2018-10-04 07:29:41 -07:00
..
2018-07-02 04:09:35 -07:00
2018-07-02 04:09:35 -07:00
2018-07-02 04:09:35 -07:00
2013-03-13 04:10:57 -06:00
2015-12-01 21:52:50 +01:00
2015-12-01 21:52:50 +01:00
2018-05-17 16:27:58 +02:00
2012-10-31 15:37:14 -07:00
2015-07-28 13:58:13 +02:00
2013-06-18 00:12:34 -07:00
2018-06-12 16:19:22 -07:00
2012-10-31 15:37:14 -07:00
2012-10-31 15:37:14 -07:00