iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/block
History
Ye Bin 2bcab471a2 block: Fix fsync always failed if once failed 
commit 8a7518931baa8ea023700987f3db31cb0a80610b upstream.

We do test with inject error fault base on v4.19, after test some time we found
sync /dev/sda always failed.
[root@localhost] sync /dev/sda
sync: error syncing '/dev/sda': Input/output error

scsi log as follows:
[19069.812296] sd 0:0:0:0: [sda] tag#64 Send: scmd 0x00000000d03a0b6b
[19069.812302] sd 0:0:0:0: [sda] tag#64 CDB: Synchronize Cache(10) 35 00 00 00 00 00 00 00 00 00
[19069.812533] sd 0:0:0:0: [sda] tag#64 Done: SUCCESS Result: hostbyte=DID_OK driverbyte=DRIVER_OK
[19069.812536] sd 0:0:0:0: [sda] tag#64 CDB: Synchronize Cache(10) 35 00 00 00 00 00 00 00 00 00
[19069.812539] sd 0:0:0:0: [sda] tag#64 scsi host busy 1 failed 0
[19069.812542] sd 0:0:0:0: Notifying upper driver of completion (result 0)
[19069.812546] sd 0:0:0:0: [sda] tag#64 sd_done: completed 0 of 0 bytes
[19069.812549] sd 0:0:0:0: [sda] tag#64 0 sectors total, 0 bytes done.
[19069.812564] print_req_error: I/O error, dev sda, sector 0

ftrace log as follows:
 rep-306069 [007] .... 19654.923315: block_bio_queue: 8,0 FWS 0 + 0 [rep]
 rep-306069 [007] .... 19654.923333: block_getrq: 8,0 FWS 0 + 0 [rep]
 kworker/7:1H-250   [007] .... 19654.923352: block_rq_issue: 8,0 FF 0 () 0 + 0 [kworker/7:1H]
 <idle>-0     [007] ..s. 19654.923562: block_rq_complete: 8,0 FF () 18446744073709551615 + 0 [0]
 <idle>-0     [007] d.s. 19654.923576: block_rq_complete: 8,0 WS () 0 + 0 [-5]

As 8d6996630c03 introduce 'fq->rq_status', this data only update when 'flush_rq'
reference count isn't zero. If flush request once failed and record error code
in 'fq->rq_status'. If there is no chance to update 'fq->rq_status',then do fsync
will always failed.
To address this issue reset 'fq->rq_status' after return error code to upper layer.

Fixes: 8d6996630c03("block: fix null pointer dereference in blk_mq_rq_timed_out()")
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20211129012659.1553733-1-yebin10@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-01-27 10:54:30 +01:00
..
partitions
partitions: msdos: fix one-byte get_unaligned()
2021-07-20 16:05:39 +02:00
badblocks.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
bfq-cgroup.c
bfq: fix blkio cgroup leakage v4
2020-08-18 07:48:08 -07:00
bfq-iosched.c
Revert "block, bfq: honor already-setup queue merges"
2021-10-06 15:55:56 +02:00
bfq-iosched.h
bfq: fix blkio cgroup leakage v4
2020-08-18 07:48:08 -07:00
bfq-wf2q.c
bfq: fix blkio cgroup leakage v4
2020-08-18 07:48:08 -07:00
bio-integrity.c
block: make function __bio_integrity_free() static
2020-07-02 12:38:18 -06:00
bio.c
bio: fix page leak bio_add_hw_page failure
2021-09-15 09:50:47 +02:00
blk-cgroup-rwstat.c
blk-cgroup: Fix the recursive blkg rwstat
2021-03-30 14:31:48 +02:00
blk-cgroup-rwstat.h
blk-cgroup: separate out blkg_rwstat under CONFIG_BLK_CGROUP_RWSTAT
2019-11-07 12:28:13 -07:00
blk-cgroup.c
blk-cgroup: fix UAF by grabbing blkcg lock before destroying blkg pd
2021-09-30 10:11:07 +02:00
blk-core.c
blkcg: Remove extra blkcg_bio_issue_init
2021-11-26 10:39:13 +01:00
blk-crypto-fallback.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
blk-crypto-internal.h
block: make blk_crypto_rq_bio_prep() able to fail
2020-10-05 10:47:43 -06:00
blk-crypto.c
blk-crypto: fix check for too-large dun_bytes
2021-09-15 09:50:30 +02:00
blk-exec.c
block: add a blk_account_io_merge_bio helper
2020-05-27 05:21:23 -06:00
blk-flush.c
block: Fix fsync always failed if once failed
2022-01-27 10:54:30 +01:00
blk-integrity.c
block: flush the integrity workqueue in blk_integrity_unregister
2021-09-30 10:11:06 +02:00
blk-ioc.c
block: remove retry loop in ioc_release_fn()
2020-07-16 10:22:15 -06:00
blk-iocost.c
iocost: Fix divide-by-zero on donation from low hweight cgroup
2021-12-22 09:30:57 +01:00
blk-iolatency.c
blk-iolatency: error out if blk_get_queue() failed in iolatency_set_limit()
2021-08-12 13:22:08 +02:00
blk-lib.c
block: add a bdev_is_partition helper
2020-09-25 08:18:57 -06:00
blk-map.c
block: fix bmd->is_null_mapped initialization
2020-09-23 09:18:39 -06:00
blk-merge.c
block: return ELEVATOR_DISCARD_MERGE if possible
2021-09-15 09:50:28 +02:00
blk-mq-cpumap.c
blk-mq: remove the calling of local_memory_node()
2020-10-20 07:08:17 -06:00
blk-mq-debugfs-zoned.c
block: Cleanup license notice
2019-01-17 21:21:40 -07:00
blk-mq-debugfs.c
block: decode QUEUE_FLAG_HCTX_ACTIVE in debugfs output
2021-10-27 09:56:46 +02:00
blk-mq-debugfs.h
blk-mq: no need to check return value of debugfs_create functions
2019-06-13 03:00:30 -06:00
blk-mq-pci.c
block: Fix blk_mq_*_map_queues() kernel-doc headers
2019-05-31 15:12:34 -06:00
blk-mq-rdma.c
block: Fix blk_mq_*_map_queues() kernel-doc headers
2019-05-31 15:12:34 -06:00
blk-mq-sched.c
treewide: Change list_sort to use const pointers
2021-09-30 10:11:04 +02:00
blk-mq-sched.h
block-5.10-2020-10-12
2020-10-13 12:12:44 -07:00
blk-mq-sysfs.c
blk-mq: move cancel of hctx->run_work to the front of blk_exit_queue
2020-10-09 12:46:28 -06:00
blk-mq-tag.c
blk-mq: avoid to iterate over stale request
2021-09-30 10:11:05 +02:00
blk-mq-tag.h
blk-mq: clear stale request in tags->rq[] before freeing one request pool
2021-07-14 16:55:58 +02:00
blk-mq-virtio.c
blk-mq: Fix typo in comment
2020-03-17 20:55:21 +01:00
blk-mq.c
block: remove inaccurate requeue check
2021-11-18 14:03:58 +01:00
blk-mq.h
blk-mq: grab rq->refcount before calling ->fn in blk_mq_tagset_busy_iter
2021-07-14 16:55:58 +02:00
blk-pm.c
scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()
2022-01-27 10:54:08 +01:00
blk-pm.h
scsi: block: Do not accept any requests while suspended
2021-01-12 20:18:17 +01:00
blk-rq-qos.c
rq-qos: fix missed wake-ups in rq_qos_throttle try two
2021-07-19 09:45:00 +02:00
blk-rq-qos.h
block: fix race between adding/removing rq qos and normal IO
2021-07-14 16:56:00 +02:00
blk-settings.c
blk-settings: align max_sectors on "logical_block_size" boundary
2021-03-04 11:38:22 +01:00
blk-stat.c
blk-stat: make q->stats->lock irqsafe
2020-09-01 16:48:46 -06:00
blk-stat.h
block: deactivate blk_stat timer in wbt_disable_default()
2018-12-12 06:47:51 -07:00
blk-sysfs.c
blk-mq: move cancel of hctx->run_work to the front of blk_exit_queue
2020-10-09 12:46:28 -06:00
blk-throttle.c
blk-throttle: fix UAF by deleteing timer in blk_throtl_exit()
2021-09-26 14:09:01 +02:00
blk-timeout.c
block: blk-timeout: delete duplicated word
2020-07-31 16:29:47 -06:00
blk-wbt.c
blk-wbt: make sure throttle is enabled properly
2021-07-14 16:56:12 +02:00
blk-wbt.h
blk-wbt: introduce a new disable state to prevent false positive by rwb_enabled()
2021-07-14 16:56:12 +02:00
blk-zoned.c
blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN
2021-09-18 13:40:06 +02:00
blk.h
block: bump max plugged deferred size from 16 to 32
2021-11-18 14:03:57 +01:00
bounce.c
block: make bio_crypt_clone() able to fail
2020-10-05 10:47:43 -06:00
bsg-lib.c
block: drop double zeroing
2020-09-23 09:18:13 -06:00
bsg.c
scsi: bsg: Remove support for SCSI_IOCTL_SEND_COMMAND
2021-09-18 13:40:11 +02:00
cmdline-parser.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
elevator.c
block: return ELEVATOR_DISCARD_MERGE if possible
2021-09-15 09:50:28 +02:00
genhd.c
block: Suppress uevent for hidden device when removed
2021-03-30 14:31:52 +02:00
ioctl.c
block: return -EBUSY when there are open partitions in blkdev_reread_part
2021-04-28 13:39:59 +02:00
ioprio.c
block: fix ioprio_get(IOPRIO_WHO_PGRP) vs setuid(2)
2021-12-14 11:32:40 +01:00
Kconfig
blk-wbt: Remove obsolete multiqueue I/O scheduling comment
2020-09-01 16:49:26 -06:00
Kconfig.iosched
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
keyslot-manager.c
block/keyslot-manager: prevent crash when num_slots=1
2020-11-20 11:52:52 -07:00
kyber-iosched.c
kyber: fix out of bounds access when preempted
2021-05-19 10:13:13 +02:00
Makefile
blk-mq: merge blk-softirq.c into blk-mq.c
2020-06-24 09:15:56 -06:00
mq-deadline.c
block: return ELEVATOR_DISCARD_MERGE if possible
2021-09-15 09:50:28 +02:00
opal_proto.h
block: sed-opal: Change the check condition for regular session validity
2020-03-12 08:00:10 -06:00
scsi_ioctl.c
drivers-5.10-2020-10-12
2020-10-13 13:04:41 -07:00
sed-opal.c
block: sed-opal: Change the check condition for regular session validity
2020-03-12 08:00:10 -06:00
t10-pi.c
block: Allow t10-pi to be modular
2020-01-06 20:59:04 -07:00