linux

iv/linux

History

Javed Hasan b2b0f16fa6 scsi: libfc: Avoid invoking response handler twice if ep is already completed

A race condition exists between the response handler getting called because
of exchange_mgr_reset() (which clears out all the active XIDs) and the
response we get via an interrupt.

Sequence of events:

	 rport ba0200: Port timeout, state PLOGI
	 rport ba0200: Port entered PLOGI state from PLOGI state
	 xid 1052: Exchange timer armed : 20000 msecs      xid timer armed here
	 rport ba0200: Received LOGO request while in state PLOGI
	 rport ba0200: Delete port
	 rport ba0200: work event 3
	 rport ba0200: lld callback ev 3
	 bnx2fc: rport_event_hdlr: event = 3, port_id = 0xba0200
	 bnx2fc: ba0200 - rport not created Yet!!
	 /* Here we reset any outstanding exchanges before
	 freeing rport using the exch_mgr_reset() */
	 xid 1052: Exchange timer canceled
	 /* Here we got two responses for one xid */
	 xid 1052: invoking resp(), esb 20000000 state 3
	 xid 1052: invoking resp(), esb 20000000 state 3
	 xid 1052: fc_rport_plogi_resp() : ep->resp_active 2
	 xid 1052: fc_rport_plogi_resp() : ep->resp_active 2

Skip the response if the exchange is already completed.

Link: https://lore.kernel.org/r/20201215194731.2326-1-jhasan@marvell.com
Signed-off-by: Javed Hasan <jhasan@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

2021-01-12 23:07:32 -05:00

fc_disc.c

scsi: libfc: Fix passing zero to 'PTR_ERR' warning

2020-09-15 17:51:39 -04:00

fc_elsct.c

scsi: libfc: Move scsi/fc_encode.h to libfc

2020-10-29 21:49:25 -04:00

fc_encode.h

scsi: libfc: Work around -Warray-bounds warning

2020-10-29 21:49:25 -04:00

fc_exch.c

scsi: libfc: Avoid invoking response handler twice if ep is already completed