Hans Verkuil ac479b51f3 media: cec: check 'transmit_in_progress', not 'transmitting'
Currently wait_event_interruptible_timeout is called in cec_thread_func()
when adap->transmitting is set. But if the adapter is unconfigured
while transmitting, then adap->transmitting is set to NULL. But the
hardware is still actually transmitting the message, and that's
indicated by adap->transmit_in_progress and we should wait until that
is finished or times out before transmitting new messages.

As the original commit says: adap->transmitting is the userspace view,
adap->transmit_in_progress reflects the hardware state.

However, if adap->transmitting is NULL and adap->transmit_in_progress
is true, then wait_event_interruptible is called (no timeout), which
can get stuck indefinitely if the CEC driver is flaky and never marks
the transmit-in-progress as 'done'.

So test against transmit_in_progress when deciding whether to use
the timeout variant or not, instead of testing against adap->transmitting.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 32804fcb612b ("media: cec: keep track of outstanding transmits")
Cc: <stable@vger.kernel.org>      # for v4.19 and up
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2019-12-13 11:22:10 +01:00
..
2019-12-04 10:56:35 -08:00
2019-12-03 13:58:22 -08:00
2019-12-05 11:43:31 -08:00
2019-12-07 14:49:20 -08:00
2019-12-06 10:28:09 -08:00
2019-12-05 11:38:40 -08:00
2019-12-01 18:43:25 -08:00
2019-11-22 11:16:26 +05:30
2019-12-06 14:19:37 -08:00
2019-12-06 10:28:09 -08:00
2019-12-03 14:37:12 -08:00
2019-12-03 13:58:22 -08:00
2019-12-03 13:58:22 -08:00
2019-11-30 14:35:43 -08:00
2019-12-01 18:42:02 -08:00
2019-12-06 08:28:51 -08:00
2019-12-03 13:58:22 -08:00
2019-12-03 14:37:12 -08:00
2019-11-27 11:06:20 -08:00
2019-12-03 14:09:14 -08:00
2019-12-01 18:43:25 -08:00
2019-12-03 13:58:22 -08:00
2019-12-05 11:43:31 -08:00
2019-12-02 11:41:35 -08:00
2019-11-25 19:40:40 -08:00
2019-12-03 13:58:22 -08:00
2019-12-05 11:43:31 -08:00
2019-12-03 14:37:12 -08:00
2019-12-05 11:28:14 -08:00
2019-12-05 11:43:31 -08:00
2019-12-01 18:39:24 -08:00
2019-12-03 13:31:08 -08:00
2019-12-08 12:23:42 -08:00
2019-12-06 14:19:37 -08:00
2019-11-22 19:56:35 +00:00
2019-12-03 13:58:22 -08:00
2019-12-02 13:37:02 -08:00
2019-12-05 13:18:54 -08:00
2019-12-03 14:09:14 -08:00
2019-12-07 14:51:04 -08:00
2019-12-03 13:58:22 -08:00
2019-11-20 02:15:57 -05:00
2019-12-01 18:01:03 -08:00
2019-12-07 14:49:20 -08:00