Lv Yunlong ac69496fe6 drm/i915/gt: Fix a double free in gen8_preallocate_top_level_pdp
Our code analyzer reported a double free bug.

In gen8_preallocate_top_level_pdp, pde and pde->pt.base are allocated
via alloc_pd(vm) with one reference. If pin_pt_dma() failed, pde->pt.base
is freed by i915_gem_object_put() with a reference dropped. Then free_pd
calls free_px() defined in intel_ppgtt.c, which calls i915_gem_object_put()
to put pde->pt.base again.

As pde->pt.base is protected by refcount, so the second put will not free
pde->pt.base actually. But, maybe it is better to remove the first put?

Fixes: 82adf901138cc ("drm/i915/gt: Shrink i915_page_directory's slab bucket")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210426124340.4238-1-lyl2019@mail.ustc.edu.cn
2021-04-27 10:20:46 +01:00
..
2021-02-02 14:26:02 +01:00
2021-01-31 08:05:46 -07:00
2021-02-26 09:41:03 -08:00
2021-02-24 10:25:37 -08:00
2021-03-07 13:24:44 -08:00
2021-02-22 14:44:39 -08:00
2021-02-23 15:05:10 -08:00
2021-03-16 17:08:46 +10:00
2021-03-14 12:54:56 -07:00
2021-02-22 10:05:12 -08:00
2021-02-22 14:27:07 -08:00
2021-02-22 09:52:55 -08:00
2021-02-28 15:48:25 -08:00
2021-03-05 12:26:24 -08:00
2021-03-12 13:25:49 -08:00
2021-03-16 17:08:46 +10:00
2021-03-13 12:38:44 -08:00
2021-02-24 10:25:37 -08:00
2021-02-24 09:35:54 -08:00
2021-02-24 10:25:37 -08:00
2021-03-12 11:34:36 -08:00
2021-01-28 01:31:42 +01:00
2021-02-25 12:23:49 -08:00
2021-03-12 13:25:49 -08:00
2021-03-12 13:37:18 -08:00
2021-02-26 14:16:06 -08:00
2021-02-22 14:34:00 -08:00
2021-02-28 11:51:20 -08:00
2021-02-09 16:10:49 +01:00
2021-03-13 12:34:29 -08:00
2021-03-13 12:32:57 -08:00
2021-02-24 10:43:40 -08:00
2021-02-25 12:21:08 -08:00
2021-02-09 12:15:07 +01:00
2021-03-12 11:34:36 -08:00