Andrea Arcangeli ad33bb04b2 mm: thp: fix SMP race condition between THP page fault and MADV_DONTNEED
pmd_trans_unstable()/pmd_none_or_trans_huge_or_clear_bad() were
introduced to locklessy (but atomically) detect when a pmd is a regular
(stable) pmd or when the pmd is unstable and can infinitely transition
from pmd_none() and pmd_trans_huge() from under us, while only holding
the mmap_sem for reading (for writing not).

While holding the mmap_sem only for reading, MADV_DONTNEED can run from
under us and so before we can assume the pmd to be a regular stable pmd
we need to compare it against pmd_none() and pmd_trans_huge() in an
atomic way, with pmd_trans_unstable().  The old pmd_trans_huge() left a
tiny window for a race.

Useful applications are unlikely to notice the difference as doing
MADV_DONTNEED concurrently with a page fault would lead to undefined
behavior.

[akpm@linux-foundation.org: tidy up comment grammar/layout]
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Reported-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-02-27 10:28:52 -08:00
..
2015-12-06 12:46:31 +01:00
2015-11-05 19:34:48 -08:00
2016-02-11 18:35:48 -08:00
2015-06-24 17:49:45 -07:00
2016-01-14 16:00:49 -08:00
2016-01-15 17:56:32 -08:00
2015-09-11 16:42:39 -07:00
2015-09-08 15:35:28 -07:00
2016-01-21 17:20:51 -08:00
2015-11-05 19:34:48 -08:00
2015-12-06 12:46:31 +01:00
2015-09-10 13:29:01 -07:00
2016-01-22 18:04:28 -05:00
2016-02-05 18:10:40 -08:00