iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Haishuang Yan ade76212f7 ip6_vti: fix a null pointer deference when destroy vti6 tunnel 
[ Upstream commit 9c86336c15db1c48cbaddff56caf2be0a930e991 ]

If load ip6_vti module and create a network namespace when set
fb_tunnels_only_for_init_net to 1, then exit the namespace will
cause following crash:

[ 6601.677036] BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
[ 6601.679057] PGD 8000000425eca067 P4D 8000000425eca067 PUD 424292067 PMD 0
[ 6601.680483] Oops: 0000 [#1] SMP PTI
[ 6601.681223] CPU: 7 PID: 93 Comm: kworker/u16:1 Kdump: loaded Tainted: G            E     4.18.0+ #3
[ 6601.683153] Hardware name: Fedora Project OpenStack Nova, BIOS seabios-1.7.5-11.el7 04/01/2014
[ 6601.684919] Workqueue: netns cleanup_net
[ 6601.685742] RIP: 0010:vti6_exit_batch_net+0x87/0xd0 [ip6_vti]
[ 6601.686932] Code: 7b 08 48 89 e6 e8 b9 ea d3 dd 48 8b 1b 48 85 db 75 ec 48 83 c5 08 48 81 fd 00 01 00 00 75 d5 49 8b 84 24 08 01 00 00 48 89 e6 <48> 8b 78 08 e8 90 ea d3 dd 49 8b 45 28 49 39 c6 4c 8d 68 d8 75 a1
[ 6601.690735] RSP: 0018:ffffa897c2737de0 EFLAGS: 00010246
[ 6601.691846] RAX: 0000000000000000 RBX: 0000000000000000 RCX: dead000000000200
[ 6601.693324] RDX: 0000000000000015 RSI: ffffa897c2737de0 RDI: ffffffff9f2ea9e0
[ 6601.694824] RBP: 0000000000000100 R08: 0000000000000000 R09: 0000000000000000
[ 6601.696314] R10: 0000000000000001 R11: 0000000000000000 R12: ffff8dc323c07e00
[ 6601.697812] R13: ffff8dc324a63100 R14: ffffa897c2737e30 R15: ffffa897c2737e30
[ 6601.699345] FS:  0000000000000000(0000) GS:ffff8dc33fdc0000(0000) knlGS:0000000000000000
[ 6601.701068] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 6601.702282] CR2: 0000000000000008 CR3: 0000000424966002 CR4: 00000000001606e0
[ 6601.703791] Call Trace:
[ 6601.704329]  cleanup_net+0x1b4/0x2c0
[ 6601.705268]  process_one_work+0x16c/0x370
[ 6601.706145]  worker_thread+0x49/0x3e0
[ 6601.706942]  kthread+0xf8/0x130
[ 6601.707626]  ? rescuer_thread+0x340/0x340
[ 6601.708476]  ? kthread_bind+0x10/0x10
[ 6601.709266]  ret_from_fork+0x35/0x40

Reproduce:
modprobe ip6_vti
echo 1 > /proc/sys/net/core/fb_tunnels_only_for_init_net
unshare -n
exit

This because ip6n->tnls_wc[0] point to fallback device in default, but
in non-default namespace, ip6n->tnls_wc[0] will be NULL, so add the NULL
check comparatively.

Fixes: e2948e5af8ee ("ip6_vti: fix creating fallback tunnel device for vti6")
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-09-15 09:46:44 +02:00
..
6lowpan
…
9p
net/9p/trans_fd.c: fix race-condition by flushing workqueue before the kfree()
2018-09-09 10:32:33 +02:00
802
…
8021q
net: fix use-after-free in GRO with ESP
2018-07-02 20:34:04 +09:00
appletalk
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
atm
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
ax25
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
batman-adv
batman-adv: Fix multicast TT issues with bogus ROAM flags
2018-06-23 10:29:33 +02:00
bluetooth
Bluetooth: avoid killing an already killed socket
2018-08-22 07:43:43 +02:00
bpf
bpf: fix panic due to oob in bpf_prog_test_run_skb
2018-07-11 16:10:57 -07:00
bpfilter
bpfilter: include bpfilter_umh in assembly instead of using objcopy
2018-06-28 21:39:16 +09:00
bridge
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-06-16 07:39:34 +09:00
caif
net: caif: Add a missing rcu_read_unlock() in caif_flow_cb
2018-07-21 16:14:39 -07:00
can
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
ceph
The main piece is a set of libceph changes that revamps how OSD
2018-06-15 07:24:58 +09:00
core
net: sock_diag: Fix spectre v1 gadget in __sock_diag_cmd()
2018-08-22 07:43:43 +02:00
dcb
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
dccp
dccp: fix undefined behavior with 'cwnd' shift in ccid2_cwnd_restart()
2018-08-07 15:34:44 -07:00
decnet
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
dns_resolver
KEYS: DNS: fix parsing multiple options
2018-07-16 11:22:14 -07:00
dsa
dsa: slave: eee: Allow ports to use phylink
2018-08-08 19:19:03 -07:00
ethernet
net: core: rework basic flow dissection helper
2018-05-08 00:02:36 -04:00
hsr
…
ieee802154
net: 6lowpan: fix reserved space for single frames
2018-09-09 10:32:27 +02:00
ife
net: sched: ife: check on metadata length
2018-04-22 21:12:00 -04:00
ipv4
erspan: set erspan_ver to 1 by default when adding an erspan dev
2018-09-15 09:46:42 +02:00
ipv6
ip6_vti: fix a null pointer deference when destroy vti6 tunnel
2018-09-15 09:46:44 +02:00
iucv
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
kcm
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
key
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
l2tp
l2tp: use sk_dst_check() to avoid race on sk->sk_dst_cache
2018-08-22 07:43:40 +02:00
l3mdev
…
lapb
…
llc
llc: use refcount_inc_not_zero() for llc_sap_find()
2018-08-07 15:54:00 -07:00
mac80211
nl80211/mac80211: allow non-linear skb in rx_control_port
2018-07-06 14:34:42 +02:00
mac802154
net: mac802154: tx: expand tailroom if necessary
2018-09-09 10:32:27 +02:00
mpls
net: Drop pernet_operations::async
2018-03-27 13:18:09 -04:00
ncsi
net/ncsi: Use netdev_dbg for debug messages
2018-06-20 07:26:58 +09:00
netfilter
netfilter: nf_tables: move dumper state allocation into ->start
2018-07-24 00:36:33 +02:00
netlabel
audit: use inline function to get audit context
2018-05-14 17:24:18 -04:00
netlink
netlink: Don't shift on 64 for ngroups
2018-08-04 17:52:51 -07:00
netrom
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
nfc
net/nfc: Avoid stalls when nfc_alloc_send_skb() returned NULL.
2018-07-18 10:51:45 -07:00
nsh
nsh: set mac len based on inner packet
2018-07-12 16:55:29 -07:00
openvswitch
openvswitch: meter: Fix setting meter id for new entries
2018-07-29 13:20:54 -07:00
packet
packet: refine ring v3 block size test to hold one frame
2018-08-06 13:48:33 -07:00
phonet
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
psample
…
qrtr
net: qrtr: Reset the node and port ID of broadcast messages
2018-07-05 20:20:03 +09:00
rds
RDS: RDMA: Fix the NULL-ptr deref in rds_ib_get_mr
2018-07-26 14:03:07 -07:00
rfkill
rfkill: Create rfkill-none LED trigger
2018-05-23 11:26:45 +02:00
rose
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
rxrpc
rxrpc: Fix the keepalive generator [ver #2]
2018-08-08 19:10:26 -07:00
sched
net/sched: act_pedit: fix dump of extended layered op
2018-09-15 09:46:42 +02:00
sctp
sctp: remove useless start_fail from sctp_ht_iter in proc
2018-09-15 09:46:42 +02:00
smc
net/smc: move sock lock in smc_ioctl()
2018-08-08 19:14:22 -07:00
strparser
strparser: Remove early eaten to fix full tcp receive buffer stall
2018-06-28 21:37:26 +09:00
sunrpc
NFSv4 client live hangs after live data migration recovery
2018-09-09 10:32:38 +02:00
switchdev
…
tipc
tipc: fix the big/little endian issue in tipc_dest
2018-09-15 09:46:42 +02:00
tls
tls: check RCV_SHUTDOWN in tls_wait_data
2018-07-20 14:38:14 -07:00
unix
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
vmw_vsock
vsock: split dwork to avoid reinitializations
2018-08-07 12:39:13 -07:00
wimax
…
wireless
cfg80211: never ignore user regulatory hint
2018-07-24 09:11:31 +02:00
x25
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
xdp
net: xsk: don't return frames via the allocator on error
2018-07-31 02:03:19 +02:00
xfrm
xfrm: free skb if nlsk pointer is NULL
2018-06-25 16:43:36 +02:00
compat.c
net: support compat 64-bit time in {s,g}etsockopt
2018-04-27 19:46:06 -04:00
Kconfig
net: Introduce generic failover module
2018-05-28 22:59:54 -04:00
Makefile
bpfilter: check compiler capability in Kconfig
2018-06-28 13:36:39 +09:00
socket.c
net: sock_diag: Fix spectre v1 gadget in __sock_diag_cmd()
2018-08-22 07:43:43 +02:00
sysctl_net.c
net: Drop pernet_operations::async
2018-03-27 13:18:09 -04:00