linux/drivers/iommu/intel
Lu Baolu 420d42f6f9 iommu/vt-d: Fix lockdep splat in sva bind()/unbind()
Lock(&iommu->lock) without disabling irq causes lockdep warnings.

========================================================
WARNING: possible irq lock inversion dependency detected
5.11.0-rc1+ #828 Not tainted
--------------------------------------------------------
kworker/0:1H/120 just changed the state of lock:
ffffffffad9ea1b8 (device_domain_lock){..-.}-{2:2}, at:
iommu_flush_dev_iotlb.part.0+0x32/0x120
but this lock took another, SOFTIRQ-unsafe lock in the past:
 (&iommu->lock){+.+.}-{2:2}

and interrupts could create inverse lock ordering between them.

other info that might help us debug this:
 Possible interrupt unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&iommu->lock);
                               local_irq_disable();
                               lock(device_domain_lock);
                               lock(&iommu->lock);
  <Interrupt>
    lock(device_domain_lock);

 *** DEADLOCK ***

Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/20201231005323.2178523-5-baolu.lu@linux.intel.com
Signed-off-by: Will Deacon <will@kernel.org>
2021-01-07 13:27:14 +00:00
..
debugfs.c iommu/vt-d: Rename intel-pasid.h to pasid.h 2020-07-24 10:51:21 +02:00
dmar.c iommu/vt-d: Fix misuse of ALIGN in qi_flush_piotlb() 2021-01-07 13:27:14 +00:00
iommu.c Merge branch 'for-next/iommu/fixes' into for-next/iommu/core 2020-12-08 15:21:49 +00:00
irq_remapping.c iommu/intel: Fix memleak in intel_irq_remapping_alloc 2021-01-05 19:12:06 +00:00
Kconfig iommu/vt-d: Convert intel iommu driver to the iommu ops 2020-11-25 12:03:49 +00:00
Makefile iommu/vt-d: Move Kconfig and Makefile bits down into intel directory 2020-07-29 14:14:55 +02:00
pasid.c drm, iommu: Change type of pasid to u32 2020-09-17 19:21:16 +02:00
pasid.h drm, iommu: Change type of pasid to u32 2020-09-17 19:21:16 +02:00
svm.c iommu/vt-d: Fix lockdep splat in sva bind()/unbind() 2021-01-07 13:27:14 +00:00
trace.c