Kefeng Wang
57bd5b59f1
once: Fix panic when module unload
...
[ Upstream commit 1027b96ec9d34f9abab69bc1a4dc5b1ad8ab1349 ]
DO_ONCE
DEFINE_STATIC_KEY_TRUE(___once_key);
__do_once_done
once_disable_jump(once_key);
INIT_WORK(&w->work, once_deferred);
struct once_work *w;
w->key = key;
schedule_work(&w->work); module unload
//*the key is
destroy*
process_one_work
once_deferred
BUG_ON(!static_key_enabled(work->key));
static_key_count((struct static_key *)x) //*access key, crash*
When module uses DO_ONCE mechanism, it could crash due to the above
concurrency problem, we could reproduce it with link[1].
Fix it by add/put module refcount in the once work process.
[1] https://lore.kernel.org/netdev/eaa6c371-465e-57eb-6be9-f4b16b9d7cbf@huawei.com/
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Reported-by: Minmin chen <chenmingmin@huawei.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-09-03 10:08:12 +02:00
..
2019-07-03 16:57:17 +02:00
2019-09-05 14:54:54 +10:00
2019-07-25 11:34:39 -07:00
2020-11-10 12:37:26 +01:00
2019-02-06 11:01:57 +01:00
2021-06-10 13:37:16 +02:00
2020-06-17 16:40:28 +02:00
2019-05-21 10:50:46 +02:00
2020-06-22 09:31:00 +02:00
2021-01-19 18:26:15 +01:00
2019-07-02 08:41:37 +02:00
2019-10-23 14:48:23 +02:00
2019-11-15 18:34:00 -08:00
2019-05-21 10:50:46 +02:00
2020-06-24 17:50:39 +02:00
2019-09-15 19:42:16 +02:00
2018-08-22 10:52:48 -07:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:27:11 +02:00
2019-05-24 17:27:11 +02:00
2019-05-30 11:26:32 -07:00
2019-06-03 12:32:56 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-10-12 09:17:46 +02:00
2019-07-25 15:47:37 +02:00
2019-05-21 10:50:45 +02:00
2019-06-05 17:37:10 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-05-14 09:44:27 +02:00
2019-05-24 17:27:11 +02:00
2018-11-30 07:22:05 +01:00
2019-05-30 11:26:32 -07:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:32 -07:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2019-06-19 17:09:06 +02:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-06-19 17:09:55 +02:00
2019-03-12 10:04:02 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2017-09-26 15:01:20 -06:00
2019-06-19 17:09:06 +02:00
2020-10-29 09:57:52 +01:00
2018-07-27 19:04:33 +08:00
2020-11-10 12:37:27 +01:00
2018-08-22 10:52:48 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-08-19 08:15:54 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2020-02-24 08:36:52 +01:00
2018-06-12 23:33:24 +02:00
2018-07-27 19:16:38 +08:00
2017-11-02 11:10:55 +01:00
2021-07-20 16:10:46 +02:00
2019-05-24 17:37:53 +02:00
2017-11-02 11:10:55 +01:00
2020-08-21 13:05:32 +02:00
2019-07-10 18:43:43 -07:00
2019-11-06 08:47:50 -08:00
2020-08-19 08:16:04 +02:00
2017-11-15 11:56:19 -08:00
2019-06-05 17:36:37 +02:00
2019-04-09 14:19:06 +02:00
2018-04-27 08:51:26 -04:00
2019-09-25 17:51:39 -07:00
2019-06-18 13:47:24 +02:00
2019-06-05 17:36:38 +02:00
2020-04-13 10:48:07 +02:00
2017-11-02 11:10:55 +01:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2021-01-12 20:16:10 +01:00
2019-10-14 15:04:00 -07:00
2017-02-24 17:46:57 -08:00
2017-02-24 17:46:57 -08:00
2019-09-25 17:51:39 -07:00
2019-05-13 11:07:33 +02:00
2020-10-29 09:57:47 +01:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2019-01-22 13:39:59 +01:00
2018-05-09 06:55:44 +02:00
2019-07-16 19:23:22 -07:00
2021-07-14 16:53:01 +02:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2017-11-02 11:10:55 +01:00
2019-11-10 10:38:43 -08:00
2020-10-01 13:17:10 +02:00
2019-09-24 15:54:07 -07:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-08-30 18:47:15 -07:00
2019-06-19 17:09:08 +02:00
2021-05-19 10:08:33 +02:00
2020-09-17 13:47:52 +02:00
2021-07-14 16:53:16 +02:00
2021-07-14 16:53:16 +02:00
2019-05-30 11:26:32 -07:00
2018-04-11 10:28:35 -07:00
2019-06-20 14:07:34 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-02-28 07:55:43 +01:00
2019-06-07 13:15:06 -07:00
2021-03-17 17:03:44 +01:00
2019-05-24 17:37:53 +02:00
2019-05-24 17:39:02 +02:00
2021-05-07 10:51:37 +02:00
2018-10-16 13:45:44 +02:00
2019-05-21 10:50:45 +02:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2021-05-19 10:08:27 +02:00
2018-07-09 14:10:40 +02:00
2017-11-02 11:10:55 +01:00
2019-07-03 16:57:18 +02:00
2017-11-02 11:10:55 +01:00
2019-06-05 19:03:39 -07:00
2019-05-21 10:50:45 +02:00
2019-05-24 17:27:11 +02:00
2021-09-03 10:08:12 +02:00
2019-05-03 10:49:17 -04:00
2017-02-03 16:35:42 -05:00
2019-06-19 17:09:06 +02:00
2018-01-26 11:45:16 -06:00
2018-08-30 12:56:40 +02:00
2019-05-21 10:50:45 +02:00
2019-07-14 16:17:18 -07:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2019-11-03 06:36:50 -05:00
2020-11-18 19:20:20 +01:00
2019-06-05 17:37:16 +02:00
2019-09-25 17:51:39 -07:00
2019-07-16 19:23:22 -07:00
2019-02-04 09:03:31 +01:00
2019-06-19 17:09:55 +02:00
2020-01-12 12:21:44 +01:00
2020-11-05 11:43:22 +01:00
2021-07-19 08:53:16 +02:00
2019-07-11 15:17:41 -07:00
2019-08-08 07:45:01 -06:00
2017-11-02 11:10:55 +01:00
2019-09-24 15:54:09 -07:00
2019-04-25 19:47:24 +02:00
2019-06-03 11:49:37 +02:00
2019-08-19 13:14:53 -03:00
2021-05-22 11:38:30 +02:00
2019-05-30 11:26:32 -07:00
2019-07-16 19:23:22 -07:00
2020-10-01 13:18:23 +02:00
2020-01-29 16:45:29 +01:00
2020-01-29 16:45:29 +01:00
2020-12-11 13:23:32 +01:00
2018-06-27 18:58:49 +03:00
2019-05-21 10:50:45 +02:00
2019-07-01 19:34:46 -07:00
2019-08-20 17:07:29 +02:00
2019-05-21 10:50:45 +02:00
2019-09-04 13:31:28 +02:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2018-10-15 16:31:29 -04:00
2020-06-22 09:31:12 +02:00
2020-08-21 13:05:37 +02:00
2019-05-21 10:50:45 +02:00
2018-10-16 13:45:44 +02:00
2019-10-14 15:04:01 -07:00
2019-05-21 10:50:45 +02:00
2020-06-30 15:37:04 -04:00
2019-07-16 19:23:22 -07:00
2017-02-26 11:03:38 -05:00
2020-05-27 17:46:43 +02:00
2019-06-19 17:09:55 +02:00
2017-01-09 13:58:57 -05:00
2019-05-21 10:50:45 +02:00
2019-06-05 07:36:43 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-16 19:23:22 -07:00
2019-04-08 16:44:21 -06:00
2019-05-14 19:52:51 -07:00
2019-03-07 18:32:00 -08:00
2019-10-16 14:56:21 +02:00
2017-07-21 09:38:30 +02:00
2019-05-14 19:52:49 -07:00
2021-06-10 13:37:14 +02:00
2019-10-03 12:12:23 -04:00
2019-07-24 17:38:01 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-01-09 10:20:07 +01:00
2019-05-06 11:12:09 -07:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2019-10-01 15:45:03 +02:00
2019-05-30 11:26:41 -07:00
2021-07-14 16:53:16 +02:00
2017-11-02 11:10:55 +01:00
2021-06-10 13:37:14 +02:00
2017-08-15 09:02:07 -07:00