ce2fce2513
Several of our i915 header files, have been including i915_reg.h. This means that any change to i915_reg.h will trigger a full rebuild of pretty much every file of the driver, even those that don't have any kind of register access. Let's delete the i915_reg.h include from all headers and add an explicit include from the .c files that truly need the register definitions; those that need a definition of i915_reg_t for a function definition can get it from i915_reg_defs.h instead. We also remove two non-register #define's (VLV_DISPLAY_BASE and GEN12_SFC_DONE_MAX) into i915_reg_defs.h to allow us to drop the i915_reg.h include from a couple of headers. There's probably a lot more header dependency optimization possible, but the changes here roughly cut the number of files compiled after 'touch i915_reg.h' in half --- a good first step. Cc: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Matt Roper <matthew.d.roper@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220127234334.4016964-7-matthew.d.roper@intel.com
75 lines
1.7 KiB
C
75 lines
1.7 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2013-2021 Intel Corporation
|
|
*
|
|
* LPT/WPT IOSF sideband.
|
|
*/
|
|
|
|
#include "i915_drv.h"
|
|
#include "intel_sbi.h"
|
|
#include "i915_reg.h"
|
|
|
|
/* SBI access */
|
|
static int intel_sbi_rw(struct drm_i915_private *i915, u16 reg,
|
|
enum intel_sbi_destination destination,
|
|
u32 *val, bool is_read)
|
|
{
|
|
struct intel_uncore *uncore = &i915->uncore;
|
|
u32 cmd;
|
|
|
|
lockdep_assert_held(&i915->sb_lock);
|
|
|
|
if (intel_wait_for_register_fw(uncore,
|
|
SBI_CTL_STAT, SBI_BUSY, 0,
|
|
100)) {
|
|
drm_err(&i915->drm,
|
|
"timeout waiting for SBI to become ready\n");
|
|
return -EBUSY;
|
|
}
|
|
|
|
intel_uncore_write_fw(uncore, SBI_ADDR, (u32)reg << 16);
|
|
intel_uncore_write_fw(uncore, SBI_DATA, is_read ? 0 : *val);
|
|
|
|
if (destination == SBI_ICLK)
|
|
cmd = SBI_CTL_DEST_ICLK | SBI_CTL_OP_CRRD;
|
|
else
|
|
cmd = SBI_CTL_DEST_MPHY | SBI_CTL_OP_IORD;
|
|
if (!is_read)
|
|
cmd |= BIT(8);
|
|
intel_uncore_write_fw(uncore, SBI_CTL_STAT, cmd | SBI_BUSY);
|
|
|
|
if (__intel_wait_for_register_fw(uncore,
|
|
SBI_CTL_STAT, SBI_BUSY, 0,
|
|
100, 100, &cmd)) {
|
|
drm_err(&i915->drm,
|
|
"timeout waiting for SBI to complete read\n");
|
|
return -ETIMEDOUT;
|
|
}
|
|
|
|
if (cmd & SBI_RESPONSE_FAIL) {
|
|
drm_err(&i915->drm, "error during SBI read of reg %x\n", reg);
|
|
return -ENXIO;
|
|
}
|
|
|
|
if (is_read)
|
|
*val = intel_uncore_read_fw(uncore, SBI_DATA);
|
|
|
|
return 0;
|
|
}
|
|
|
|
u32 intel_sbi_read(struct drm_i915_private *i915, u16 reg,
|
|
enum intel_sbi_destination destination)
|
|
{
|
|
u32 result = 0;
|
|
|
|
intel_sbi_rw(i915, reg, destination, &result, true);
|
|
|
|
return result;
|
|
}
|
|
|
|
void intel_sbi_write(struct drm_i915_private *i915, u16 reg, u32 value,
|
|
enum intel_sbi_destination destination)
|
|
{
|
|
intel_sbi_rw(i915, reg, destination, &value, false);
|
|
}
|