b137065880
The renesas-irqc interrupt controller is cascaded to the GIC. Hence when propagating wake-up settings to its parent interrupt controller, the following lockdep warning is printed: ============================================= [ INFO: possible recursive locking detected ] 4.2.0-ape6evm-10725-g50fcd7643c034198 #280 Not tainted --------------------------------------------- s2ram/1072 is trying to acquire lock: (&irq_desc_lock_class){-.-...}, at: [<c008d3fc>] __irq_get_desc_lock+0x58/0x98 but task is already holding lock: (&irq_desc_lock_class){-.-...}, at: [<c008d3fc>] __irq_get_desc_lock+0x58/0x98 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&irq_desc_lock_class); lock(&irq_desc_lock_class); *** DEADLOCK *** May be due to missing lock nesting notation 6 locks held by s2ram/1072: #0: (sb_writers#7){.+.+.+}, at: [<c012eb14>] __sb_start_write+0xa0/0xa8 #1: (&of->mutex){+.+.+.}, at: [<c019396c>] kernfs_fop_write+0x4c/0x1bc #2: (s_active#24){.+.+.+}, at: [<c0193974>] kernfs_fop_write+0x54/0x1bc #3: (pm_mutex){+.+.+.}, at: [<c008213c>] pm_suspend+0x10c/0x510 #4: (&dev->mutex){......}, at: [<c02af3c4>] __device_suspend+0xdc/0x2cc #5: (&irq_desc_lock_class){-.-...}, at: [<c008d3fc>] __irq_get_desc_lock+0x58/0x98 stack backtrace: CPU: 0 PID: 1072 Comm: s2ram Not tainted 4.2.0-ape6evm-10725-g50fcd7643c034198 #280 Hardware name: Generic R8A73A4 (Flattened Device Tree) [<c0018078>] (unwind_backtrace) from [<c00144f0>] (show_stack+0x10/0x14) [<c00144f0>] (show_stack) from [<c0451f14>] (dump_stack+0x88/0x98) [<c0451f14>] (dump_stack) from [<c007b29c>] (__lock_acquire+0x15cc/0x20e4) [<c007b29c>] (__lock_acquire) from [<c007c6e0>] (lock_acquire+0xac/0x12c) [<c007c6e0>] (lock_acquire) from [<c0457c00>] (_raw_spin_lock_irqsave+0x40/0x54) [<c0457c00>] (_raw_spin_lock_irqsave) from [<c008d3fc>] (__irq_get_desc_lock+0x58/0x98) [<c008d3fc>] (__irq_get_desc_lock) from [<c008ebbc>] (irq_set_irq_wake+0x20/0xf8) [<c008ebbc>] (irq_set_irq_wake) from [<c0260770>] (irqc_irq_set_wake+0x20/0x4c) [<c0260770>] (irqc_irq_set_wake) from [<c008ec28>] (irq_set_irq_wake+0x8c/0xf8) [<c008ec28>] (irq_set_irq_wake) from [<c02cb8c0>] (gpio_keys_suspend+0x74/0xc0) [<c02cb8c0>] (gpio_keys_suspend) from [<c02ae8cc>] (dpm_run_callback+0x54/0x124) Avoid this false positive by using a separate lockdep class for IRQC interrupts. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Grygorii Strashko <grygorii.strashko@ti.com> Cc: Magnus Damm <magnus.damm@gmail.com> Cc: Jason Cooper <jason@lakedaemon.net> Link: http://lkml.kernel.org/r/1441798974-25716-2-git-send-email-geert%2Brenesas@glider.be Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
332 lines
8.4 KiB
C
332 lines
8.4 KiB
C
/*
|
|
* Renesas IRQC Driver
|
|
*
|
|
* Copyright (C) 2013 Magnus Damm
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/init.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/io.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/irqdomain.h>
|
|
#include <linux/err.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/module.h>
|
|
#include <linux/pm_runtime.h>
|
|
|
|
#define IRQC_IRQ_MAX 32 /* maximum 32 interrupts per driver instance */
|
|
|
|
#define IRQC_REQ_STS 0x00 /* Interrupt Request Status Register */
|
|
#define IRQC_EN_STS 0x04 /* Interrupt Enable Status Register */
|
|
#define IRQC_EN_SET 0x08 /* Interrupt Enable Set Register */
|
|
#define IRQC_INT_CPU_BASE(n) (0x000 + ((n) * 0x10))
|
|
/* SYS-CPU vs. RT-CPU */
|
|
#define DETECT_STATUS 0x100 /* IRQn Detect Status Register */
|
|
#define MONITOR 0x104 /* IRQn Signal Level Monitor Register */
|
|
#define HLVL_STS 0x108 /* IRQn High Level Detect Status Register */
|
|
#define LLVL_STS 0x10c /* IRQn Low Level Detect Status Register */
|
|
#define S_R_EDGE_STS 0x110 /* IRQn Sync Rising Edge Detect Status Reg. */
|
|
#define S_F_EDGE_STS 0x114 /* IRQn Sync Falling Edge Detect Status Reg. */
|
|
#define A_R_EDGE_STS 0x118 /* IRQn Async Rising Edge Detect Status Reg. */
|
|
#define A_F_EDGE_STS 0x11c /* IRQn Async Falling Edge Detect Status Reg. */
|
|
#define CHTEN_STS 0x120 /* Chattering Reduction Status Register */
|
|
#define IRQC_CONFIG(n) (0x180 + ((n) * 0x04))
|
|
/* IRQn Configuration Register */
|
|
|
|
struct irqc_irq {
|
|
int hw_irq;
|
|
int requested_irq;
|
|
struct irqc_priv *p;
|
|
};
|
|
|
|
struct irqc_priv {
|
|
void __iomem *iomem;
|
|
void __iomem *cpu_int_base;
|
|
struct irqc_irq irq[IRQC_IRQ_MAX];
|
|
unsigned int number_of_irqs;
|
|
struct platform_device *pdev;
|
|
struct irq_chip irq_chip;
|
|
struct irq_domain *irq_domain;
|
|
struct clk *clk;
|
|
};
|
|
|
|
static void irqc_dbg(struct irqc_irq *i, char *str)
|
|
{
|
|
dev_dbg(&i->p->pdev->dev, "%s (%d:%d)\n",
|
|
str, i->requested_irq, i->hw_irq);
|
|
}
|
|
|
|
static void irqc_irq_enable(struct irq_data *d)
|
|
{
|
|
struct irqc_priv *p = irq_data_get_irq_chip_data(d);
|
|
int hw_irq = irqd_to_hwirq(d);
|
|
|
|
irqc_dbg(&p->irq[hw_irq], "enable");
|
|
iowrite32(BIT(hw_irq), p->cpu_int_base + IRQC_EN_SET);
|
|
}
|
|
|
|
static void irqc_irq_disable(struct irq_data *d)
|
|
{
|
|
struct irqc_priv *p = irq_data_get_irq_chip_data(d);
|
|
int hw_irq = irqd_to_hwirq(d);
|
|
|
|
irqc_dbg(&p->irq[hw_irq], "disable");
|
|
iowrite32(BIT(hw_irq), p->cpu_int_base + IRQC_EN_STS);
|
|
}
|
|
|
|
static unsigned char irqc_sense[IRQ_TYPE_SENSE_MASK + 1] = {
|
|
[IRQ_TYPE_LEVEL_LOW] = 0x01,
|
|
[IRQ_TYPE_LEVEL_HIGH] = 0x02,
|
|
[IRQ_TYPE_EDGE_FALLING] = 0x04, /* Synchronous */
|
|
[IRQ_TYPE_EDGE_RISING] = 0x08, /* Synchronous */
|
|
[IRQ_TYPE_EDGE_BOTH] = 0x0c, /* Synchronous */
|
|
};
|
|
|
|
static int irqc_irq_set_type(struct irq_data *d, unsigned int type)
|
|
{
|
|
struct irqc_priv *p = irq_data_get_irq_chip_data(d);
|
|
int hw_irq = irqd_to_hwirq(d);
|
|
unsigned char value = irqc_sense[type & IRQ_TYPE_SENSE_MASK];
|
|
u32 tmp;
|
|
|
|
irqc_dbg(&p->irq[hw_irq], "sense");
|
|
|
|
if (!value)
|
|
return -EINVAL;
|
|
|
|
tmp = ioread32(p->iomem + IRQC_CONFIG(hw_irq));
|
|
tmp &= ~0x3f;
|
|
tmp |= value;
|
|
iowrite32(tmp, p->iomem + IRQC_CONFIG(hw_irq));
|
|
return 0;
|
|
}
|
|
|
|
static int irqc_irq_set_wake(struct irq_data *d, unsigned int on)
|
|
{
|
|
struct irqc_priv *p = irq_data_get_irq_chip_data(d);
|
|
|
|
if (!p->clk)
|
|
return 0;
|
|
|
|
if (on)
|
|
clk_enable(p->clk);
|
|
else
|
|
clk_disable(p->clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static irqreturn_t irqc_irq_handler(int irq, void *dev_id)
|
|
{
|
|
struct irqc_irq *i = dev_id;
|
|
struct irqc_priv *p = i->p;
|
|
u32 bit = BIT(i->hw_irq);
|
|
|
|
irqc_dbg(i, "demux1");
|
|
|
|
if (ioread32(p->iomem + DETECT_STATUS) & bit) {
|
|
iowrite32(bit, p->iomem + DETECT_STATUS);
|
|
irqc_dbg(i, "demux2");
|
|
generic_handle_irq(irq_find_mapping(p->irq_domain, i->hw_irq));
|
|
return IRQ_HANDLED;
|
|
}
|
|
return IRQ_NONE;
|
|
}
|
|
|
|
/*
|
|
* This lock class tells lockdep that IRQC irqs are in a different
|
|
* category than their parents, so it won't report false recursion.
|
|
*/
|
|
static struct lock_class_key irqc_irq_lock_class;
|
|
|
|
static int irqc_irq_domain_map(struct irq_domain *h, unsigned int virq,
|
|
irq_hw_number_t hw)
|
|
{
|
|
struct irqc_priv *p = h->host_data;
|
|
|
|
irqc_dbg(&p->irq[hw], "map");
|
|
irq_set_chip_data(virq, h->host_data);
|
|
irq_set_lockdep_class(virq, &irqc_irq_lock_class);
|
|
irq_set_chip_and_handler(virq, &p->irq_chip, handle_level_irq);
|
|
return 0;
|
|
}
|
|
|
|
static const struct irq_domain_ops irqc_irq_domain_ops = {
|
|
.map = irqc_irq_domain_map,
|
|
.xlate = irq_domain_xlate_twocell,
|
|
};
|
|
|
|
static int irqc_probe(struct platform_device *pdev)
|
|
{
|
|
struct irqc_priv *p;
|
|
struct resource *io;
|
|
struct resource *irq;
|
|
struct irq_chip *irq_chip;
|
|
const char *name = dev_name(&pdev->dev);
|
|
int ret;
|
|
int k;
|
|
|
|
p = kzalloc(sizeof(*p), GFP_KERNEL);
|
|
if (!p) {
|
|
dev_err(&pdev->dev, "failed to allocate driver data\n");
|
|
ret = -ENOMEM;
|
|
goto err0;
|
|
}
|
|
|
|
p->pdev = pdev;
|
|
platform_set_drvdata(pdev, p);
|
|
|
|
p->clk = devm_clk_get(&pdev->dev, NULL);
|
|
if (IS_ERR(p->clk)) {
|
|
dev_warn(&pdev->dev, "unable to get clock\n");
|
|
p->clk = NULL;
|
|
}
|
|
|
|
pm_runtime_enable(&pdev->dev);
|
|
pm_runtime_get_sync(&pdev->dev);
|
|
|
|
/* get hold of manadatory IOMEM */
|
|
io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
if (!io) {
|
|
dev_err(&pdev->dev, "not enough IOMEM resources\n");
|
|
ret = -EINVAL;
|
|
goto err1;
|
|
}
|
|
|
|
/* allow any number of IRQs between 1 and IRQC_IRQ_MAX */
|
|
for (k = 0; k < IRQC_IRQ_MAX; k++) {
|
|
irq = platform_get_resource(pdev, IORESOURCE_IRQ, k);
|
|
if (!irq)
|
|
break;
|
|
|
|
p->irq[k].p = p;
|
|
p->irq[k].hw_irq = k;
|
|
p->irq[k].requested_irq = irq->start;
|
|
}
|
|
|
|
p->number_of_irqs = k;
|
|
if (p->number_of_irqs < 1) {
|
|
dev_err(&pdev->dev, "not enough IRQ resources\n");
|
|
ret = -EINVAL;
|
|
goto err1;
|
|
}
|
|
|
|
/* ioremap IOMEM and setup read/write callbacks */
|
|
p->iomem = ioremap_nocache(io->start, resource_size(io));
|
|
if (!p->iomem) {
|
|
dev_err(&pdev->dev, "failed to remap IOMEM\n");
|
|
ret = -ENXIO;
|
|
goto err2;
|
|
}
|
|
|
|
p->cpu_int_base = p->iomem + IRQC_INT_CPU_BASE(0); /* SYS-SPI */
|
|
|
|
irq_chip = &p->irq_chip;
|
|
irq_chip->name = name;
|
|
irq_chip->irq_mask = irqc_irq_disable;
|
|
irq_chip->irq_unmask = irqc_irq_enable;
|
|
irq_chip->irq_set_type = irqc_irq_set_type;
|
|
irq_chip->irq_set_wake = irqc_irq_set_wake;
|
|
irq_chip->flags = IRQCHIP_MASK_ON_SUSPEND;
|
|
|
|
p->irq_domain = irq_domain_add_linear(pdev->dev.of_node,
|
|
p->number_of_irqs,
|
|
&irqc_irq_domain_ops, p);
|
|
if (!p->irq_domain) {
|
|
ret = -ENXIO;
|
|
dev_err(&pdev->dev, "cannot initialize irq domain\n");
|
|
goto err2;
|
|
}
|
|
|
|
/* request interrupts one by one */
|
|
for (k = 0; k < p->number_of_irqs; k++) {
|
|
if (request_irq(p->irq[k].requested_irq, irqc_irq_handler,
|
|
0, name, &p->irq[k])) {
|
|
dev_err(&pdev->dev, "failed to request IRQ\n");
|
|
ret = -ENOENT;
|
|
goto err3;
|
|
}
|
|
}
|
|
|
|
dev_info(&pdev->dev, "driving %d irqs\n", p->number_of_irqs);
|
|
|
|
return 0;
|
|
err3:
|
|
while (--k >= 0)
|
|
free_irq(p->irq[k].requested_irq, &p->irq[k]);
|
|
|
|
irq_domain_remove(p->irq_domain);
|
|
err2:
|
|
iounmap(p->iomem);
|
|
err1:
|
|
pm_runtime_put(&pdev->dev);
|
|
pm_runtime_disable(&pdev->dev);
|
|
kfree(p);
|
|
err0:
|
|
return ret;
|
|
}
|
|
|
|
static int irqc_remove(struct platform_device *pdev)
|
|
{
|
|
struct irqc_priv *p = platform_get_drvdata(pdev);
|
|
int k;
|
|
|
|
for (k = 0; k < p->number_of_irqs; k++)
|
|
free_irq(p->irq[k].requested_irq, &p->irq[k]);
|
|
|
|
irq_domain_remove(p->irq_domain);
|
|
iounmap(p->iomem);
|
|
pm_runtime_put(&pdev->dev);
|
|
pm_runtime_disable(&pdev->dev);
|
|
kfree(p);
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id irqc_dt_ids[] = {
|
|
{ .compatible = "renesas,irqc", },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, irqc_dt_ids);
|
|
|
|
static struct platform_driver irqc_device_driver = {
|
|
.probe = irqc_probe,
|
|
.remove = irqc_remove,
|
|
.driver = {
|
|
.name = "renesas_irqc",
|
|
.of_match_table = irqc_dt_ids,
|
|
}
|
|
};
|
|
|
|
static int __init irqc_init(void)
|
|
{
|
|
return platform_driver_register(&irqc_device_driver);
|
|
}
|
|
postcore_initcall(irqc_init);
|
|
|
|
static void __exit irqc_exit(void)
|
|
{
|
|
platform_driver_unregister(&irqc_device_driver);
|
|
}
|
|
module_exit(irqc_exit);
|
|
|
|
MODULE_AUTHOR("Magnus Damm");
|
|
MODULE_DESCRIPTION("Renesas IRQC Driver");
|
|
MODULE_LICENSE("GPL v2");
|