Liwei Song
17e83549e1
i2c: ismt: fix wrong device address when unmap the data buffer
...
Fix the following kernel bug:
kernel BUG at drivers/iommu/intel-iommu.c:3260!
invalid opcode: 0000 [#5 ] PREEMPT SMP
Hardware name: Intel Corp. Harcuvar/Server, BIOS HAVLCRB0.X64.0013.D39.1608311820 08/31/2016
task: ffff880175389950 ti: ffff880176bec000 task.ti: ffff880176bec000
RIP: 0010:[<ffffffff8150a83b>] [<ffffffff8150a83b>] intel_unmap+0x25b/0x260
RSP: 0018:ffff880176bef5e8 EFLAGS: 00010296
RAX: 0000000000000024 RBX: ffff8800773c7c88 RCX: 000000000000ce04
RDX: 0000000080000000 RSI: 0000000000000000 RDI: 0000000000000009
RBP: ffff880176bef638 R08: 0000000000000010 R09: 0000000000000004
R10: ffff880175389c78 R11: 0000000000000a4f R12: ffff8800773c7868
R13: 00000000ffffac88 R14: ffff8800773c7818 R15: 0000000000000001
FS: 00007fef21258700(0000) GS:ffff88017b5c0000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000066d6d8 CR3: 000000007118c000 CR4: 00000000003406e0
Stack:
00000000ffffac88 ffffffff8199867f ffff880176bef5f8 ffff880100000030
ffff880176bef668 ffff8800773c7c88 ffff880178288098 ffff8800772c0010
ffff8800773c7818 0000000000000001 ffff880176bef648 ffffffff8150a86e
Call Trace:
[<ffffffff8199867f>] ? printk+0x46/0x48
[<ffffffff8150a86e>] intel_unmap_page+0xe/0x10
[<ffffffffa039d99b>] ismt_access+0x27b/0x8fa [i2c_ismt]
[<ffffffff81554420>] ? __pm_runtime_suspend+0xa0/0xa0
[<ffffffff815544a0>] ? pm_suspend_timer_fn+0x80/0x80
[<ffffffff81554420>] ? __pm_runtime_suspend+0xa0/0xa0
[<ffffffff815544a0>] ? pm_suspend_timer_fn+0x80/0x80
[<ffffffff8143dfd0>] ? pci_bus_read_dev_vendor_id+0xf0/0xf0
[<ffffffff8172b36c>] i2c_smbus_xfer+0xec/0x4b0
[<ffffffff810aa4d5>] ? vprintk_emit+0x345/0x530
[<ffffffffa038936b>] i2cdev_ioctl_smbus+0x12b/0x240 [i2c_dev]
[<ffffffff810aa829>] ? vprintk_default+0x29/0x40
[<ffffffffa0389b33>] i2cdev_ioctl+0x63/0x1ec [i2c_dev]
[<ffffffff811b04c8>] do_vfs_ioctl+0x328/0x5d0
[<ffffffff8119d8ec>] ? vfs_write+0x11c/0x190
[<ffffffff8109d449>] ? rt_up_read+0x19/0x20
[<ffffffff811b07f1>] SyS_ioctl+0x81/0xa0
[<ffffffff819a351b>] system_call_fastpath+0x16/0x6e
This happen When run "i2cdetect -y 0" detect SMBus iSMT adapter.
After finished I2C block read/write, when unmap the data buffer,
a wrong device address was pass to dma_unmap_single().
To fix this, give dma_unmap_single() the "dev" parameter, just like
what dma_map_single() does, then unmap can find the right devices.
Fixes: 13f35ac14cd0 ("i2c: Adding support for Intel iSMT SMBus 2.0 host controller")
Signed-off-by: Liwei Song <liwei.song@windriver.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
2017-06-15 16:07:03 +02:00
..
2014-01-24 18:21:11 +01:00
2017-04-20 12:02:32 +01:00
2014-11-07 18:35:33 +01:00
2014-05-22 10:09:21 +02:00
2014-11-07 18:35:33 +01:00
2016-08-22 08:19:55 +02:00
2014-03-13 09:44:59 +01:00
2017-02-20 19:23:52 +01:00
2015-10-23 23:31:11 +02:00
2016-11-18 02:05:03 +01:00
2017-02-20 19:19:54 +01:00
2016-11-18 02:05:03 +01:00
2016-10-07 14:12:21 -07:00
2017-02-09 17:06:52 +01:00
2017-03-08 18:00:49 +01:00
2017-01-25 22:07:40 +01:00
2014-10-20 16:20:37 +02:00
2016-08-22 08:19:55 +02:00
2017-01-28 22:16:38 +01:00
2016-08-22 08:19:55 +02:00
2017-04-19 21:00:13 +02:00
2017-03-22 09:53:24 +01:00
2017-03-22 09:53:24 +01:00
2017-03-02 15:46:34 +01:00
2017-05-22 10:35:51 +02:00
2016-11-18 01:48:01 +01:00
2016-08-22 08:19:55 +02:00
2016-11-18 02:05:03 +01:00
2016-08-22 08:19:55 +02:00
2017-02-09 17:06:52 +01:00
2017-04-20 12:02:32 +01:00
2017-02-09 17:06:52 +01:00
2017-04-21 14:02:41 +02:00
2014-10-20 16:20:37 +02:00
2014-10-20 16:20:37 +02:00
2016-08-22 08:19:55 +02:00
2014-11-07 18:35:33 +01:00
2017-02-09 17:39:16 +01:00
2017-03-02 08:42:32 +01:00
2017-04-16 21:51:30 +02:00
2017-02-25 14:21:18 -08:00
2017-02-09 17:06:52 +01:00
2016-04-11 18:54:59 +02:00
2014-11-07 18:35:33 +01:00
2016-08-22 08:19:55 +02:00
2017-06-15 16:07:03 +02:00
2016-10-25 11:48:58 +02:00
2014-10-20 16:20:37 +02:00
2016-08-22 08:19:55 +02:00
2017-03-30 17:31:29 +02:00
2016-11-24 16:21:42 +01:00
2017-03-02 08:42:32 +01:00
2017-03-08 18:03:41 +01:00
2017-05-16 23:19:00 +02:00
2016-08-22 08:19:55 +02:00
2014-11-07 18:35:33 +01:00
2017-02-09 17:06:52 +01:00
2016-08-22 08:19:55 +02:00
2016-08-22 08:19:55 +02:00
2016-12-17 19:27:44 +01:00
2017-02-23 13:03:56 +01:00
2016-08-26 00:41:58 +02:00
2017-01-25 22:17:24 +01:00
2016-06-29 17:33:18 +10:00
2017-04-20 12:02:32 +01:00
2015-08-10 08:37:28 +02:00
2015-08-10 08:37:34 +02:00
2014-11-07 18:35:33 +01:00
2017-04-20 12:02:32 +01:00
2015-04-23 19:35:30 +02:00
2017-04-20 12:02:32 +01:00
2016-08-22 08:19:55 +02:00
2016-08-22 08:19:55 +02:00
2016-04-11 18:54:59 +02:00
2016-08-22 08:19:55 +02:00
2016-11-18 01:44:38 +01:00
2016-12-01 23:34:33 +01:00
2016-11-29 22:43:38 +01:00
2017-06-15 15:51:44 +02:00
2017-03-08 17:54:59 +01:00
2016-10-25 11:11:46 +02:00
2017-02-09 17:06:52 +01:00
2016-08-22 08:19:55 +02:00
2017-04-16 21:48:06 +02:00
2016-08-22 08:19:55 +02:00
2017-02-09 17:06:52 +01:00
2014-11-07 18:35:33 +01:00
2014-12-14 16:10:09 -08:00
2016-08-22 08:19:55 +02:00
2014-11-07 18:35:33 +01:00
2014-11-07 18:35:33 +01:00
2017-04-20 12:02:32 +01:00
2017-02-09 17:06:52 +01:00
2017-01-25 22:16:59 +01:00
2016-08-22 08:19:55 +02:00
2014-10-20 16:20:37 +02:00
2015-11-30 18:37:22 +01:00
2017-04-21 14:04:57 +02:00
2016-09-08 22:36:18 +02:00
2017-04-21 18:05:22 +02:00
2017-05-22 10:33:42 +02:00
2016-11-18 02:16:08 +01:00
2016-11-18 02:13:11 +01:00
2016-07-14 21:21:56 +09:00
2014-11-07 18:35:33 +01:00
2017-04-20 12:02:32 +01:00
2016-11-18 02:05:03 +01:00
2016-08-22 08:19:55 +02:00
2017-05-17 09:21:06 +02:00
2016-08-22 08:19:55 +02:00
2017-03-23 21:44:21 +01:00
2017-02-09 17:06:52 +01:00
2017-03-23 21:44:21 +01:00
2017-02-20 19:12:38 +01:00
2017-04-20 12:02:32 +01:00