Oleg Nesterov b2c56e4f7d mm: shift VM_GROWS* check from mmap_region() to do_mmap_pgoff()
mmap() doesn't allow the non-anonymous mappings with VM_GROWS* bit set.
In particular this means that mmap_region()->vma_merge(file, vm_flags)
must always fail if "vm_flags & VM_GROWS" is set incorrectly.

So it does not make sense to check VM_GROWS* after we already allocated
the new vma, the only caller, do_mmap_pgoff(), which can pass this flag
can do the check itself.

And this looks a bit more correct, mmap_region() already unmapped the
old mapping at this stage. But if mmap() is going to fail, it should
avoid do_munmap() if possible.

Note: we check VM_GROWS at the end to ensure that do_mmap_pgoff() won't
return EINVAL in the case when it currently returns another error code.

Many thanks to Hugh who nacked the buggy v1.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-09-11 15:57:05 -07:00
..
2013-07-03 16:07:39 -07:00
2012-01-03 22:54:56 -05:00
2013-09-04 09:23:46 -04:00
2011-07-26 16:49:47 -07:00
2013-07-09 10:33:22 -07:00
2013-07-10 18:11:34 -07:00
2013-08-18 20:40:33 -07:00
2013-06-28 14:34:33 +02:00
2013-02-23 17:50:18 -08:00
2013-07-10 18:11:34 -07:00
2012-06-20 14:39:36 -07:00
2013-09-11 15:57:03 -07:00
2013-07-10 18:11:34 -07:00
2013-07-10 18:11:34 -07:00