Neil Horman
b30532515f
bonding: Ensure that we unshare skbs prior to calling pskb_may_pull ...
Recently reported oops:
kernel BUG at net/core/skbuff.c:813!
invalid opcode: 0000 [#1 ] SMP
last sysfs file: /sys/devices/virtual/net/bond0/broadcast
CPU 8
Modules linked in: sit tunnel4 cpufreq_ondemand acpi_cpufreq freq_table bonding
ipv6 dm_mirror dm_region_hash dm_log cdc_ether usbnet mii serio_raw i2c_i801
i2c_core iTCO_wdt iTCO_vendor_support shpchp ioatdma i7core_edac edac_core bnx2
ixgbe dca mdio sg ext4 mbcache jbd2 sd_mod crc_t10dif mptsas mptscsih mptbase
scsi_transport_sas dm_mod [last unloaded: microcode]
Modules linked in: sit tunnel4 cpufreq_ondemand acpi_cpufreq freq_table bonding
ipv6 dm_mirror dm_region_hash dm_log cdc_ether usbnet mii serio_raw i2c_i801
i2c_core iTCO_wdt iTCO_vendor_support shpchp ioatdma i7core_edac edac_core bnx2
ixgbe dca mdio sg ext4 mbcache jbd2 sd_mod crc_t10dif mptsas mptscsih mptbase
scsi_transport_sas dm_mod [last unloaded: microcode]
Pid: 0, comm: swapper Not tainted 2.6.32-71.el6.x86_64 #1 BladeCenter HS22
-[7870AC1]-
RIP: 0010:[<ffffffff81405b16>] [<ffffffff81405b16>]
pskb_expand_head+0x36/0x1e0
RSP: 0018:ffff880028303b70 EFLAGS: 00010202
RAX: 0000000000000002 RBX: ffff880c6458ec80 RCX: 0000000000000020
RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff880c6458ec80
RBP: ffff880028303bc0 R08: ffffffff818a6180 R09: ffff880c6458ed64
R10: ffff880c622b36c0 R11: 0000000000000400 R12: 0000000000000000
R13: 0000000000000180 R14: ffff880c622b3000 R15: 0000000000000000
FS: 0000000000000000(0000) GS:ffff880028300000(0000) knlGS:0000000000000000
CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b
CR2: 00000038653452a4 CR3: 0000000001001000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process swapper (pid: 0, threadinfo ffff8806649c2000, task ffff880c64f16ab0)
Stack:
ffff880028303bc0 ffffffff8104fff9 000000000000001c 0000000100000000
<0> ffff880000047d80 ffff880c6458ec80 000000000000001c ffff880c6223da00
<0> ffff880c622b3000 0000000000000000 ffff880028303c10 ffffffff81407f7a
Call Trace:
<IRQ>
[<ffffffff8104fff9>] ? __wake_up_common+0x59/0x90
[<ffffffff81407f7a>] __pskb_pull_tail+0x2aa/0x360
[<ffffffffa0244530>] bond_arp_rcv+0x2c0/0x2e0 [bonding]
[<ffffffff814a0857>] ? packet_rcv+0x377/0x440
[<ffffffff8140f21b>] netif_receive_skb+0x2db/0x670
[<ffffffff8140f788>] napi_skb_finish+0x58/0x70
[<ffffffff8140fc89>] napi_gro_receive+0x39/0x50
[<ffffffffa01286eb>] ixgbe_clean_rx_irq+0x35b/0x900 [ixgbe]
[<ffffffffa01290f6>] ixgbe_clean_rxtx_many+0x136/0x240 [ixgbe]
[<ffffffff8140fe53>] net_rx_action+0x103/0x210
[<ffffffff81073bd7>] __do_softirq+0xb7/0x1e0
[<ffffffff810d8740>] ? handle_IRQ_event+0x60/0x170
[<ffffffff810142cc>] call_softirq+0x1c/0x30
[<ffffffff81015f35>] do_softirq+0x65/0xa0
[<ffffffff810739d5>] irq_exit+0x85/0x90
[<ffffffff814cf915>] do_IRQ+0x75/0xf0
[<ffffffff81013ad3>] ret_from_intr+0x0/0x11
<EOI>
[<ffffffff8101bc01>] ? mwait_idle+0x71/0xd0
[<ffffffff814cd80a>] ? atomic_notifier_call_chain+0x1a/0x20
[<ffffffff81011e96>] cpu_idle+0xb6/0x110
[<ffffffff814c17c8>] start_secondary+0x1fc/0x23f
Resulted from bonding driver registering packet handlers via dev_add_pack and
then trying to call pskb_may_pull. If another packet handler (like for AF_PACKET
sockets) gets called first, the delivered skb will have a user count > 1, which
causes pskb_may_pull to BUG halt when it does its skb_shared check. Fix this by
calling skb_share_check prior to the may_pull call sites in the bonding driver
to clone the skb when needed. Tested by myself and the reported successfully.
Signed-off-by: Neil Horman
CC: Andy Gospodarek <andy@greyhouse.net>
CC: Jay Vosburgh <fubar@us.ibm.com>
CC: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2011-01-20 16:45:56 -08:00
2010-10-24 13:41:39 -07:00
2010-07-18 15:07:15 -07:00
2011-01-13 21:49:55 -08:00
2010-12-26 22:37:05 -08:00
2010-12-16 14:43:15 -08:00
2011-01-04 11:57:25 -08:00
2010-12-21 02:16:10 -08:00
2011-01-12 19:00:39 -08:00
2011-01-18 16:10:40 -08:00
2011-01-20 16:45:56 -08:00
2011-01-03 10:31:58 +00:00
2010-12-22 15:25:40 -08:00
2011-01-07 16:58:04 -08:00
2010-12-06 13:24:47 -08:00
2010-12-21 02:16:10 -08:00
2011-01-20 16:45:55 -08:00
2011-01-11 15:44:40 -08:00
2011-01-14 02:00:46 -08:00
2011-01-14 02:06:23 -08:00
2011-01-11 14:03:09 -08:00
2010-12-17 12:27:22 -08:00
2010-09-06 18:29:17 -07:00
2011-01-09 15:45:48 -08:00
2011-01-07 16:58:04 -08:00
2010-12-24 21:36:51 -08:00
2010-12-24 21:38:47 -08:00
2011-01-18 16:13:51 -08:00
2010-12-16 14:43:15 -08:00
2011-01-13 21:44:34 -08:00
2010-12-24 21:45:42 -08:00
2010-05-10 05:01:31 -07:00
2011-01-10 16:05:31 -08:00
2010-12-16 14:43:15 -08:00
2011-01-03 11:56:18 -08:00
2010-07-18 19:15:25 -07:00
2010-12-08 13:47:38 -08:00
2011-01-11 14:03:08 -08:00
2010-12-17 12:27:22 -08:00
2011-01-10 13:34:55 -08:00
2010-12-21 02:16:10 -08:00
2011-01-13 22:09:17 +00:00
2011-01-04 11:57:25 -08:00
2010-12-21 10:53:19 -08:00
2011-01-13 21:49:56 -08:00
2010-12-21 02:16:10 -08:00
2010-12-21 02:16:10 -08:00
2011-01-18 16:13:50 -08:00
2011-01-15 21:21:14 -08:00
2011-01-13 21:48:26 -08:00
2010-12-26 22:37:05 -08:00
2011-01-07 13:16:28 -08:00
2011-01-18 15:10:31 -05:00
2010-11-18 10:47:42 -08:00
2010-12-21 02:16:08 -08:00
2010-12-21 02:16:08 -08:00
2010-05-10 05:01:31 -07:00
2010-12-21 02:16:08 -08:00
2010-05-14 00:19:28 -07:00
2010-11-09 09:17:56 -08:00
2010-10-19 02:32:09 -07:00
2010-12-21 02:16:08 -08:00
2010-06-03 03:18:23 -07:00
2010-05-14 00:19:28 -07:00
2010-11-17 12:21:14 -08:00
2010-12-12 16:45:14 +01:00
2010-11-09 09:17:56 -08:00
2010-05-18 23:01:55 -07:00
2010-07-11 18:15:08 -07:00
2010-09-02 19:06:22 -07:00
2010-04-01 18:38:33 -07:00
2010-10-21 01:26:52 -07:00
2010-08-21 23:09:36 -07:00
2010-05-14 00:19:28 -07:00
2010-05-18 23:01:55 -07:00
2010-12-21 02:16:08 -08:00
2010-11-09 09:17:56 -08:00
2010-10-24 13:41:39 -07:00
2010-12-11 12:01:48 -08:00
2010-09-09 21:36:39 -07:00
2010-11-17 10:37:52 -08:00
2010-12-01 11:11:31 -08:00
2010-12-12 16:45:14 +01:00
2010-08-24 12:24:07 -07:00
2011-01-13 21:48:25 -08:00
2011-01-10 13:31:14 -08:00
2010-09-26 18:34:29 -07:00
2010-12-31 11:04:02 -08:00
2010-11-28 10:47:19 -08:00
2010-09-26 18:34:29 -07:00
2011-01-14 12:39:59 -08:00
2011-01-06 11:50:30 -08:00
2010-12-23 11:44:34 -08:00
2011-01-03 19:08:07 -08:00
2011-01-06 11:27:22 -08:00
2010-12-23 11:44:34 -08:00
2010-09-02 19:06:22 -07:00
2010-07-19 13:32:57 -07:00
2010-07-14 13:40:36 -07:00
2010-09-24 07:40:31 -07:00
2010-09-24 07:40:31 -07:00
2010-09-24 07:40:31 -07:00
2010-09-24 07:40:29 -07:00
2010-05-10 05:01:31 -07:00
2010-09-26 18:34:29 -07:00
2010-08-25 15:35:43 -07:00
2010-09-26 18:34:29 -07:00
2011-01-03 13:27:38 -08:00
2010-08-25 15:35:43 -07:00
2010-11-17 10:37:52 -08:00
2010-10-16 11:13:20 -07:00
2010-09-29 13:23:30 -07:00
2010-09-26 18:34:29 -07:00
2010-12-21 02:16:08 -08:00
2010-12-21 02:16:08 -08:00
2010-12-21 02:16:08 -08:00
2010-05-10 05:01:31 -07:00
2010-12-25 19:37:49 -08:00
2010-09-16 21:54:59 -07:00
2010-05-14 00:19:28 -07:00
2010-09-26 18:34:29 -07:00
2010-11-28 11:16:38 -08:00
2010-05-14 00:19:28 -07:00
2010-08-25 15:35:43 -07:00
2010-08-06 09:25:50 -06:00
2010-11-16 11:39:08 -08:00
2011-01-09 15:42:56 -08:00
2011-01-09 15:42:56 -08:00
2011-01-09 16:20:29 -08:00
2010-09-26 18:34:29 -07:00
2010-06-03 03:18:23 -07:00
2010-11-12 14:05:43 -08:00
2010-03-30 22:02:32 +09:00
2011-01-18 16:13:51 -08:00
2011-01-13 21:44:34 -08:00
2011-01-14 12:45:55 -08:00
2011-01-14 12:45:54 -08:00
2010-12-25 19:37:49 -08:00
2010-09-26 18:34:29 -07:00
2010-05-14 00:19:28 -07:00
2010-12-21 02:16:08 -08:00
2010-03-30 22:02:32 +09:00
2010-08-30 13:50:45 -07:00
2010-10-24 13:41:39 -07:00
2010-12-10 15:55:24 -08:00
2010-09-06 18:21:56 -07:00
2011-01-03 12:43:10 -08:00
2010-08-25 15:35:43 -07:00
2010-11-18 10:45:24 -08:00
2010-03-30 23:42:26 -07:00
2010-12-12 16:45:14 +01:00
2010-07-12 20:21:44 -07:00
2010-12-21 02:16:08 -08:00
2010-10-21 03:52:11 -07:00
2011-01-11 14:03:08 -08:00
2010-06-02 06:12:19 -07:00
2010-07-27 22:24:37 -07:00
2010-04-11 14:53:53 -07:00
2010-11-08 13:50:06 -08:00
2010-05-05 21:27:44 -07:00
2011-01-03 13:27:37 -08:00
2010-11-09 09:17:56 -08:00
2010-03-30 22:02:32 +09:00
2010-11-17 10:37:52 -08:00
2010-11-09 09:17:56 -08:00
2011-01-03 12:07:39 -08:00
2010-09-01 08:55:23 -06:00
2010-05-26 20:44:30 -07:00
2010-05-14 00:19:28 -07:00
2010-10-05 14:47:55 -07:00
2010-09-26 18:34:29 -07:00
2010-07-05 19:41:18 -07:00
2010-08-25 15:35:43 -07:00
2010-10-25 12:14:11 -07:00
2010-06-02 17:50:38 +10:00
2010-05-10 05:01:31 -07:00
2010-07-12 20:21:44 -07:00
2010-11-22 08:24:29 -08:00
2011-01-13 21:44:34 -08:00
2010-11-24 13:11:18 -05:00
2010-09-26 18:34:29 -07:00
2010-06-21 13:40:25 -07:00
2010-12-12 16:45:14 +01:00
2010-03-30 22:02:32 +09:00
2010-09-26 18:34:29 -07:00
2010-08-06 09:25:50 -06:00
2010-08-25 15:35:43 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-11-17 10:37:52 -08:00
2010-07-05 20:08:05 -07:00
2011-01-06 11:30:23 -08:00
2010-05-10 05:01:31 -07:00
2010-12-21 02:16:08 -08:00
2010-12-21 02:16:08 -08:00
2010-05-14 00:19:28 -07:00
2010-12-16 14:43:15 -08:00
2010-06-28 12:41:33 -07:00
2011-01-18 16:13:49 -08:00
2010-08-17 02:31:15 -07:00
2010-09-02 19:06:22 -07:00
2010-10-24 13:41:39 -07:00
2010-09-26 18:34:29 -07:00
2010-09-15 22:06:05 -07:00
2011-01-10 16:13:33 -08:00
2011-01-10 16:13:33 -08:00
2011-01-10 16:13:33 -08:00
2011-01-10 16:13:33 -08:00
2011-01-10 16:13:33 -08:00
2010-12-12 15:06:16 -08:00
2010-09-21 18:04:47 -07:00
2010-12-12 22:08:17 -08:00
2010-10-24 13:41:39 -07:00
2010-09-26 18:34:29 -07:00
2010-06-03 03:18:23 -07:00
2010-12-12 16:45:14 +01:00
2010-11-17 10:36:51 -08:00
2010-04-13 02:54:17 -07:00
2011-01-06 11:18:07 -08:00
2011-01-13 21:49:57 -08:00
2010-09-26 18:54:33 -07:00
2010-08-25 15:35:43 -07:00
2010-07-15 20:46:22 -07:00
2010-12-12 16:45:14 +01:00
2010-12-11 11:46:36 -08:00
2010-05-10 05:01:31 -07:00
2010-10-27 12:23:20 -07:00
2010-10-24 13:41:39 -07:00
2010-12-06 12:59:04 -08:00
2010-05-14 00:19:28 -07:00
2010-10-26 10:02:13 -07:00
2010-12-12 16:45:14 +01:00
2010-12-12 16:45:14 +01:00
2010-12-12 16:45:14 +01:00
2010-09-26 18:34:29 -07:00
2010-12-31 12:50:18 -08:00
2010-05-15 23:29:31 -07:00
2011-01-09 15:54:15 -08:00
2011-01-09 15:54:15 -08:00
2010-10-24 16:25:39 -07:00
2010-09-26 18:34:29 -07:00
2010-08-27 19:25:59 -07:00
2010-10-07 14:08:54 +01:00
2010-07-26 09:06:04 -04:00
2010-05-10 05:01:31 -07:00
2010-02-15 09:27:02 -08:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-12-21 02:16:08 -08:00
2010-10-27 17:28:58 +01:00
2010-11-05 15:25:48 -07:00
2010-07-18 19:15:25 -07:00
2010-03-30 22:02:32 +09:00
2010-05-10 05:01:31 -07:00
2011-01-03 11:06:35 -08:00
2010-09-02 19:06:22 -07:00
2010-12-31 12:33:17 -08:00
2010-05-14 00:19:28 -07:00
2010-07-05 19:41:11 -07:00
2010-09-26 18:34:29 -07:00
2010-08-25 15:35:43 -07:00
2010-08-06 09:25:50 -06:00
2010-12-26 22:37:05 -08:00
2010-09-26 18:34:29 -07:00
2010-12-16 14:43:15 -08:00
2010-12-16 14:43:15 -08:00
2010-08-06 09:25:50 -06:00
2010-12-10 15:55:24 -08:00
2010-09-26 18:34:29 -07:00
2010-08-06 09:25:50 -06:00
2010-08-19 00:04:34 -07:00
2010-09-26 18:34:29 -07:00
2010-12-17 10:17:12 -08:00
2010-08-19 17:19:05 -07:00
2011-01-04 11:57:25 -08:00
2010-12-06 11:03:48 -08:00
2010-10-24 13:41:39 -07:00
2010-09-26 18:34:29 -07:00
2010-09-26 18:34:29 -07:00
2010-12-16 14:43:14 -08:00
2010-12-20 10:43:02 -08:00
2010-06-03 03:18:23 -07:00
2010-03-30 22:02:32 +09:00
2011-01-12 18:46:11 -08:00
2010-11-28 18:36:57 -08:00
2010-12-16 14:41:35 -08:00
2010-12-08 10:23:36 -08:00
2010-10-21 01:26:52 -07:00
2010-10-16 11:13:23 -07:00
2010-12-16 14:43:14 -08:00
2010-12-21 02:16:08 -08:00
2011-01-09 23:35:34 -08:00
2010-12-06 13:24:47 -08:00
2010-07-12 20:21:45 -07:00
2010-12-25 19:37:49 -08:00
2010-11-09 09:17:56 -08:00
2010-05-18 23:01:55 -07:00
b30532515f