iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv4
History
Eric Dumazet 71ddeac8cd inet_diag: fix kernel-infoleak for UDP sockets 
KMSAN reported a kernel-infoleak [1], that can exploited
by unpriv users.

After analysis it turned out UDP was not initializing
r->idiag_expires. Other users of inet_sk_diag_fill()
might make the same mistake in the future, so fix this
in inet_sk_diag_fill().

[1]
BUG: KMSAN: kernel-infoleak in instrument_copy_to_user include/linux/instrumented.h:121 [inline]
BUG: KMSAN: kernel-infoleak in copyout lib/iov_iter.c:156 [inline]
BUG: KMSAN: kernel-infoleak in _copy_to_iter+0x69d/0x25c0 lib/iov_iter.c:670
 instrument_copy_to_user include/linux/instrumented.h:121 [inline]
 copyout lib/iov_iter.c:156 [inline]
 _copy_to_iter+0x69d/0x25c0 lib/iov_iter.c:670
 copy_to_iter include/linux/uio.h:155 [inline]
 simple_copy_to_iter+0xf3/0x140 net/core/datagram.c:519
 __skb_datagram_iter+0x2cb/0x1280 net/core/datagram.c:425
 skb_copy_datagram_iter+0xdc/0x270 net/core/datagram.c:533
 skb_copy_datagram_msg include/linux/skbuff.h:3657 [inline]
 netlink_recvmsg+0x660/0x1c60 net/netlink/af_netlink.c:1974
 sock_recvmsg_nosec net/socket.c:944 [inline]
 sock_recvmsg net/socket.c:962 [inline]
 sock_read_iter+0x5a9/0x630 net/socket.c:1035
 call_read_iter include/linux/fs.h:2156 [inline]
 new_sync_read fs/read_write.c:400 [inline]
 vfs_read+0x1631/0x1980 fs/read_write.c:481
 ksys_read+0x28c/0x520 fs/read_write.c:619
 __do_sys_read fs/read_write.c:629 [inline]
 __se_sys_read fs/read_write.c:627 [inline]
 __x64_sys_read+0xdb/0x120 fs/read_write.c:627
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82
 entry_SYSCALL_64_after_hwframe+0x44/0xae

Uninit was created at:
 slab_post_alloc_hook mm/slab.h:524 [inline]
 slab_alloc_node mm/slub.c:3251 [inline]
 __kmalloc_node_track_caller+0xe0c/0x1510 mm/slub.c:4974
 kmalloc_reserve net/core/skbuff.c:354 [inline]
 __alloc_skb+0x545/0xf90 net/core/skbuff.c:426
 alloc_skb include/linux/skbuff.h:1126 [inline]
 netlink_dump+0x3d5/0x16a0 net/netlink/af_netlink.c:2245
 __netlink_dump_start+0xd1c/0xee0 net/netlink/af_netlink.c:2370
 netlink_dump_start include/linux/netlink.h:254 [inline]
 inet_diag_handler_cmd+0x2e7/0x400 net/ipv4/inet_diag.c:1343
 sock_diag_rcv_msg+0x24a/0x620
 netlink_rcv_skb+0x447/0x800 net/netlink/af_netlink.c:2491
 sock_diag_rcv+0x63/0x80 net/core/sock_diag.c:276
 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
 netlink_unicast+0x1095/0x1360 net/netlink/af_netlink.c:1345
 netlink_sendmsg+0x16f3/0x1870 net/netlink/af_netlink.c:1916
 sock_sendmsg_nosec net/socket.c:704 [inline]
 sock_sendmsg net/socket.c:724 [inline]
 sock_write_iter+0x594/0x690 net/socket.c:1057
 do_iter_readv_writev+0xa7f/0xc70
 do_iter_write+0x52c/0x1500 fs/read_write.c:851
 vfs_writev fs/read_write.c:924 [inline]
 do_writev+0x63f/0xe30 fs/read_write.c:967
 __do_sys_writev fs/read_write.c:1040 [inline]
 __se_sys_writev fs/read_write.c:1037 [inline]
 __x64_sys_writev+0xe5/0x120 fs/read_write.c:1037
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82
 entry_SYSCALL_64_after_hwframe+0x44/0xae

Bytes 68-71 of 312 are uninitialized
Memory access of size 312 starts at ffff88812ab54000
Data copied to user address 0000000020001440

CPU: 1 PID: 6365 Comm: syz-executor801 Not tainted 5.16.0-rc3-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011

Fixes: 3c4d05c80567 ("inet_diag: Introduce the inet socket dumping routine")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Link: https://lore.kernel.org/r/20211209185058.53917-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2021-12-10 21:14:49 -08:00
..
bpfilter
net: Revert "net: optimize the sockptr_t for unified kernel/user address spaces"
2020-08-10 12:06:44 -07:00
netfilter
Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next
2021-10-18 14:05:25 +01:00
af_inet.c
net: introduce sk_forward_alloc_get()
2021-10-27 18:20:29 -07:00
ah4.c
Networking changes for 5.14.
2021-06-30 15:51:09 -07:00
arp.c
net: arp: introduce arp_evict_nocarrier sysctl parameter
2021-11-01 19:57:14 -07:00
bpf_tcp_ca.c
bpf: Forbid bpf_ktime_get_coarse_ns and bpf_timer_* in tracing progs
2021-11-15 20:35:58 -08:00
cipso_ipv4.c
NET: IPV4: fix error "do not initialise globals to 0"
2021-09-19 12:43:56 +01:00
datagram.c
net/ipv4/datagram.c: remove superfluous header files from datagram.c
2021-09-29 11:39:33 +01:00
devinet.c
net: return correct error code
2021-11-15 14:22:12 +00:00
esp4_offload.c
xfrm: remove description from xfrm_type struct
2021-06-09 09:38:52 +02:00
esp4.c
ipsec: Remove unneeded extra variable in esp4 esp_ssg_unref()
2021-07-20 16:14:23 +02:00
fib_frontend.c
ipv4: convert fib_num_tclassid_users to atomic_t
2021-12-02 11:56:04 +00:00
fib_lookup.h
ipv4: Fix spelling mistakes
2021-06-07 14:08:30 -07:00
fib_notifier.c
net: ipv4: remove superfluous header files from fib_notifier.c
2021-09-28 17:32:56 -07:00
fib_rules.c
ipv4: convert fib_num_tclassid_users to atomic_t
2021-12-02 11:56:04 +00:00
fib_semantics.c
ipv4: convert fib_num_tclassid_users to atomic_t
2021-12-02 11:56:04 +00:00
fib_trie.c
memcg: enable accounting for IP address and routing-related objects
2021-07-20 06:00:38 -07:00
fou.c
fou: remove sparse errors
2021-08-31 12:03:33 +01:00
gre_demux.c
net: Remove the member netns_ok
2021-05-17 15:29:35 -07:00
gre_offload.c
ip_gre: add csum offload support for gre header
2021-01-29 20:39:14 -08:00
icmp.c
icmp: fix icmp_ext_echo_iio parsing in icmp_build_probe
2021-10-14 07:54:47 -07:00
igmp.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2021-08-13 06:41:22 -07:00
inet_connection_sock.c
inet: use #ifdef CONFIG_SOCK_RX_QUEUE_MAPPING consistently
2021-12-03 14:15:07 +00:00
inet_diag.c
inet_diag: fix kernel-infoleak for UDP sockets
2021-12-10 21:14:49 -08:00
inet_fragment.c
inet: frags: batch fqdir destroy works
2020-12-12 15:08:54 -08:00
inet_hashtables.c
tcp: switch orphan_count to bare per-cpu counters
2021-10-15 11:28:34 +01:00
inet_timewait_sock.c
net: Use generic ns_common::count
2020-08-19 14:06:36 +02:00
inetpeer.c
inetpeer: use div64_ul() and clamp_val() calculate inet_peer_threshold
2021-03-01 13:32:12 -08:00
ip_forward.c
…
ip_fragment.c
…
ip_gre.c
ip: use dev_addr_set() in tunnels
2021-10-13 09:41:37 -07:00
ip_input.c
net: use indirect call helpers for dst_input
2021-02-03 14:51:39 -08:00
ip_options.c
net: clean up codestyle for net/ipv4
2020-08-25 06:28:02 -07:00
ip_output.c
net: ipv4: Fix the warning for dereference
2021-08-30 12:47:09 +01:00
ip_sockglue.c
ipv4: guard IP_MINTTL with a static key
2021-10-25 18:02:14 -07:00
ip_tunnel_core.c
net: ip_tunnel: clean up endianness conversions
2021-01-08 19:25:35 -08:00
ip_tunnel.c
ip: use dev_addr_set() in tunnels
2021-10-13 09:41:37 -07:00
ip_vti.c
ip: use dev_addr_set() in tunnels
2021-10-13 09:41:37 -07:00
ipcomp.c
Networking changes for 5.14.
2021-06-30 15:51:09 -07:00
ipconfig.c
net: ipconfig: Release the rtnl_lock while waiting for carrier
2021-10-28 14:36:41 +01:00
ipip.c
ip: use dev_addr_set() in tunnels
2021-10-13 09:41:37 -07:00
ipmr_base.c
…
ipmr.c
ipmr: Fix indentation issue
2021-07-07 20:52:25 -07:00
Kconfig
net: ipv4: remove duplicate "the the" phrase in Kconfig text
2020-08-18 16:02:16 -07:00
Makefile
bpf: Clean up sockmap related Kconfigs
2021-02-26 12:28:03 -08:00
metrics.c
treewide: rename nla_strlcpy to nla_strscpy.
2020-11-16 08:08:54 -08:00
netfilter.c
netfilter: Dissect flow after packet mangling
2021-04-18 22:04:16 +02:00
netlink.c
…
nexthop.c
net: nexthop: fix null pointer dereference when IPv6 is not enabled
2021-11-23 11:39:53 +00:00
ping.c
Revert "Revert "ipv4: fix memory leaks in ip_cmsg_send() callers""
2021-09-14 14:24:31 +01:00
proc.c
tcp: switch orphan_count to bare per-cpu counters
2021-10-15 11:28:34 +01:00
protocol.c
net: Remove the member netns_ok
2021-05-17 15:29:35 -07:00
raw_diag.c
net: Use nlmsg_unicast() instead of netlink_unicast()
2021-07-13 09:28:29 -07:00
raw.c
Revert "Revert "ipv4: fix memory leaks in ip_cmsg_send() callers""
2021-09-14 14:24:31 +01:00
route.c
net/ipv4/route.c: remove superfluous header files from route.c
2021-09-20 13:09:06 +01:00
syncookies.c
net/ipv4/syncookies.c: remove superfluous header files from syncookies.c
2021-09-21 10:48:47 +01:00
sysctl_net_ipv4.c
tcp: remove sk_{tr}x_skb_cache
2021-09-23 12:50:26 +01:00
tcp_bbr.c
bpf: Enable TCP congestion control kfunc from modules
2021-10-05 17:07:41 -07:00
tcp_bic.c
…
tcp_bpf.c
bpf, sockmap: Fix race in ingress receive verdict with redirect to self
2021-11-09 00:58:26 +01:00
tcp_cdg.c
…
tcp_cong.c
net: Only allow init netns to set default tcp cong to a restricted algo
2021-05-04 11:58:28 -07:00
tcp_cubic.c
tcp_cubic: fix spurious Hystart ACK train detections for not-cwnd-limited flows
2021-11-24 17:26:05 -08:00
tcp_dctcp.c
bpf: Enable TCP congestion control kfunc from modules
2021-10-05 17:07:41 -07:00
tcp_dctcp.h
…
tcp_diag.c
…
tcp_fastopen.c
net/ipv4/tcp_fastopen.c: remove superfluous header files from tcp_fastopen.c
2021-09-20 13:09:06 +01:00
tcp_highspeed.c
Replace HTTP links with HTTPS ones: IPv*
2020-07-06 13:23:03 -07:00
tcp_htcp.c
Replace HTTP links with HTTPS ones: IPv*
2020-07-06 13:23:03 -07:00
tcp_hybla.c
…
tcp_illinois.c
…
tcp_input.c
tcp: adjust rcv_ssthresh according to sk_reserved_mem
2021-09-30 13:36:46 +01:00
tcp_ipv4.c
ipv4: guard IP_MINTTL with a static key
2021-10-25 18:02:14 -07:00
tcp_lp.c
ipv4: tcp_lp.c: Couple of typo fixes
2021-03-28 17:31:13 -07:00
tcp_metrics.c
fixes-v5.11
2020-12-14 16:40:27 -08:00
tcp_minisocks.c
tcp: fix another uninit-value (sk_rx_queue_mapping)
2021-12-03 14:15:49 +00:00
tcp_nv.c
net/ipv4/tcp_nv.c: remove superfluous header files from tcp_nv.c
2021-09-27 12:47:39 +01:00
tcp_offload.c
net, gro: Set inner transport header offset in tcp/udp GRO hook
2021-08-02 10:20:56 +01:00
tcp_output.c
tcp: Use BIT() for OPTION_* constants
2021-11-04 11:26:15 +00:00
tcp_rate.c
tcp: tracking packets with CE marks in BW rate sample
2021-09-24 14:16:40 +01:00
tcp_recovery.c
tcp: more accurately check DSACKs to grow RACK reordering window
2021-07-27 20:07:21 +01:00
tcp_scalable.c
net: ipv4: delete repeated words
2020-08-24 17:31:20 -07:00
tcp_timer.c
net: sock: introduce sk_error_report
2021-06-29 11:28:21 -07:00
tcp_ulp.c
…
tcp_vegas.c
tcp: use semicolons rather than commas to separate statements
2020-10-13 17:11:52 -07:00
tcp_vegas.h
…
tcp_veno.c
Replace HTTP links with HTTPS ones: IPv*
2020-07-06 13:23:03 -07:00
tcp_westwood.c
…
tcp_yeah.c
tcp_yeah: check struct yeah size at compile time
2021-06-29 11:54:36 -07:00
tcp.c
tcp: Fix uninitialized access in skb frags array for Rx 0cp.
2021-11-12 20:13:28 -08:00
tunnel4.c
net: Remove the member netns_ok
2021-05-17 15:29:35 -07:00
udp_bpf.c
net: Implement ->sock_is_readable() for UDP and AF_UNIX
2021-10-26 12:29:33 -07:00
udp_diag.c
net: Use nlmsg_unicast() instead of netlink_unicast()
2021-07-13 09:28:29 -07:00
udp_impl.h
net: pass a sockptr_t into ->setsockopt
2020-07-24 15:41:54 -07:00
udp_offload.c
fou: remove sparse errors
2021-08-31 12:03:33 +01:00
udp_tunnel_core.c
net/ipv4/udp_tunnel_core.c: remove superfluous header files from udp_tunnel_core.c
2021-09-21 10:17:20 +01:00
udp_tunnel_nic.c
udp_tunnel: Fix udp_tunnel_nic work-queue type
2021-09-13 12:38:45 +01:00
udp_tunnel_stub.c
udp_tunnel: add central NIC RX port offload infrastructure
2020-07-10 13:54:00 -07:00
udp.c
udp: using datalen to cap max gso segments
2021-12-09 07:48:07 -08:00
udplite.c
net: Remove the member netns_ok
2021-05-17 15:29:35 -07:00
xfrm4_input.c
…
xfrm4_output.c
xfrm: fix unused variable warning if CONFIG_NETFILTER=n
2020-05-11 15:12:27 +02:00
xfrm4_policy.c
…
xfrm4_protocol.c
net: Remove the member netns_ok
2021-05-17 15:29:35 -07:00
xfrm4_state.c
…
xfrm4_tunnel.c
net/ipv4/xfrm4_tunnel.c: remove superfluous header files from xfrm4_tunnel.c
2021-09-23 10:10:00 +02:00