Guenter Roeck
b5319c9629
Revert "sh: Handle calling csum_partial with misaligned data"
...
This reverts commit cadc4e1a2b4d20d0cc0e81f2c6ba0588775e54e5.
Commit cadc4e1a2b4d ("sh: Handle calling csum_partial with misaligned
data") causes bad checksum calculations on unaligned data. Reverting
it fixes the problem.
# Subtest: checksum
# module: checksum_kunit
1..5
# test_csum_fixed_random_inputs: ASSERTION FAILED at lib/checksum_kunit.c:500
Expected ( u64)result == ( u64)expec, but
( u64)result == 53378 (0xd082)
( u64)expec == 33488 (0x82d0)
# test_csum_fixed_random_inputs: pass:0 fail:1 skip:0 total:1
not ok 1 test_csum_fixed_random_inputs
# test_csum_all_carry_inputs: ASSERTION FAILED at lib/checksum_kunit.c:525
Expected ( u64)result == ( u64)expec, but
( u64)result == 65281 (0xff01)
( u64)expec == 65280 (0xff00)
# test_csum_all_carry_inputs: pass:0 fail:1 skip:0 total:1
not ok 2 test_csum_all_carry_inputs
# test_csum_no_carry_inputs: ASSERTION FAILED at lib/checksum_kunit.c:573
Expected ( u64)result == ( u64)expec, but
( u64)result == 65535 (0xffff)
( u64)expec == 65534 (0xfffe)
# test_csum_no_carry_inputs: pass:0 fail:1 skip:0 total:1
not ok 3 test_csum_no_carry_inputs
# test_ip_fast_csum: pass:1 fail:0 skip:0 total:1
ok 4 test_ip_fast_csum
# test_csum_ipv6_magic: pass:1 fail:0 skip:0 total:1
ok 5 test_csum_ipv6_magic
# checksum: pass:2 fail:3 skip:0 total:5
# Totals: pass:2 fail:3 skip:0 total:5
not ok 22 checksum
Fixes: cadc4e1a2b4d ("sh: Handle calling csum_partial with misaligned data")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Link: https://lore.kernel.org/r/20240324231804.841099-1-linux@roeck-us.net
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
2024-05-02 12:02:38 +02:00
..
2024-03-21 14:41:00 -07:00
2024-03-14 17:43:30 -07:00
2024-03-23 09:17:03 -07:00
2024-03-21 17:21:41 -07:00
2024-03-14 17:43:30 -07:00
2024-03-21 14:41:00 -07:00
2024-03-22 10:22:45 -07:00
2024-03-21 12:44:10 -07:00
2024-03-06 19:29:09 +01:00
2024-03-15 13:03:13 -07:00
2024-03-14 17:43:30 -07:00
2024-03-14 15:53:10 -07:00
2024-03-21 14:41:00 -07:00
2024-03-23 09:21:26 -07:00
2024-03-22 10:41:13 -07:00
2024-03-19 11:38:27 -07:00
2024-05-02 12:02:38 +02:00
2024-03-15 12:47:21 -07:00
2024-03-15 12:37:59 -07:00
2024-03-24 13:54:06 -07:00
2024-03-14 17:43:30 -07:00
2024-03-23 08:43:21 -07:00