iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Thomas Pedersen b5a48f04c9 mac80211: mesh: fix RCU warning 
[ Upstream commit 551842446ed695641a00782cd118cbb064a416a1 ]

ifmsh->csa is an RCU-protected pointer. The writer context
in ieee80211_mesh_finish_csa() is already mutually
exclusive with wdev->sdata.mtx, but the RCU checker did
not know this. Use rcu_dereference_protected() to avoid a
warning.

fixes the following warning:

[   12.519089] =============================
[   12.520042] WARNING: suspicious RCU usage
[   12.520652] 5.1.0-rc7-wt+ #16 Tainted: G        W
[   12.521409] -----------------------------
[   12.521972] net/mac80211/mesh.c:1223 suspicious rcu_dereference_check() usage!
[   12.522928] other info that might help us debug this:
[   12.523984] rcu_scheduler_active = 2, debug_locks = 1
[   12.524855] 5 locks held by kworker/u8:2/152:
[   12.525438]  #0: 00000000057be08c ((wq_completion)phy0){+.+.}, at: process_one_work+0x1a2/0x620
[   12.526607]  #1: 0000000059c6b07a ((work_completion)(&sdata->csa_finalize_work)){+.+.}, at: process_one_work+0x1a2/0x620
[   12.528001]  #2: 00000000f184ba7d (&wdev->mtx){+.+.}, at: ieee80211_csa_finalize_work+0x2f/0x90
[   12.529116]  #3: 00000000831a1f54 (&local->mtx){+.+.}, at: ieee80211_csa_finalize_work+0x47/0x90
[   12.530233]  #4: 00000000fd06f988 (&local->chanctx_mtx){+.+.}, at: ieee80211_csa_finalize_work+0x51/0x90

Signed-off-by: Thomas Pedersen <thomas@eero.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-07-21 09:04:19 +02:00
..
6lowpan
6lowpan: iphc: reset mac_header after decompress to fix panic
2018-10-03 17:00:47 -07:00
9p
net/9p: include trans_common.h to fix missing prototype warning.
2019-07-03 13:15:59 +02:00
802
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
8021q
vlan: disable SIOCSHWTSTAMP in container
2019-05-16 19:42:34 +02:00
appletalk
appletalk: Fix use-after-free in atalk_proc_exit
2019-04-20 09:15:07 +02:00
atm
net: atm: Fix potential Spectre v1 vulnerabilities
2019-04-27 09:35:33 +02:00
ax25
ax25: fix inconsistent lock state in ax25_destroy_timer
2019-06-22 08:16:14 +02:00
batman-adv
batman-adv: allow updating DAT entry timeouts on incoming ARP Replies
2019-05-31 06:47:33 -07:00
bluetooth
Bluetooth: Fix faulty expression for minimum encryption key size check
2019-07-10 09:54:31 +02:00
bpf
…
bridge
bridge: Fix error path for kobject_init_and_add()
2019-05-16 19:42:33 +02:00
caif
caif: reduce stack size with KASAN
2019-05-08 07:20:45 +02:00
can
can: purge socket error queue on sock destruct
2019-06-25 11:36:54 +08:00
ceph
libceph: wait for latest osdmap in ceph_monc_blacklist_add()
2019-03-27 14:13:51 +09:00
core
bpf: sockmap, fix use after free from sleep in psock backlog workqueue
2019-07-21 09:04:18 +02:00
dcb
net: dcb: For wild-card lookups, use priority -1, not 0
2018-09-19 22:43:43 +02:00
dccp
dccp: do not use ipv6 header for ipv4 flow
2019-04-03 06:25:08 +02:00
decnet
dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock
2018-02-25 11:07:52 +01:00
dns_resolver
KEYS: DNS: fix parsing multiple options
2018-07-22 14:28:49 +02:00
dsa
net: dsa: Fix error cleanup path in dsa_init_module
2019-05-16 19:42:34 +02:00
ethernet
…
hsr
net/hsr: fix possible crash in add_timer()
2019-03-19 13:13:22 +01:00
ieee802154
ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module
2019-04-27 09:35:40 +02:00
ife
net: sched: ife: check on metadata length
2018-04-29 11:33:13 +02:00
ipv4
bpf: udp: Avoid calling reuseport's bpf_prog from udp_gro
2019-07-03 13:16:02 +02:00
ipv6
bpf: udp: ipv6: Avoid running reuseport's bpf_prog from __udp6_lib_err
2019-07-03 13:16:03 +02:00
ipx
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
iucv
net/iucv: Free memory obtained by kzalloc
2018-03-31 18:10:41 +02:00
kcm
kcm: switch order of device registration to fix a crash
2019-04-17 08:37:45 +02:00
key
af_key: unconditionally clone on broadcast
2019-03-23 14:35:14 +01:00
l2tp
l2tp: fix infoleak in l2tp_ip6_recvmsg()
2019-03-19 13:13:22 +01:00
l3mdev
…
lapb
lapb: fixed leak of control-blocks.
2019-06-22 08:16:14 +02:00
llc
llc: fix skb leak in llc_build_and_send_ui_pkt()
2019-06-09 09:18:10 +02:00
mac80211
mac80211: mesh: fix RCU warning
2019-07-21 09:04:19 +02:00
mac802154
net: mac802154: tx: expand tailroom if necessary
2018-09-09 19:55:52 +02:00
mpls
mpls: Return error for RTA_GATEWAY attribute
2019-03-13 14:03:09 -07:00
ncsi
net/ncsi: Fix length of GVI response packet
2017-10-21 01:56:38 +01:00
netfilter
ipvs: Fix use-after-free in ip_vs_in
2019-06-22 08:16:15 +02:00
netlabel
netlabel: fix out-of-bounds memory accesses
2019-03-13 14:03:08 -07:00
netlink
genetlink: Fix a memory leak on error path
2019-04-03 06:25:08 +02:00
netrom
netrom: switch to sock timer API
2019-02-06 17:31:32 +01:00
nfc
NFC: nci: Add some bounds checking in nci_hci_cmd_received()
2019-05-16 19:42:32 +02:00
nsh
nsh: set mac len based on inner packet
2018-07-22 14:28:49 +02:00
openvswitch
net: openvswitch: do not free vport if register_netdevice() is failed.
2019-06-22 08:16:15 +02:00
packet
net/packet: fix memory leak in packet_set_ring()
2019-07-03 13:16:01 +02:00
phonet
phonet: fix building with clang
2019-03-23 14:35:16 +01:00
psample
MAINTAINERS: Update Yotam's E-mail
2017-11-01 12:19:03 +09:00
qrtr
net: qrtr: Broadcast messages only from control port
2018-08-24 13:09:13 +02:00
rds
net: rds: fix memory leak in rds_ib_flush_mr_pool
2019-06-11 12:21:45 +02:00
rfkill
rfkill: gpio: fix memory leak in probe error path
2018-05-16 10:10:26 +02:00
rose
net/rose: fix unbound loop in rose_loopback_timer()
2019-05-02 09:40:34 +02:00
rxrpc
rxrpc: Fix net namespace cleanup
2019-05-08 07:20:44 +02:00
sched
net_sched: fix two more memory leaks in cls_tcindex
2019-05-16 19:42:30 +02:00
sctp
sctp: change to hold sk after auth shkey is created successfully
2019-07-03 13:16:02 +02:00
smc
net/smc: fix TCP fallback socket release
2019-01-09 17:14:46 +01:00
strparser
strparser: Remove early eaten to fix full tcp receive buffer stall
2018-07-22 14:28:47 +02:00
sunrpc
svcrdma: Ignore source port when computing DRC hash
2019-07-10 09:54:43 +02:00
switchdev
net: switchdev: Remove bridge bypass support from switchdev
2017-08-07 14:48:48 -07:00
tipc
tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb
2019-07-03 13:16:03 +02:00
tls
net/tls: Fixed return value when tls_complete_pending_work() fails
2018-12-05 19:41:11 +01:00
unix
missing barriers in some of unix_sock ->addr and ->path accesses
2019-03-19 13:13:24 +01:00
vmw_vsock
vsock/virtio: Initialize core virtio vsock before registering the driver
2019-05-25 18:25:17 +02:00
wimax
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
wireless
cfg80211: fix memory leak of wiphy device name
2019-06-25 11:36:54 +08:00
x25
net/x25: fix a race in x25_bind()
2019-03-19 13:13:23 +01:00
xfrm
xfrm: policy: Fix out-of-bound array accesses in __xfrm_policy_unlink
2019-05-25 18:25:33 +02:00
compat.c
sock: Make sock->sk_stamp thread-safe
2019-01-09 17:14:46 +01:00
Kconfig
net: Remove CONFIG_NETFILTER_DEBUG and _ASSERT() macros.
2017-09-04 13:25:20 +02:00
Makefile
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
socket.c
net: socket: set sock->sk to NULL after calling proto_ops::release()
2019-03-13 14:03:09 -07:00
sysctl_net.c
…