iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
b5d78b7f81
linux/drivers/staging/vt6656
History
Heba Aamer 48eaa7f596 staging: vt6656: fix Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) 
This patch fixes the following checkpatch.pl warning:
fix Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)

Pahole showed that the 2 structs are aligned to u16

struct vnt_mic_hdr {
        u8                         id;                   /*     0     1 */
        u8                         tx_priority;          /*     1     1 */
        u8                         mic_addr2[6];         /*     2     6 */
        u8                         ccmp_pn[6];           /*     8     6 */
        __be16                     payload_len;          /*    14     2 */
        __be16                     hlen;                 /*    16     2 */
        __le16                     frame_control;        /*    18     2 */
        u8                         addr1[6];             /*    20     6 */
        u8                         addr2[6];             /*    26     6 */
        u8                         addr3[6];             /*    32     6 */
        __le16                     seq_ctrl;             /*    38     2 */
        u8                         addr4[6];             /*    40     6 */
        u16                        packing;              /*    46     2 */

        /* size: 48, cachelines: 1, members: 13 */
        /* last cacheline: 48 bytes */
};

struct ieee80211_hdr {
        __le16                     frame_control;        /*     0     2 */
        __le16                     duration_id;          /*     2     2 */
        u8                         addr1[6];             /*     4     6 */
        u8                         addr2[6];             /*    10     6 */
        u8                         addr3[6];             /*    16     6 */
        __le16                     seq_ctrl;             /*    22     2 */
        u8                         addr4[6];             /*    24     6 */

        /* size: 30, cachelines: 1, members: 7 */
        /* last cacheline: 30 bytes */
};

Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
Reviewed-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 19:59:17 +08:00
..
baseband.c Staging: vt6656: Removing else after break statement to fix warning 2014-09-19 17:01:22 -07:00
baseband.h
card.c Staging: vt6656: Fixed typo in a macro name 2015-01-12 19:46:50 -08:00
card.h
channel.c
channel.h
desc.h
device.h Staging: vt6656: Fixed typo in a macro name 2015-01-12 19:46:50 -08:00
dpc.c staging: vt6656: dpc remove unneeded headers 2014-07-27 11:19:57 -07:00
dpc.h Staging: vt6656: Fixed typo in a variable name 2015-01-12 19:46:50 -08:00
firmware.c staging: vt6656: Merge three lines into one 2014-09-28 23:22:21 -04:00
firmware.h
int.c
int.h
Kconfig
key.c Staging: vt6656: Merges two lines of code and removes unused variable 2014-09-23 13:40:17 -07:00
key.h
mac.c staging: vt6656: remove return from all void functions 2014-07-27 09:03:44 -07:00
mac.h
main_usb.c staging: vt6656: Use ether_addr_copy() on vnt_private members. 2015-01-12 19:38:40 -08:00
Makefile
power.c
power.h staging: vt6656: rf.h cleanup C_PWBT comments 2014-07-27 11:19:57 -07:00
rf.c Staging: vt6656: Merge two lines of code into one 2014-09-23 13:42:54 -07:00
rf.h staging: vt6656: rf.h clean up comments 2014-07-27 09:03:44 -07:00
rxtx.c staging: vt6656: fix Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) 2015-01-25 19:59:17 +08:00
rxtx.h staging: vt6656: struct vnt_tx_short_buf_head change base type of fifo_ctl to __le16 2014-07-22 16:19:36 -07:00
TODO
usbpipe.c staging: vt6656: remove unnecessary braces 2014-08-16 12:23:16 -07:00
usbpipe.h
wcmd.c staging: vt6656: remove return from all void functions 2014-07-27 09:03:44 -07:00
wcmd.h staging: vt6656: wcmd.h remove dead macros 2014-07-27 11:19:57 -07:00