Zhihao Cheng b5fda08ef2 ubifs: Fix memleak when insert_old_idx() failed
Following process will cause a memleak for copied up znode:

dirty_cow_znode
  zn = copy_znode(c, znode);
  err = insert_old_idx(c, zbr->lnum, zbr->offs);
  if (unlikely(err))
     return ERR_PTR(err);   // No one refers to zn.

Fetch a reproducer in [Link].

Function copy_znode() is split into 2 parts: resource allocation
and znode replacement, insert_old_idx() is split in similar way,
so resource cleanup could be done in error handling path without
corrupting metadata(mem & disk).
It's okay that old index inserting is put behind of add_idx_dirt(),
old index is used in layout_leb_in_gaps(), so the two processes do
not depend on each other.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216705
Fixes: 1e51764a3c2a ("UBIFS: add new flash file system")
Cc: stable@vger.kernel.org
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2023-04-23 23:36:38 +02:00
..
2023-02-20 14:10:36 -08:00
2023-04-11 11:43:16 -07:00
2023-04-15 18:26:56 -05:00
2023-02-21 11:07:23 -08:00
2023-02-27 10:04:49 -08:00
2023-02-24 12:58:55 -08:00
2023-03-01 08:42:27 -08:00
2023-02-20 14:10:36 -08:00
2023-02-27 16:18:51 -08:00
2023-02-27 09:53:58 -08:00
2023-03-01 08:47:19 -08:00
2023-02-24 12:58:55 -08:00
2023-04-04 11:20:55 -07:00
2023-04-04 11:20:55 -07:00
2023-02-21 10:45:51 -08:00
2023-02-20 11:53:11 -08:00
2022-12-23 11:55:54 -08:00
2023-02-21 10:45:51 -08:00
2023-03-24 13:16:01 -07:00
2023-02-20 11:53:11 -08:00
2023-01-31 15:01:20 +01:00
2022-08-20 11:34:33 -04:00
2023-04-05 18:06:23 -07:00
2022-10-10 19:45:17 -07:00
2023-02-20 11:53:11 -08:00
2023-02-20 11:53:11 -08:00
2023-02-20 14:10:36 -08:00
2022-10-10 14:21:11 -07:00
2023-02-20 11:53:11 -08:00
2023-02-20 14:10:36 -08:00
2023-01-19 09:24:30 +01:00
2023-02-22 14:21:40 -08:00
2023-01-11 15:47:40 -05:00
2022-12-21 14:45:25 +01:00
2023-02-20 12:14:33 -08:00
2023-02-20 11:53:11 -08:00
2023-02-20 11:53:11 -08:00
2023-02-20 11:53:11 -08:00