iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
b6d75218ff65f4d63c9cf4986f6c55666fb90a1a
linux/net/core
History
suresh kumar 8d5e69d8fb net-sysfs: add check for netdevice being present to speed_show 
[ Upstream commit 4224cfd7fb ]

When bringing down the netdevice or system shutdown, a panic can be
triggered while accessing the sysfs path because the device is already
removed.

    [  755.549084] mlx5_core 0000:12:00.1: Shutdown was called
    [  756.404455] mlx5_core 0000:12:00.0: Shutdown was called
    ...
    [  757.937260] BUG: unable to handle kernel NULL pointer dereference at           (null)
    [  758.031397] IP: [<ffffffff8ee11acb>] dma_pool_alloc+0x1ab/0x280

    crash> bt
    ...
    PID: 12649  TASK: ffff8924108f2100  CPU: 1   COMMAND: "amsd"
    ...
     #9 [ffff89240e1a38b0] page_fault at ffffffff8f38c778
        [exception RIP: dma_pool_alloc+0x1ab]
        RIP: ffffffff8ee11acb  RSP: ffff89240e1a3968  RFLAGS: 00010046
        RAX: 0000000000000246  RBX: ffff89243d874100  RCX: 0000000000001000
        RDX: 0000000000000000  RSI: 0000000000000246  RDI: ffff89243d874090
        RBP: ffff89240e1a39c0   R8: 000000000001f080   R9: ffff8905ffc03c00
        R10: ffffffffc04680d4  R11: ffffffff8edde9fd  R12: 00000000000080d0
        R13: ffff89243d874090  R14: ffff89243d874080  R15: 0000000000000000
        ORIG_RAX: ffffffffffffffff  CS: 0010  SS: 0018
    #10 [ffff89240e1a39c8] mlx5_alloc_cmd_msg at ffffffffc04680f3 [mlx5_core]
    #11 [ffff89240e1a3a18] cmd_exec at ffffffffc046ad62 [mlx5_core]
    #12 [ffff89240e1a3ab8] mlx5_cmd_exec at ffffffffc046b4fb [mlx5_core]
    #13 [ffff89240e1a3ae8] mlx5_core_access_reg at ffffffffc0475434 [mlx5_core]
    #14 [ffff89240e1a3b40] mlx5e_get_fec_caps at ffffffffc04a7348 [mlx5_core]
    #15 [ffff89240e1a3bb0] get_fec_supported_advertised at ffffffffc04992bf [mlx5_core]
    #16 [ffff89240e1a3c08] mlx5e_get_link_ksettings at ffffffffc049ab36 [mlx5_core]
    #17 [ffff89240e1a3ce8] __ethtool_get_link_ksettings at ffffffff8f25db46
    #18 [ffff89240e1a3d48] speed_show at ffffffff8f277208
    #19 [ffff89240e1a3dd8] dev_attr_show at ffffffff8f0b70e3
    #20 [ffff89240e1a3df8] sysfs_kf_seq_show at ffffffff8eedbedf
    #21 [ffff89240e1a3e18] kernfs_seq_show at ffffffff8eeda596
    #22 [ffff89240e1a3e28] seq_read at ffffffff8ee76d10
    #23 [ffff89240e1a3e98] kernfs_fop_read at ffffffff8eedaef5
    #24 [ffff89240e1a3ed8] vfs_read at ffffffff8ee4e3ff
    #25 [ffff89240e1a3f08] sys_read at ffffffff8ee4f27f
    #26 [ffff89240e1a3f50] system_call_fastpath at ffffffff8f395f92

    crash> net_device.state ffff89443b0c0000
      state = 0x5  (__LINK_STATE_START| __LINK_STATE_NOCARRIER)

To prevent this scenario, we also make sure that the netdevice is present.

Signed-off-by: suresh kumar <suresh2514@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-03-16 14:23:41 +01:00
..
bpf_sk_storage.c
net: in_irq() cleanup
2021-08-13 14:09:19 -07:00
datagram.c
udp: fix skb_copy_and_csum_datagram with odd segment sizes
2021-02-04 18:56:56 -08:00
datagram.h
…
dev_addr_lists.c
net: dev_addr_list: handle first address in __hw_addr_add_ex
2021-09-30 13:29:09 +01:00
dev_ioctl.c
net: core: don't call SIOCBRADD/DELIF for non-bridge devices
2021-08-05 11:36:59 +01:00
dev.c
xdp: check prog type before updating BPF link
2022-01-27 11:05:26 +01:00
devlink.c
devlink: Remove misleading internal_flags from health reporter dump
2022-01-27 11:05:39 +01:00
drop_monitor.c
drop_monitor: fix data-race in dropmon_net_event / trace_napi_poll_hit
2022-02-23 12:03:12 +01:00
dst_cache.c
wireguard: device: reset peer src endpoint when netns exits
2021-12-08 09:04:46 +01:00
dst.c
net: Remove redundant if statements
2021-08-05 13:27:50 +01:00
failover.c
…
fib_notifier.c
…
fib_rules.c
ipv6: fix memory leak in fib6_rule_suppress
2021-12-08 09:04:43 +01:00
filter.c
bpf: Do not try bpf_msg_push_data with len 0
2022-03-02 11:47:55 +01:00
flow_dissector.c
net/sched: flow_dissector: Fix matching on zone id for invalid conns
2022-01-27 11:04:02 +01:00
flow_offload.c
net: Fix offloading indirect devices dependency on qdisc order creation
2021-08-19 13:19:30 +01:00
gen_estimator.c
net_sched: gen_estimator: support large ewma log
2021-01-15 18:11:06 -08:00
gen_stats.c
docs: networking: convert gen_stats.txt to ReST
2020-04-28 14:39:46 -07:00
gro_cells.c
gro_cells: reduce number of synchronize_net() calls
2020-11-25 11:28:12 -08:00
hwbm.c
…
link_watch.c
net: linkwatch: fix failure to restore device state across suspend/resume
2021-08-11 14:43:16 -07:00
lwt_bpf.c
lwt_bpf: Replace preempt_disable() with migrate_disable()
2020-12-07 11:53:40 -08:00
lwtunnel.c
lwtunnel: Validate RTA_ENCAP_TYPE attribute length
2022-01-11 15:35:14 +01:00
Makefile
of: net: move of_net under net/
2022-03-08 19:12:41 +01:00
neighbour.c
net, neigh: clear whole pneigh_entry at alloc time
2021-12-14 10:57:19 +01:00
net_namespace.c
netns: add schedule point in ops_exit_list()
2022-01-27 11:05:35 +01:00
net-procfs.c
net-procfs: show net devices bound packet types
2022-02-01 17:27:08 +01:00
net-sysfs.c
net-sysfs: add check for netdevice being present to speed_show
2022-03-16 14:23:41 +01:00
net-sysfs.h
net-sysfs: add netdev_change_owner()
2020-02-26 20:07:25 -08:00
net-traces.c
tcp: add tracepoint for checksum errors
2021-05-14 15:26:03 -07:00
netclassid_cgroup.c
bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode
2021-09-13 16:35:58 -07:00
netevent.c
net: core: Correct function name netevent_unregister_notifier() in the kerneldoc
2021-03-28 17:56:56 -07:00
netpoll.c
Merge tag 'asm-generic-unaligned-5.14' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic
2021-07-02 12:43:40 -07:00
netprio_cgroup.c
bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode
2021-09-13 16:35:58 -07:00
of_net.c
of: net: move of_net under net/
2022-03-08 19:12:41 +01:00
page_pool.c
page_pool: use relaxed atomic for release side accounting
2021-08-24 10:46:31 +01:00
pktgen.c
pktgen: remove unused variable
2021-09-03 11:48:28 +01:00
ptp_classifier.c
bpf: Refactor BPF_PROG_RUN into a function
2021-08-17 00:45:07 +02:00
request_sock.c
…
rtnetlink.c
net_sched: add __rcu annotation to netdev->qdisc
2022-02-23 12:03:12 +01:00
scm.c
memcg: enable accounting for scm_fp_list objects
2021-07-20 06:00:38 -07:00
secure_seq.c
crypto: lib/sha1 - remove unnecessary includes of linux/cryptohash.h
2020-05-08 15:32:17 +10:00
selftests.c
net: selftests: add MTU test
2021-07-22 00:52:04 -07:00
skbuff.c
net: fix up skbs delta_truesize in UDP GRO frag_list
2022-03-08 19:12:44 +01:00
skmsg.c
bpf, sockmap: Do not ignore orig_len parameter
2022-03-08 19:12:44 +01:00
sock_destructor.h
skb_expand_head() adjust skb->truesize incorrectly
2021-10-22 12:35:51 -07:00
sock_diag.c
bpf, net: Rework cookie generator as per-cpu one
2020-09-30 11:50:35 -07:00
sock_map.c
bpf, sockmap: Fix double bpf_prog_put on error case in map_link
2022-01-27 11:03:50 +01:00
sock_reuseport.c
tcp: Add stats for socket migration.
2021-06-23 12:56:08 -07:00
sock.c
net-timestamp: convert sk->sk_tskey to atomic_t
2022-03-02 11:48:01 +01:00
stream.c
net: stream: don't purge sk_error_queue in sk_stream_kill_queues()
2021-11-18 19:16:34 +01:00
sysctl_net_core.c
bpf: Prevent increasing bpf_jit_limit above max
2021-10-22 17:23:53 -07:00
timestamping.c
…
tso.c
net: tso: add UDP segmentation support
2020-06-18 20:46:23 -07:00
utils.c
net: Fix skb->csum update in inet_proto_csum_replace16().
2020-01-24 20:54:30 +01:00
xdp.c
xdp: Move the rxq_info.mem clearing to unreg_mem_model()
2021-06-28 23:07:59 +02:00