linux/net/bluetooth
Daniel Winkler b6f1b79dea Bluetooth: Do not set cur_adv_instance in adv param MGMT request
We set hdev->cur_adv_instance in the adv param MGMT request to allow the
callback to the hci param request to set the tx power to the correct
instance. Now that the callbacks use the advertising handle from the hci
request (as they should), this workaround is no longer necessary.

Furthermore, this change resolves a race condition that is more
prevalent when using the extended advertising MGMT calls - if
hdev->cur_adv_instance is set in the params request, then when the data
request is called, we believe our new instance is already active. This
treats it as an update and immediately schedules the instance with the
controller, which has a potential race with the software rotation adv
update. By not setting hdev->cur_adv_instance too early, the new
instance is queued as it should be, to be used when the rotation comes
around again.

This change is tested on harrison peak to confirm that it resolves the
race condition on registration, and that there is no regression in
single- and multi-advertising automated tests.

Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Signed-off-by: Daniel Winkler <danielwinkler@google.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
2021-04-06 10:43:26 +02:00
..
bnep net: make ->{get,set}sockopt in proto_ops optional 2020-07-19 18:16:41 -07:00
cmtp net: make ->{get,set}sockopt in proto_ops optional 2020-07-19 18:16:41 -07:00
hidp Bluetooth: hidp: use correct wait queue when removing ctrl_wait 2020-11-09 14:02:47 +01:00
rfcomm Merge branch 'for-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next 2020-07-31 15:11:52 -07:00
6lowpan.c Bluetooth: Coding style fix 2021-04-02 11:03:04 +02:00
a2mp.c Bluetooth: drop HCI device reference before return 2021-01-25 16:13:52 +01:00
a2mp.h Bluetooth: Replace zero-length array with flexible-array member 2020-02-28 08:30:02 +01:00
af_bluetooth.c Bluetooth: fix indentation and alignment reported by checkpatch 2021-01-29 16:51:45 +01:00
amp.c Bluetooth: Fix null pointer dereference in amp_read_loc_assoc_final_data 2021-02-02 17:23:14 +01:00
amp.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284 2019-06-05 17:36:37 +02:00
ecdh_helper.c mm, treewide: rename kzfree() to kfree_sensitive() 2020-08-07 11:33:22 -07:00
ecdh_helper.h Bluetooth: fix set_ecdh_privkey() prototype 2021-03-22 18:11:33 +01:00
hci_conn.c Bluetooth: avoid deadlock between hci_dev->lock and socket lock 2021-03-16 15:29:25 +01:00
hci_core.c Bluetooth: Add new HCI_QUIRK_NO_SUSPEND_NOTIFIER quirk 2021-01-29 16:37:00 +01:00
hci_debugfs.c Bluetooth: Coding style fix 2021-04-02 11:03:04 +02:00
hci_debugfs.h
hci_event.c Bluetooth: Use ext adv handle from requests in CCs 2021-04-06 10:43:25 +02:00
hci_request.c Bluetooth: Check inquiry status before sending one 2021-04-02 11:06:17 +02:00
hci_request.h Bluetooth: Resume advertising after LE connection 2020-11-09 13:33:19 +01:00
hci_sock.c Merge branch 'for-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next 2020-07-31 15:11:52 -07:00
hci_sysfs.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2017-11-04 09:26:51 +09:00
Kconfig net: remove redundant 'depends on NET' 2021-01-27 17:04:12 -08:00
l2cap_core.c Bluetooth: use the correct print format for L2CAP debug statements 2021-04-06 10:40:20 +02:00
l2cap_sock.c Bluetooth: check for zapped sk before connecting 2021-03-23 16:03:48 +01:00
leds.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
leds.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
lib.c Bluetooth: Introduce debug feature when dynamic debug is disabled 2020-05-11 12:16:27 +02:00
Makefile Bluetooth: implement read/set default system parameters mgmt 2020-06-12 21:41:07 +02:00
mgmt_config.c Bluetooth: Add toggle to switch off interleave scan 2020-12-07 17:01:00 +02:00
mgmt_config.h Bluetooth: mgmt: Add commands for runtime configuration 2020-06-18 13:11:03 +03:00
mgmt_util.c networking: make skb_push & __skb_push return void pointers 2017-06-16 11:48:40 -04:00
mgmt_util.h
mgmt.c Bluetooth: Do not set cur_adv_instance in adv param MGMT request 2021-04-06 10:43:26 +02:00
msft.c Bluetooth: disable advertisement filters during suspend 2021-01-25 16:07:37 +01:00
msft.h Bluetooth: disable advertisement filters during suspend 2021-01-25 16:07:37 +01:00
sco.c Bluetooth: Remove trailing semicolon in macros 2021-03-24 08:56:24 +01:00
selftest.c Bluetooth: Remove CRYPTO_ALG_INTERNAL flag 2020-07-31 16:42:04 +03:00
selftest.h
smp.c Bluetooth: SMP: Fix variable dereferenced before check 'conn' 2021-04-02 11:09:12 +02:00
smp.h Bluetooth: Move force_bredr_smp debugfs into hci_debugfs_create_bredr 2020-11-09 13:52:55 +01:00