Chris Wilson
b7c6646117
drm/i915/display: Check for an LPSP encoder before dereferencing ...
Avoid a GPF at
<1>[ 20.177320] BUG: kernel NULL pointer dereference, address: 000000000000007c
<1>[ 20.177322] #PF: supervisor read access in kernel mode
<1>[ 20.177323] #PF: error_code(0x0000) - not-present page
<6>[ 20.177324] PGD 0 P4D 0
<4>[ 20.177327] Oops: 0000 [#1 ] PREEMPT SMP PTI
<4>[ 20.177328] CPU: 1 PID: 944 Comm: debugfs_test Not tainted 5.8.0-rc7-CI-CI_DRM_8814+ #1
<4>[ 20.177330] Hardware name: Dell Inc. XPS 13 9360/0823VW, BIOS 2.9.0 07/09/2018
<4>[ 20.177372] RIP: 0010:i915_lpsp_capability_show+0x44/0xc0 [i915]
<4>[ 20.177374] Code: 0f b6 81 ca 0d 00 00 3c 0b 74 77 76 19 3c 0c 75 44 83 7e 7c 01 7e 2f 48 c7 c6 d7 b9 47 a0 e8 43 df 06 e1 31 c0 c3 3c 09 72 2b <8b> 46 7c 85 c0 75 e6 8b 82 e4 00 00 00 89 c2 83 e2 fb 83 fa 0a 74
<4>[ 20.177376] RSP: 0018:ffffc90000cebe38 EFLAGS: 00010246
<4>[ 20.177377] RAX: 0000000000000009 RBX: ffff888267fe6a58 RCX: ffff888252d10000
<4>[ 20.177378] RDX: ffff88824a9a4000 RSI: 0000000000000000 RDI: ffff888267fe6a30
<4>[ 20.177379] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000001
<4>[ 20.177380] R10: 0000000000000001 R11: 0000000000000000 R12: ffffc90000cebf08
<4>[ 20.177381] R13: 00000000ffffffff R14: 0000000000000001 R15: ffff888267fe6a30
<4>[ 20.177383] FS: 00007f6f9c6b5e40(0000) GS:ffff888276480000(0000) knlGS:0000000000000000
<4>[ 20.177384] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4>[ 20.177385] CR2: 000000000000007c CR3: 0000000255f04006 CR4: 00000000003606e0
<4>[ 20.177386] Call Trace:
<4>[ 20.177390] seq_read+0xcb/0x420
which is presumably from having no encoder attached at that time.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2175
Fixes: 8806211fe7b3 ("drm/i915: Add i915_lpsp_capability debugfs")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Animesh Manna <animesh.manna@intel.com>
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200729130912.30093-1-chris@chris-wilson.co.uk
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit a22b1a9bb0d72a58d5b836653f28d97ee8fea1c4)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
2020-08-19 15:23:13 +03:00
2020-08-06 14:56:11 -07:00
2020-08-15 08:18:22 -07:00
2020-07-29 17:05:44 +02:00
2020-08-05 20:13:21 -07:00
2020-08-06 18:09:34 -07:00
2020-08-07 13:13:09 -07:00
2020-08-02 18:26:51 +03:00
2020-08-15 20:36:42 -07:00
2020-07-31 15:11:52 -07:00
2020-08-06 10:54:07 -07:00
2020-08-11 11:58:31 +10:00
2020-08-15 08:18:22 -07:00
2020-08-15 08:09:38 -07:00
2020-08-11 17:29:45 +02:00
2020-08-07 10:33:50 -07:00
2020-08-11 14:34:17 -07:00
2020-08-11 10:59:19 -07:00
2020-07-30 17:22:58 +09:00
2020-08-07 21:14:30 -07:00
2020-08-10 19:07:44 -07:00
2020-08-15 08:25:41 -07:00
2020-08-12 10:57:59 -07:00
2020-07-27 11:49:37 +02:00
2020-08-05 12:56:27 -07:00
2020-08-19 15:23:13 +03:00
2020-07-29 16:58:08 +02:00
2020-08-10 16:33:54 -07:00
2020-08-14 13:31:25 -07:00
2020-08-14 16:00:09 -07:00
2020-08-15 08:18:22 -07:00
2020-08-04 13:49:43 -07:00
2020-08-12 10:58:04 -07:00
2020-08-15 18:50:32 -07:00
2020-08-05 11:43:47 -07:00
2020-08-12 11:24:12 -07:00
2020-08-04 18:11:58 -07:00
2020-07-24 16:36:13 -07:00
2020-08-05 19:24:27 -07:00
2020-08-07 10:33:50 -07:00
2020-08-14 19:56:57 -07:00
2020-08-15 20:36:42 -07:00
2020-08-11 14:13:24 -07:00
2020-08-11 14:13:24 -07:00
2020-08-05 13:23:24 -07:00
2020-08-15 08:09:38 -07:00
2020-08-07 21:14:30 -07:00
2020-08-06 11:55:43 -07:00
2020-07-31 14:38:12 +02:00
2020-08-10 18:20:04 -07:00
2020-08-14 19:56:57 -07:00
2020-08-14 19:56:57 -07:00
2020-08-14 19:56:56 -07:00
2020-08-05 11:12:34 -07:00
2020-07-29 17:12:09 +02:00
2020-08-06 10:54:07 -07:00
2020-08-04 12:44:53 +02:00
2020-08-12 12:41:15 -07:00
2020-08-07 18:48:15 -07:00
2020-08-07 13:35:51 -07:00
2020-08-09 12:52:28 -07:00
2020-08-12 12:13:44 -07:00
2020-08-07 21:27:37 -07:00
2020-08-06 11:55:43 -07:00
2020-08-05 12:06:44 -07:00
2020-08-14 16:00:09 -07:00
2020-08-12 10:58:01 -07:00
2020-07-30 23:27:08 +01:00
2020-08-11 11:17:45 -07:00
2020-07-27 14:24:51 +02:00
2020-08-12 17:17:00 -07:00
2020-08-11 18:16:31 +02:00
2020-08-14 16:01:59 -07:00
2020-08-14 19:56:57 -07:00
2020-08-07 21:14:30 -07:00
2020-08-06 14:27:31 -07:00
2020-08-05 20:13:21 -07:00
2020-08-07 18:48:15 -07:00
2020-08-14 16:01:59 -07:00
2020-08-15 08:09:38 -07:00
2020-08-09 11:06:10 -07:00
2020-08-06 14:56:11 -07:00
2020-08-07 13:00:53 -07:00
2020-08-11 14:34:17 -07:00
2020-08-12 12:09:36 -07:00
2020-08-11 14:34:17 -07:00
2020-08-14 16:00:09 -07:00
2020-08-14 19:56:57 -07:00
2020-08-12 12:13:44 -07:00
2020-08-14 13:34:37 -07:00
b7c6646117