Darrick J. Wong 7b38460dc8 xfs: don't fail when converting shortform attr to long form during ATTR_REPLACE
Kanda Motohiro reported that expanding a tiny xattr into a large xattr
fails on XFS because we remove the tiny xattr from a shortform fork and
then try to re-add it after converting the fork to extents format having
not removed the ATTR_REPLACE flag.  This fails because the attr is no
longer present, causing a fs shutdown.

This is derived from the patch in his bug report, but we really
shouldn't ignore a nonzero retval from the remove call.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199119
Reported-by: kanda.motohiro@gmail.com
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2018-04-17 19:10:15 -07:00
..
2018-04-11 10:28:39 -07:00
2018-03-30 11:34:55 -07:00
2017-11-09 15:50:29 -08:00
2017-10-26 15:38:26 -07:00
2018-03-11 20:27:56 -07:00
2017-04-03 15:18:17 -07:00
2017-11-09 15:50:29 -08:00
2018-04-12 13:28:22 -07:00
2017-10-26 15:38:27 -07:00
2017-12-08 17:51:05 -08:00