ccc89737aa
This driver has some left over "return 1" on failure style code mixed with
"return negative error codes" style code. The caller doesn't care so we
should just convert everything to return negative error codes.
Then there was a problem that there were two variables used to store error
codes which just resulted in confusion. If qedf_alloc_bdq() returned a
negative error code, we accidentally returned success instead of
propagating the error code. So get rid of the "rc" variable and use
"status" every where.
Also remove the "status = 0" initialization so that these sorts of bugs
will be detected by the compiler in the future.
Link: https://lore.kernel.org/r/20210810085023.GA23998@kili
Fixes:
|
||
|---|---|---|
| .. | ||
| drv_fcoe_fw_funcs.c | ||
| drv_fcoe_fw_funcs.h | ||
| drv_scsi_fw_funcs.c | ||
| drv_scsi_fw_funcs.h | ||
| Kconfig | ||
| Makefile | ||
| qedf_attr.c | ||
| qedf_dbg.c | ||
| qedf_dbg.h | ||
| qedf_debugfs.c | ||
| qedf_els.c | ||
| qedf_fip.c | ||
| qedf_hsi.h | ||
| qedf_io.c | ||
| qedf_main.c | ||
| qedf_version.h | ||
| qedf.h | ||