b97ea289cf
Previously, pci_scan_root_bus() created a root PCI bus, enumerated the devices on it, and called pci_bus_add_devices(), which made the devices available for drivers to claim them. Most callers assigned resources to devices after pci_scan_root_bus() returns, which may be after drivers have claimed the devices. This is incorrect; the PCI core should not change device resources while a driver is managing the device. Remove pci_bus_add_devices() from pci_scan_root_bus() and do it after any resource assignment in the callers. Note that ARM's pci_common_init_dev() already called pci_bus_add_devices() after pci_scan_root_bus(), so we only need to remove the first call: pci_common_init_dev pcibios_init_hw pci_scan_root_bus pci_bus_add_devices # first call pci_bus_assign_resources pci_bus_add_devices # second call [bhelgaas: changelog, drop "root_bus" var in alpha common_init_pci(), return failure earlier in mn10300, add "return" in x86 pcibios_scan_root(), return early if xtensa platform_pcibios_fixup() fails] Signed-off-by: Yijing Wang <wangyijing@huawei.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> CC: Richard Henderson <rth@twiddle.net> CC: Ivan Kokshaysky <ink@jurassic.park.msu.ru> CC: Matt Turner <mattst88@gmail.com> CC: David Howells <dhowells@redhat.com> CC: Tony Luck <tony.luck@intel.com> CC: Michal Simek <monstr@monstr.eu> CC: Ralf Baechle <ralf@linux-mips.org> CC: Koichi Yasutake <yasutake.koichi@jp.panasonic.com> CC: Sebastian Ott <sebott@linux.vnet.ibm.com> CC: "David S. Miller" <davem@davemloft.net> CC: Chris Metcalf <cmetcalf@ezchip.com> CC: Chris Zankel <chris@zankel.net> CC: Max Filippov <jcmvbkbc@gmail.com> CC: Thomas Gleixner <tglx@linutronix.de> |
||
---|---|---|
.. | ||
.gitignore | ||
alpha_ksyms.c | ||
asm-offsets.c | ||
audit.c | ||
binfmt_loader.c | ||
console.c | ||
core_apecs.c | ||
core_cia.c | ||
core_irongate.c | ||
core_lca.c | ||
core_marvel.c | ||
core_mcpcia.c | ||
core_polaris.c | ||
core_t2.c | ||
core_titan.c | ||
core_tsunami.c | ||
core_wildfire.c | ||
entry.S | ||
err_common.c | ||
err_ev6.c | ||
err_ev7.c | ||
err_impl.h | ||
err_marvel.c | ||
err_titan.c | ||
es1888.c | ||
gct.c | ||
head.S | ||
io.c | ||
irq_alpha.c | ||
irq_i8259.c | ||
irq_impl.h | ||
irq_pyxis.c | ||
irq_srm.c | ||
irq.c | ||
machvec_impl.h | ||
Makefile | ||
module.c | ||
osf_sys.c | ||
pc873xx.c | ||
pc873xx.h | ||
pci_impl.h | ||
pci_iommu.c | ||
pci-noop.c | ||
pci-sysfs.c | ||
pci.c | ||
perf_event.c | ||
process.c | ||
proto.h | ||
ptrace.c | ||
rtc.c | ||
setup.c | ||
signal.c | ||
smc37c93x.c | ||
smc37c669.c | ||
smp.c | ||
srm_env.c | ||
srmcons.c | ||
sys_alcor.c | ||
sys_cabriolet.c | ||
sys_dp264.c | ||
sys_eb64p.c | ||
sys_eiger.c | ||
sys_jensen.c | ||
sys_marvel.c | ||
sys_miata.c | ||
sys_mikasa.c | ||
sys_nautilus.c | ||
sys_noritake.c | ||
sys_rawhide.c | ||
sys_ruffian.c | ||
sys_rx164.c | ||
sys_sable.c | ||
sys_sio.c | ||
sys_sx164.c | ||
sys_takara.c | ||
sys_titan.c | ||
sys_wildfire.c | ||
systbls.S | ||
time.c | ||
traps.c | ||
vmlinux.lds.S |