iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/scsi
History
Yu Kuai 80b6051085 scsi: sg: Fix checking return value of blk_get_queue() 
Commit fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference") make
a mess how blk_get_queue() is called, blk_get_queue() returns true on
success while the caller expects it returns 0 on success.

Fix this problem and also add a corresponding error message on failure.

Fixes: fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Closes: https://lore.kernel.org/all/87lefv622n.fsf@linux.ibm.com/
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20230705024001.177585-1-yukuai1@huaweicloud.com
Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Tested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2023-07-19 23:12:13 -04:00
..
aacraid
Merge branch '6.5/scsi-staging' into 6.5/scsi-fixes
2023-07-11 12:15:15 -04:00
aic7xxx
scsi: Add HAS_IOPORT dependencies
2023-05-31 19:59:26 -04:00
aic94xx
scsi: Add HAS_IOPORT dependencies
2023-05-31 19:59:26 -04:00
arcmsr
Merge patch series "Constify most SCSI host templates"
2023-03-24 20:13:03 -04:00
arm
scsi: powertec: Declare SCSI host template const
2023-03-24 19:19:21 -04:00
be2iscsi
Merge patch series "Constify most SCSI host templates"
2023-03-24 20:13:03 -04:00
bfa
scsi: bfa: Replace all non-returning strlcpy() with strscpy()
2023-05-16 21:38:36 -04:00
bnx2fc
scsi: bnx2fc: Avoid using get_cpu() in bnx2fc_cmd_alloc()
2022-05-16 21:26:50 -04:00
bnx2i
scsi: bnx2i: Replace all non-returning strlcpy with strscpy
2023-05-26 13:52:19 -07:00
csiostor
scsi: csiostor: Remove unnecessary aer.h include
2023-03-09 22:00:38 -05:00
cxgbi
Networking changes for 6.4.
2023-04-26 16:07:23 -07:00
cxlflash
Driver core changes for 6.4-rc1
2023-04-27 11:53:57 -07:00
device_handler
scsi: scsi_dh_alua: Fix memleak for 'qdata' in alua_activate()
2023-03-16 23:02:23 -04:00
elx
Merge patch series "Constify most SCSI host templates"
2023-03-24 20:13:03 -04:00
esas2r
modules-6.4-rc1
2023-04-27 16:36:55 -07:00
fcoe
scsi: libfcoe: Replace all non-returning strlcpy() with strscpy()
2023-05-31 18:00:06 -04:00
fnic
scsi: fnic: Use vmalloc_array() and vcalloc()
2023-07-05 21:34:30 -04:00
hisi_sas
scsi: hisi_sas: Convert to platform remove callback returning void
2023-06-07 21:20:21 -04:00
ibmvscsi
scsi: ibmvscsi: Replace all non-returning strlcpy with strscpy
2023-05-26 13:52:18 -07:00
ibmvscsi_tgt
scsi: ibmvscsit: Remove default fabric ops callouts
2023-03-16 23:36:36 -04:00
isci
scsi: isci: Fix comment typo
2023-06-28 21:45:27 -04:00
libfc
scsi: libfc: Include the correct header
2022-12-01 03:03:36 +00:00
libsas
SCSI misc on 20230629
2023-06-30 11:57:07 -07:00
lpfc
Merge branch '6.5/scsi-staging' into 6.5/scsi-fixes
2023-07-11 12:15:15 -04:00
megaraid
SCSI misc on 20230629
2023-06-30 11:57:07 -07:00
mpi3mr
scsi: mpi3mr: Propagate sense data for admin queue SCSI I/O
2023-05-31 20:29:59 -04:00
mpt3sas
scsi: mpt3sas: Fix an issue when driver is being removed
2023-04-11 21:00:37 -04:00
mvsas
scsi: Add HAS_IOPORT dependencies
2023-05-31 19:59:26 -04:00
pcmcia
scsi: Add HAS_IOPORT dependencies
2023-05-31 19:59:26 -04:00
pm8001
scsi: pm80xx: Add fatal error checks
2023-05-31 20:06:53 -04:00
qedf
scsi: qedf: Fix NULL dereference in error handling
2023-05-08 07:19:20 -04:00
qedi
scsi: qedi: Replace all non-returning strlcpy with strscpy
2023-05-26 13:52:19 -07:00
qla2xxx
Merge branch '6.5/scsi-staging' into 6.5/scsi-fixes
2023-07-11 12:15:15 -04:00
qla4xxx
scsi: qla4xxx: Replace all non-returning strlcpy() with strscpy()
2023-05-16 21:40:41 -04:00
smartpqi
SCSI misc on 20230708
2023-07-08 12:35:18 -07:00
snic
scsi: core: Replace scsi_target_block() with scsi_block_targets()
2023-06-16 12:19:59 -04:00
sym53c8xx_2
scsi: sym53c8xx: Replace all non-returning strlcpy() with strscpy()
2023-05-31 18:04:30 -04:00
.gitignore
…
3w-9xxx.c
scsi: 3w-9xxx: Replace all non-returning strlcpy with strscpy
2023-05-26 13:52:19 -07:00
3w-9xxx.h
…
3w-sas.c
scsi: 3w-sas: Declare SCSI host template const
2023-03-24 19:19:20 -04:00
3w-sas.h
scsi: 3w-sas: Replace 1-element arrays with flexible array members
2023-01-12 00:09:52 -05:00
3w-xxxx.c
scsi: 3w-xxxx: Add error handling for initialization failure in tw_probe()
2023-05-22 17:31:56 -04:00
3w-xxxx.h
scsi: 3w-xxxx: Replace one-element array with flexible-array member
2022-09-25 13:06:00 -04:00
53c700_d.h_shipped
…
53c700.c
scsi: 53c700: Stop clearing SCSI pointer fields
2022-02-22 21:11:03 -05:00
53c700.h
…
53c700.scr
…
a100u2w.c
scsi: a100u2w: Declare SCSI host template const
2023-03-24 19:19:20 -04:00
a100u2w.h
…
a2091.c
scsi: a2091: Declare SCSI host template const
2023-03-24 19:19:20 -04:00
a2091.h
…
a3000.c
scsi: a3000: Declare SCSI host template const
2023-03-24 19:19:20 -04:00
a3000.h
…
a4000t.c
…
advansys.c
scsi: advansys: Declare SCSI host template const
2023-03-24 19:19:20 -04:00
aha152x.c
scsi: aha152x: Declare SCSI host template const
2023-03-24 19:19:20 -04:00
aha152x.h
…
aha1542.c
scsi: aha1542: Declare SCSI host template const
2023-03-24 19:19:21 -04:00
aha1542.h
…
aha1740.c
scsi: aha1740: Declare SCSI host template const
2023-03-24 19:19:21 -04:00
aha1740.h
…
am53c974.c
scsi: esp_scsi: Declare SCSI host template const
2023-03-24 19:19:22 -04:00
atari_scsi.c
scsi: NCR5380: Add SCp members to struct NCR5380_cmd
2022-02-22 21:11:03 -05:00
atp870u.c
scsi: atp870u: Declare SCSI host template const
2023-03-24 19:19:21 -04:00
atp870u.h
…
BusLogic.c
scsi: BusLogic: Declare SCSI host template const
2023-03-24 19:19:20 -04:00
BusLogic.h
…
bvme6000_scsi.c
…
ch.c
scsi: replace the fmode_t argument to scsi_ioctl with a simple bool
2023-06-12 08:04:04 -06:00
constants.c
…
dc395x.c
scsi: dc395x: Declare SCSI host template const
2023-03-24 19:19:21 -04:00
dc395x.h
…
dmx3191d.c
scsi: dmx3191d: Declare SCSI host template const
2023-03-24 19:19:22 -04:00
esp_scsi.c
scsi: esp_scsi: Declare SCSI host template const
2023-03-24 19:19:22 -04:00
esp_scsi.h
scsi: esp_scsi: Declare SCSI host template const
2023-03-24 19:19:22 -04:00
fdomain_isa.c
…
fdomain_pci.c
…
fdomain.c
scsi: fdomain: Declare SCSI host template const
2023-03-24 19:19:22 -04:00
fdomain.h
…
FlashPoint.c
scsi: FlashPoint: Remove redundant variable bm_int_st
2022-08-01 19:52:03 -04:00
g_NCR5380.c
scsi: NCR5380: Declare SCSI host template const
2023-03-24 19:19:22 -04:00
gvp11.c
scsi: gvp11: Declare SCSI host template const
2023-03-24 19:19:22 -04:00
gvp11.h
…
hosts.c
scsi: core: Support setting BLK_MQ_F_BLOCKING
2023-05-31 11:42:46 -04:00
hpsa_cmd.h
…
hpsa.c
Merge patch series "Constify most SCSI host templates"
2023-03-24 20:13:03 -04:00
hpsa.h
…
hptiop.c
overflow: Add struct_size_t() helper
2023-05-26 13:52:19 -07:00
hptiop.h
scsi: hptiop: Replace one-element array with flexible-array member in struct hpt_iop_request_ioctl_command()
2022-09-25 13:04:17 -04:00
imm.c
scsi: imm: Declare SCSI host template const
2023-03-24 19:19:56 -04:00
imm.h
scsi: imm: Move the SCSI pointer to private command data
2022-02-22 21:11:04 -05:00
initio.c
scsi: initio: Declare SCSI host template const
2023-03-24 19:19:56 -04:00
initio.h
scsi: initio: Stop using the SCSI pointer
2022-02-22 21:11:05 -05:00
ipr.c
scsi: ipr: Remove several unused variables
2023-04-24 23:11:47 -04:00
ipr.h
scsi: ipr: Remove SATA support
2023-04-18 23:01:23 -04:00
ips.c
scsi: ips: Replace kmap_atomic() with kmap_local_page()
2023-01-18 18:41:12 -05:00
ips.h
…
iscsi_boot_sysfs.c
…
iscsi_tcp.c
scsi: iscsi_tcp: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage
2023-06-24 15:50:13 -07:00
iscsi_tcp.h
scsi: iscsi_tcp: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage
2023-06-24 15:50:13 -07:00
jazz_esp.c
scsi: esp_scsi: Declare SCSI host template const
2023-03-24 19:19:22 -04:00
Kconfig
scsi: Add HAS_IOPORT dependencies
2023-05-31 19:59:26 -04:00
lasi700.c
…
libiscsi_tcp.c
scsi: iscsi: Remove iscsi_get_task back_lock requirement
2022-06-21 21:19:23 -04:00
libiscsi.c
scsi: iscsi: Declare SCSI host template const
2023-03-24 19:19:57 -04:00
mac53c94.c
scsi: mac53c94: Declare SCSI host template const
2023-03-24 19:19:57 -04:00
mac53c94.h
scsi: mac53c94: Stop using struct scsi_pointer
2022-02-27 21:35:30 -05:00
mac_esp.c
scsi: esp_scsi: Declare SCSI host template const
2023-03-24 19:19:22 -04:00
mac_scsi.c
scsi: NCR5380: Add SCp members to struct NCR5380_cmd
2022-02-22 21:11:03 -05:00
Makefile
scsi: dpt_i2o: Remove obsolete driver
2022-06-27 22:56:21 -04:00
megaraid.c
scsi: megaraid: Fix mega_cmd_done() CMDID_INT_CMDS
2023-03-24 20:27:17 -04:00
megaraid.h
scsi: megaraid: Stop using the SCSI pointer
2022-02-22 21:11:05 -05:00
mesh.c
scsi: mesh: Declare SCSI host template const
2023-03-24 19:19:57 -04:00
mesh.h
scsi: mesh: Stop using struct scsi_pointer
2022-02-27 21:34:02 -05:00
mvme16x_scsi.c
…
mvme147.c
scsi: mvme147: Declare SCSI host template const
2023-03-24 19:19:57 -04:00
mvme147.h
…
mvumi.c
scsi: mvumi: Declare SCSI host template const
2023-03-24 19:19:58 -04:00
mvumi.h
scsi: mvumi: Replace 1-element arrays with flexible array members
2023-01-12 00:11:11 -05:00
myrb.c
scsi: myrb: Declare SCSI host template const
2023-03-24 19:19:58 -04:00
myrb.h
…
myrs.c
scsi: myrs: Declare SCSI host template const
2023-03-24 19:19:58 -04:00
myrs.h
…
ncr53c8xx.c
scsi: ncr53c8xx: Replace strlcpy() with strscpy()
2023-06-21 21:13:00 -04:00
ncr53c8xx.h
scsi: zalon: Stop using the SCSI pointer
2022-02-22 21:11:07 -05:00
NCR5380.c
scsi: NCR5380: Use default @max_active for hostdata->work_q
2023-05-22 15:13:03 -10:00
NCR5380.h
scsi: NCR5380: Add SCp members to struct NCR5380_cmd
2022-02-22 21:11:03 -05:00
nsp32_debug.c
…
nsp32_io.h
…
nsp32.c
scsi: nsp32: Declare SCSI host template const
2023-03-24 19:19:58 -04:00
nsp32.h
scsi: nsp32: Stop using the SCSI pointer
2022-02-22 21:11:06 -05:00
pmcraid.c
Driver core changes for 6.4-rc1
2023-04-27 11:53:57 -07:00
pmcraid.h
scsi: pmcraid: Remove the PMCRAID_PASSTHROUGH_IOCTL ioctl implementation
2022-03-29 23:32:26 -04:00
ppa.c
scsi: ppa: Declare SCSI host template const
2023-03-24 19:19:58 -04:00
ppa.h
…
ps3rom.c
scsi: ps3rom: Declare SCSI host template const
2023-03-24 19:19:58 -04:00
qla1280.c
scsi: qla1280: Declare SCSI host template const
2023-03-24 19:19:59 -04:00
qla1280.h
scsi: qla1280: Move the SCSI pointer to private command data
2022-02-22 21:11:06 -05:00
qlogicfas408.c
scsi: Remove drivers/scsi/scsi.h
2022-02-22 21:11:02 -05:00
qlogicfas408.h
…
qlogicfas.c
scsi: Remove drivers/scsi/scsi.h
2022-02-22 21:11:02 -05:00
qlogicpti.c
Merge patch series "Constify most SCSI host templates"
2023-03-24 20:13:03 -04:00
qlogicpti.h
…
raid_class.c
…
script_asm.pl
…
scsi_bsg.c
scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool
2023-06-12 08:04:04 -06:00
scsi_common.c
scsi: core: Use min() instead of open-coding it
2023-05-31 11:05:34 -04:00
scsi_debug.c
scsi: scsi_debug: Remove dead code
2023-07-05 21:37:43 -04:00
scsi_debugfs.c
scsi: core: Remove struct scsi_request
2022-03-01 22:21:50 -05:00
scsi_debugfs.h
…
scsi_devinfo.c
scsi: core: Add BLIST_SKIP_VPD_PAGES for SKhynix H28U74301AMR
2023-03-16 22:54:43 -04:00
scsi_dh.c
…
scsi_error.c
scsi: sd: Handle read/write CDL timeout failures
2023-05-22 17:05:19 -04:00
scsi_ioctl.c
scsi: replace the fmode_t argument to scsi_ioctl with a simple bool
2023-06-12 08:04:04 -06:00
scsi_lib_dma.c
…
scsi_lib.c
SCSI misc on 20230629
2023-06-30 11:57:07 -07:00
scsi_logging.c
scsi: core: scsi_logging: Fix a BUG
2022-03-29 23:29:19 -04:00
scsi_logging.h
…
scsi_netlink.c
…
scsi_pm.c
scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()
2021-12-22 23:38:29 -05:00
scsi_priv.h
scsi: sd: Handle read/write CDL timeout failures
2023-05-22 17:05:19 -04:00
scsi_proc.c
scsi: core: Introduce a new list for SCSI proc directory entries
2022-10-18 03:17:09 +00:00
scsi_sas_internal.h
…
scsi_scan.c
scsi: core: Detect support for command duration limits
2023-05-22 17:05:19 -04:00
scsi_sysctl.c
scsi: simplify sysctl registration with register_sysctl()
2023-04-13 11:49:20 -07:00
scsi_sysfs.c
scsi: core: Allow enabling and disabling command duration limits
2023-05-22 17:05:19 -04:00
scsi_trace.c
…
scsi_transport_api.h
…
scsi_transport_fc.c
scsi: core: Replace scsi_target_block() with scsi_block_targets()
2023-06-16 12:19:59 -04:00
scsi_transport_iscsi.c
scsi: core: Replace scsi_target_block() with scsi_block_targets()
2023-06-16 12:19:59 -04:00
scsi_transport_sas.c
scsi: core: Support retrieving sub-pages of mode pages
2023-05-22 17:05:19 -04:00
scsi_transport_spi.c
scsi: spi: Convert to scsi_execute_cmd()
2023-01-13 21:34:09 -05:00
scsi_transport_srp.c
scsi: core: Replace scsi_target_block() with scsi_block_targets()
2023-06-16 12:19:59 -04:00
scsi.c
scsi: core: Simplify scsi_cdl_check_cmd()
2023-06-28 21:47:09 -04:00
scsicam.c
scsicam: Fix use of page cache
2022-05-08 14:28:18 -04:00
sd_dif.c
scsi: sd: Update DIX config every time sd_revalidate_disk() is called
2023-02-21 22:00:32 -05:00
sd_trace.h
scsi: sd: sd_zbc: Trace zone append emulation
2022-12-01 03:13:55 +00:00
sd_zbc.c
scsi: sd_zbc: Set zone limits before revalidating zones
2023-07-05 21:58:10 -04:00
sd.c
SCSI misc on 20230629
2023-06-30 11:57:07 -07:00
sd.h
scsi: sd: Revert "Rework asynchronous resume support"
2022-08-22 22:45:25 -04:00
sense_codes.h
…
ses.c
Driver core changes for 6.4-rc1
2023-04-27 11:53:57 -07:00
sg.c
scsi: sg: Fix checking return value of blk_get_queue()
2023-07-19 23:12:13 -04:00
sgiwd93.c
scsi: sgiwd93: Declare SCSI host template const
2023-03-24 19:19:59 -04:00
sim710.c
…
sni_53c710.c
…
sr_ioctl.c
scsi: sr: Convert to scsi_execute_cmd()
2023-01-13 21:34:09 -05:00
sr_vendor.c
scsi: sr: Don't use GFP_DMA
2021-12-22 23:41:13 -05:00
sr.c
SCSI misc on 20230629
2023-06-30 11:57:07 -07:00
sr.h
sr: implement ->free_disk to simplify refcounting
2022-03-08 19:40:01 -07:00
st_options.h
…
st.c
scsi: replace the fmode_t argument to scsi_ioctl with a simple bool
2023-06-12 08:04:04 -06:00
st.h
scsi: don't use disk->private_data to find the scsi_driver
2022-03-08 19:40:00 -07:00
stex.c
scsi: stex: Fix gcc 13 warnings
2023-05-31 11:36:40 -04:00
storvsc_drv.c
scsi: storvsc: Handle SRB status value 0x30
2023-07-11 12:38:49 -04:00
sun3_scsi_vme.c
…
sun3_scsi.c
scsi: NCR5380: Add SCp members to struct NCR5380_cmd
2022-02-22 21:11:03 -05:00
sun3x_esp.c
scsi: esp_scsi: Declare SCSI host template const
2023-03-24 19:19:22 -04:00
sun_esp.c
Merge patch series "Constify most SCSI host templates"
2023-03-24 20:13:03 -04:00
virtio_scsi.c
scsi: virtio_scsi: Remove a useless function call
2023-05-31 11:37:37 -04:00
vmw_pvscsi.c
scsi: vmw_pvscsi: No need to clear memory after a dma_alloc_coherent() call
2022-04-06 23:01:54 -04:00
vmw_pvscsi.h
scsi: vmw_pvscsi: Expand vcpuHint to 16 bits
2022-06-07 21:30:56 -04:00
wd33c93.c
scsi: wd33c93: Remove dead code related to the long-gone config WD33C93_PIO
2022-09-25 13:29:53 -04:00
wd33c93.h
scsi: wd33c93: Remove dead code related to the long-gone config WD33C93_PIO
2022-09-25 13:29:53 -04:00
wd719x.c
scsi: wd719x: Declare SCSI host template const
2023-03-24 19:19:59 -04:00
wd719x.h
scsi: wd719x: Stop using the SCSI pointer
2022-02-22 21:11:07 -05:00
xen-scsifront.c
scsi: xen-scsifront: Declare SCSI host template const
2023-03-24 19:20:00 -04:00
zalon.c
scsi: zalon: Stop using the SCSI pointer
2022-02-22 21:11:07 -05:00
zorro7xx.c
scsi: zorro7xx: Fix a resource leak in zorro7xx_remove_one()
2022-03-30 00:05:42 -04:00
zorro_esp.c
scsi: esp_scsi: Declare SCSI host template const
2023-03-24 19:19:22 -04:00