37882100cd
When KASAN is enabled, below log might be dumped with Intel EHL hardware:
[ 48.583597] ==================================================================
[ 48.585921] BUG: KASAN: slab-out-of-bounds in hdac_hda_dai_hw_params+0x20a/0x22b [snd_soc_hdac_hda]
[ 48.587995] Write of size 4 at addr ffff888103489708 by task pulseaudio/759
[ 48.589237] CPU: 2 PID: 759 Comm: pulseaudio Tainted: G U E 5.15.71-intel-ese-standard-lts #9
[ 48.591272] Hardware name: Intel Corporation Elkhart Lake Embedded Platform/ElkhartLake LPDDR4x T3 CRB, BIOS EHLSFWI1.R00.4251.A01.2206130432 06/13/2022
[ 48.593010] Call Trace:
[ 48.593648] <TASK>
[ 48.593852] dump_stack_lvl+0x34/0x48
[ 48.594404] print_address_description.constprop.0+0x1f/0x140
[ 48.595174] ? hdac_hda_dai_hw_params+0x20a/0x22b [snd_soc_hdac_hda]
[ 48.595868] ? hdac_hda_dai_hw_params+0x20a/0x22b [snd_soc_hdac_hda]
[ 48.596519] kasan_report.cold+0x7f/0x11b
[ 48.597003] ? hdac_hda_dai_hw_params+0x20a/0x22b [snd_soc_hdac_hda]
[ 48.597885] hdac_hda_dai_hw_params+0x20a/0x22b [snd_soc_hdac_hda]
HDAC_LAST_DAI_ID is last index id, pcm buffer array size should
be +1 to avoid out of bound access.
Fixes: 608b8c36c3 ("ASoC: hdac_hda: add support for HDMI/DP as a HDA codec")
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Junxiao Chang <junxiao.chang@intel.com>
Signed-off-by: Furong Zhou <furong.zhou@intel.com>
Link: https://lore.kernel.org/r/20221109234023.3111035-1-junxiao.chang@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
34 lines
604 B
C
34 lines
604 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright(c) 2015-18 Intel Corporation.
|
|
*/
|
|
|
|
#ifndef __HDAC_HDA_H__
|
|
#define __HDAC_HDA_H__
|
|
|
|
enum {
|
|
HDAC_ANALOG_DAI_ID = 0,
|
|
HDAC_DIGITAL_DAI_ID,
|
|
HDAC_ALT_ANALOG_DAI_ID,
|
|
HDAC_HDMI_0_DAI_ID,
|
|
HDAC_HDMI_1_DAI_ID,
|
|
HDAC_HDMI_2_DAI_ID,
|
|
HDAC_HDMI_3_DAI_ID,
|
|
HDAC_DAI_ID_NUM
|
|
};
|
|
|
|
struct hdac_hda_pcm {
|
|
int stream_tag[2];
|
|
unsigned int format_val[2];
|
|
};
|
|
|
|
struct hdac_hda_priv {
|
|
struct hda_codec *codec;
|
|
struct hdac_hda_pcm pcm[HDAC_DAI_ID_NUM];
|
|
bool need_display_power;
|
|
};
|
|
|
|
struct hdac_ext_bus_ops *snd_soc_hdac_hda_get_ops(void);
|
|
|
|
#endif /* __HDAC_HDA_H__ */
|