Eric Dumazet
6ebfad3316
packet: annotate data-races around ignore_outgoing ...
ignore_outgoing is read locklessly from dev_queue_xmit_nit()
and packet_getsockopt()
Add appropriate READ_ONCE()/WRITE_ONCE() annotations.
syzbot reported:
BUG: KCSAN: data-race in dev_queue_xmit_nit / packet_setsockopt
write to 0xffff888107804542 of 1 bytes by task 22618 on cpu 0:
packet_setsockopt+0xd83/0xfd0 net/packet/af_packet.c:4003
do_sock_setsockopt net/socket.c:2311 [inline]
__sys_setsockopt+0x1d8/0x250 net/socket.c:2334
__do_sys_setsockopt net/socket.c:2343 [inline]
__se_sys_setsockopt net/socket.c:2340 [inline]
__x64_sys_setsockopt+0x66/0x80 net/socket.c:2340
do_syscall_64+0xd3/0x1d0
entry_SYSCALL_64_after_hwframe+0x6d/0x75
read to 0xffff888107804542 of 1 bytes by task 27 on cpu 1:
dev_queue_xmit_nit+0x82/0x620 net/core/dev.c:2248
xmit_one net/core/dev.c:3527 [inline]
dev_hard_start_xmit+0xcc/0x3f0 net/core/dev.c:3547
__dev_queue_xmit+0xf24/0x1dd0 net/core/dev.c:4335
dev_queue_xmit include/linux/netdevice.h:3091 [inline]
batadv_send_skb_packet+0x264/0x300 net/batman-adv/send.c:108
batadv_send_broadcast_skb+0x24/0x30 net/batman-adv/send.c:127
batadv_iv_ogm_send_to_if net/batman-adv/bat_iv_ogm.c:392 [inline]
batadv_iv_ogm_emit net/batman-adv/bat_iv_ogm.c:420 [inline]
batadv_iv_send_outstanding_bat_ogm_packet+0x3f0/0x4b0 net/batman-adv/bat_iv_ogm.c:1700
process_one_work kernel/workqueue.c:3254 [inline]
process_scheduled_works+0x465/0x990 kernel/workqueue.c:3335
worker_thread+0x526/0x730 kernel/workqueue.c:3416
kthread+0x1d1/0x210 kernel/kthread.c:388
ret_from_fork+0x4b/0x60 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:243
value changed: 0x00 -> 0x01
Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 27 Comm: kworker/u8:1 Tainted: G W 6.8.0-syzkaller-08073-g480e035fc4c7 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
Workqueue: bat_events batadv_iv_send_outstanding_bat_ogm_packet
Fixes: fa788d986a3a ("packet: add sockopt to ignore outgoing packets")
Reported-by: syzbot+c669c1136495a2e7c31f@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/CANn89i+Z7MfbkBLOv=p7KZ7=K1rKHO4P1OL5LYDCtBiyqsa9oQ@mail.gmail.com/T/#t
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2024-03-18 09:34:54 +00:00
2024-02-09 14:12:01 -08:00
2023-12-13 05:44:30 +09:00
2024-02-26 11:46:12 +00:00
2023-12-26 20:31:01 +00:00
2024-02-09 14:12:01 -08:00
2024-02-02 12:44:16 +00:00
2024-03-08 11:06:14 -05:00
2024-03-11 18:06:04 -07:00
2024-02-29 14:24:56 -08:00
2024-01-05 08:06:35 -08:00
2024-02-20 15:32:45 +01:00
2024-03-06 12:43:01 +01:00
2024-03-18 09:34:54 +00:00
2024-02-02 12:19:26 +00:00
2024-03-13 08:31:40 +00:00
2024-01-11 10:07:29 -08:00
2024-03-07 20:37:13 -08:00
2024-03-06 20:40:20 -08:00
2024-02-08 18:32:29 -08:00
2024-03-14 13:02:51 +01:00
2024-03-08 20:35:33 -08:00
2023-12-15 10:50:18 +00:00
2024-03-14 10:57:02 +01:00
2024-03-11 20:38:36 -07:00
2024-02-22 18:28:13 -08:00
2024-03-11 09:53:22 +00:00
2024-02-09 14:12:01 -08:00
2024-03-11 09:53:22 +00:00
2024-01-30 13:49:09 +01:00
2024-03-08 09:05:49 -08:00
2024-03-06 21:01:26 +01:00
2024-02-29 14:24:56 -08:00
2024-03-07 20:42:13 -08:00
2024-03-11 10:37:40 +00:00
2023-11-18 15:00:51 +00:00
2024-03-12 17:44:08 -07:00
2024-02-28 19:37:34 -08:00
2024-03-11 15:48:34 -07:00
2024-03-07 10:36:58 +01:00
2024-03-05 11:21:18 -08:00
2024-02-09 12:54:38 -08:00
2024-03-18 09:34:54 +00:00
2024-02-22 09:05:50 +01:00
2023-12-29 08:43:59 +00:00
2024-01-01 18:41:29 +00:00
2024-03-07 10:29:36 -08:00
2023-12-21 22:17:23 +01:00
2023-12-15 11:59:53 +00:00
2024-03-14 13:09:53 +01:00
2024-03-13 08:26:42 +00:00
2024-03-07 21:12:43 -08:00
2024-03-05 15:49:35 +01:00
2024-03-01 09:12:30 -05:00
2024-02-16 09:36:37 +00:00
2024-02-15 13:18:19 +01:00
2024-02-29 09:07:16 -08:00
2024-02-22 15:29:26 -08:00
2024-01-23 15:13:54 +01:00
2024-03-08 09:05:49 -08:00
2024-03-11 09:53:22 +00:00
2024-03-02 20:50:59 -08:00
2024-03-08 10:56:05 +00:00
2023-12-12 14:24:14 +01:00
2024-02-18 10:19:21 +00:00
2024-01-31 16:41:16 -08:00
2024-03-14 16:48:53 -07:00
6ebfad3316