iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/kernel/trace
History
Gaurav Kohli bbeb97464e tracing: Fix race in trace_open and buffer resize call 
Below race can come, if trace_open and resize of
cpu buffer is running parallely on different cpus
CPUX                                CPUY
				    ring_buffer_resize
				    atomic_read(&buffer->resize_disabled)
tracing_open
tracing_reset_online_cpus
ring_buffer_reset_cpu
rb_reset_cpu
				    rb_update_pages
				    remove/insert pages
resetting pointer

This race can cause data abort or some times infinte loop in
rb_remove_pages and rb_insert_pages while checking pages
for sanity.

Take buffer lock to fix this.

Link: https://lkml.kernel.org/r/1601976833-24377-1-git-send-email-gkohli@codeaurora.org

Cc: stable@vger.kernel.org
Fixes: b23d7a5f4a07a ("ring-buffer: speed up buffer resets by avoiding synchronize_rcu for each CPU")
Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
2020-10-15 12:01:13 -04:00
..
blktrace.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
bpf_trace.c
bpf: Remove inline from bpf_do_trace_printk
2020-08-06 16:53:17 -07:00
bpf_trace.h
bpf: Use dedicated bpf_trace_printk event instead of trace_printk()
2020-07-13 16:55:49 -07:00
fgraph.c
fgraph: Convert ret_stack tasklist scanning to rcu
2020-09-21 21:06:02 -04:00
ftrace_internal.h
x86/ftrace: Have ftrace trampolines turn read-only at the end of system boot up
2020-05-12 18:24:34 -04:00
ftrace.c
ftrace: Format variable declarations of ftrace_allocate_records
2020-10-08 15:29:06 -04:00
Kconfig
Tracing updates for 5.8:
2020-06-09 10:06:18 -07:00
kprobe_event_gen_test.c
tracing: Add kprobe event command generation test module
2020-01-30 09:46:28 -05:00
Makefile
Kbuild updates for v5.9
2020-08-09 14:10:26 -07:00
power-traces.c
…
preemptirq_delay_test.c
tracing: Wait for preempt irq delay thread to execute
2020-05-11 17:00:34 -04:00
ring_buffer_benchmark.c
sched,tracing: Convert to sched_set_fifo()
2020-07-29 11:43:53 +02:00
ring_buffer.c
tracing: Fix race in trace_open and buffer resize call
2020-10-15 12:01:13 -04:00
rpm-traces.c
…
synth_event_gen_test.c
tracing: Add support for dynamic strings to synthetic events
2020-10-05 19:32:18 -04:00
trace_benchmark.c
trace: Use pr_warn instead of pr_warning
2019-10-18 15:01:57 +02:00
trace_benchmark.h
…
trace_boot.c
tracing/boot, kprobe, synth: Initialize boot-time tracing earlier
2020-09-21 21:06:04 -04:00
trace_branch.c
tracing: Make struct ring_buffer less ambiguous
2020-01-13 13:19:38 -05:00
trace_clock.c
…
trace_dynevent.c
tracing: Delete repeated words in comments
2020-09-21 21:06:02 -04:00
trace_dynevent.h
tracing: Remove check_arg() callbacks from dynevent args
2020-02-01 13:09:23 -05:00
trace_entries.h
tracing: Make ftrace packed events have align of 1
2020-06-16 21:21:02 -04:00
trace_event_perf.c
Merge branch 'perf/urgent' into perf/core, to pick up fixes
2019-10-28 12:38:26 +01:00
trace_events_filter_test.h
…
trace_events_filter.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
trace_events_hist.c
tracing: Check return value of __create_val_fields() before using its result
2020-10-15 12:00:59 -04:00
trace_events_inject.c
tracing: Initialize val to zero in parse_entry of inject code
2020-01-02 19:04:57 -05:00
trace_events_synth.c
tracing: Fix synthetic print fmt check for use of __get_str()
2020-10-08 15:29:07 -04:00
trace_events_trigger.c
tracing: Fix event trigger to accept redundant spaces
2020-06-23 21:51:40 -04:00
trace_events.c
tracing/boot: Initialize per-instance event list in early boot
2020-09-25 15:36:03 -04:00
trace_export.c
tracing: Make ftrace packed events have align of 1
2020-06-16 21:21:02 -04:00
trace_functions_graph.c
tracing: make tracing_init_dentry() returns an integer instead of a d_entry pointer
2020-09-18 22:17:14 -04:00
trace_functions.c
tracing: Enable creating new instance early boot
2020-09-21 21:06:04 -04:00
trace_hwlat.c
tracing: make tracing_init_dentry() returns an integer instead of a d_entry pointer
2020-09-18 22:17:14 -04:00
trace_irqsoff.c
tracing: Rename trace_buffer to array_buffer
2020-01-13 13:19:38 -05:00
trace_kdb.c
tracing: Rename trace_buffer to array_buffer
2020-01-13 13:19:38 -05:00
trace_kprobe_selftest.c
…
trace_kprobe_selftest.h
…
trace_kprobe.c
tracing/boot, kprobe, synth: Initialize boot-time tracing earlier
2020-09-21 21:06:04 -04:00
trace_mmiotrace.c
tracing: Make struct ring_buffer less ambiguous
2020-01-13 13:19:38 -05:00
trace_nop.c
…
trace_output.c
tracing: Make the space reserved for the pid wider
2020-09-18 12:42:11 -04:00
trace_output.h
…
trace_preemptirq.c
x86/entry: Rename trace_hardirqs_off_prepare()
2020-06-11 15:15:24 +02:00
trace_printk.c
tracing: make tracing_init_dentry() returns an integer instead of a d_entry pointer
2020-09-18 22:17:14 -04:00
trace_probe_tmpl.h
tracing/probe: Support user-space dereference
2019-05-25 23:04:42 -04:00
trace_probe.c
tracing/probe: Fix memleak in fetch_op_data operations
2020-06-16 21:21:02 -04:00
trace_probe.h
tracing/kprobes: Support perf-style return probe
2020-09-21 21:06:03 -04:00
trace_sched_switch.c
tracing: Fix sched switch start/stop refcount racy updates
2020-01-30 09:46:10 -05:00
trace_sched_wakeup.c
tracing: Make struct ring_buffer less ambiguous
2020-01-13 13:19:38 -05:00
trace_selftest_dynamic.c
…
trace_selftest.c
tracing: Rename trace_buffer to array_buffer
2020-01-13 13:19:38 -05:00
trace_seq.c
tracing: Remove unused TRACE_SEQ_BUF_USED
2020-01-21 18:39:54 -05:00
trace_stack.c
tracing: make tracing_init_dentry() returns an integer instead of a d_entry pointer
2020-09-18 22:17:14 -04:00
trace_stat.c
tracing: make tracing_init_dentry() returns an integer instead of a d_entry pointer
2020-09-18 22:17:14 -04:00
trace_stat.h
tracing: Use generic type for comparator function
2019-11-14 13:15:11 -05:00
trace_synth.h
tracing: Add support for dynamic strings to synthetic events
2020-10-05 19:32:18 -04:00
trace_syscalls.c
Tracing updates:
2020-02-06 07:12:11 +00:00
trace_uprobe.c
tracing/uprobes: Support perf-style return probe
2020-09-21 21:06:03 -04:00
trace.c
tracing: Remove a pointless assignment
2020-10-08 15:29:06 -04:00
trace.h
tracing/boot: Initialize per-instance event list in early boot
2020-09-25 15:36:03 -04:00
tracing_map.c
tracing: Delete repeated words in comments
2020-09-21 21:06:02 -04:00
tracing_map.h
…