iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
bcc71cc3cd
linux/drivers/scsi/qla2xxx
History
Giridhar Malavali bcc71cc3cd scsi: qla2xxx: Fix for double free of SRB structure 
This patch fixes issue during switch command query where driver was freeing
SRB resources multiple times

Following stack trace will be seen
[  853.436234] BUG: unable to handle kernel NULL pointer dereference at
0000000000000001
[  853.436348] IP: [<ffffffff811df514>] kmem_cache_alloc+0x74/0x1e0
[  853.436476] PGD 0
[  853.436601] Oops: 0000 [#1] SMP

[  853.454700]  [<ffffffff81099f6a>] ? mod_timer+0x14a/0x220
[  853.455543]  [<ffffffff81185465>] mempool_alloc_slab+0x15/0x20
[  853.456395]  [<ffffffff811855a9>] mempool_alloc+0x69/0x170
[  853.457257]  [<ffffffff81098af2>] ? internal_add_timer+0x32/0x70
[  853.458136]  [<ffffffffc0092d2b>] qla2xxx_queuecommand+0x29b/0x3f0 [qla2xxx]
[  853.459024]  [<ffffffff8146535a>] scsi_dispatch_cmd+0xaa/0x230
[  853.459923]  [<ffffffff8146e11f>] scsi_request_fn+0x4df/0x680
[  853.460829]  [<ffffffff81029557>] ? __switch_to+0xd7/0x510
[  853.461747]  [<ffffffff812f7113>] __blk_run_queue+0x33/0x40
[  853.462670]  [<ffffffff812f7735>] blk_delay_work+0x25/0x40
[  853.463603]  [<ffffffff810a882a>] process_one_work+0x17a/0x440
[  853.464546]  [<ffffffff810a94f6>] worker_thread+0x126/0x3c0
[  853.465501]  [<ffffffff810a93d0>] ? manage_workers.isra.24+0x2a0/0x2a0
[  853.466447]  [<ffffffff810b099f>] kthread+0xcf/0xe0
[  853.467379]  [<ffffffff810b08d0>] ? insert_kthread_work+0x40/0x40
[  853.470172] Code: db e2 7e 49 8b 50 08 4d 8b 20 49 8b 40 10 4d 85 e4 0f 84 20
01 00 00 48 85 c0 0f 84 17 01 00 00 49 63 46 20 48 8d 4a 01 4d 8b 06 <49> 8b 1c
04 4c 89 e0 65 49 0f c7 08 0f 94 c0 84 c0 74 ba 49 63
[  853.472072] RIP  [<ffffffff811df514>] kmem_cache_alloc+0x74/0x1e0
[  853.472971]  RSP <ffff88103726fc50>

Fixes: 726b854870 ("qla2xxx: Add framework for async fabric discovery")
Cc: <stable@vger.kernel.org>
Signed-off-by: Giridhar Malavali <giridhar.malavali@cavium.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-09-27 20:16:06 -04:00
..
Kconfig scsi: qla2xxx: avoid unused-function warning 2017-07-01 17:14:58 -04:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
qla_attr.c scsi: qla2xxx: don't allow negative thresholds 2018-09-27 19:50:32 -04:00
qla_bsg.c scsi: qla2xxx: Reject bsg request if chip is down. 2018-09-11 20:28:10 -04:00
qla_bsg.h
qla_dbg.c scsi: qla2xxx: Add longer window for chip reset 2018-08-02 16:56:18 -04:00
qla_dbg.h scsi: qla2xxx: Include Exchange offload/Extended Login into FW dump 2017-06-27 21:21:41 -04:00
qla_def.h scsi: qla2xxx: Add mode control for each physical port 2018-09-11 20:28:09 -04:00
qla_devtbl.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
qla_dfs.c scsi: qla2xxx: Add XCB counters to debugfs 2018-01-22 20:03:54 -05:00
qla_fw.h scsi: qla2xxx: Migrate NVME N2N handling into state machine 2018-08-02 16:56:18 -04:00
qla_gbl.h scsi: qla2xxx: Add mode control for each physical port 2018-09-11 20:28:09 -04:00
qla_gs.c scsi: qla2xxx: Fix for double free of SRB structure 2018-09-27 20:16:06 -04:00
qla_init.c scsi: qla2xxx: Fix for double free of SRB structure 2018-09-27 20:16:06 -04:00
qla_inline.h scsi: qla2xxx: Add mode control for each physical port 2018-09-11 20:28:09 -04:00
qla_iocb.c scsi: qla2xxx: Remove set but not used variable 'ptr_dma' 2018-09-17 03:02:22 -04:00
qla_isr.c scsi: qla2xxx: Fix dropped srb resource. 2018-09-11 20:28:09 -04:00
qla_mbx.c scsi: qla2xxx: Fix recursive mailbox timeout 2018-09-27 20:15:05 -04:00
qla_mid.c SCSI misc on 20180815 2018-08-15 22:06:26 -07:00
qla_mr.c scsi: qla2xxx: Fix race condition between iocb timeout and initialisation 2018-04-09 21:04:36 -04:00
qla_mr.h
qla_nvme.c scsi: qla2xxx: Fix driver hang when FC-NVMe LUNs are configured 2018-09-27 20:15:05 -04:00
qla_nvme.h scsi: qla2xxx: Migrate NVME N2N handling into state machine 2018-08-02 16:56:18 -04:00
qla_nx2.c scsi: qla2xxx: Fix function argument descriptions 2018-02-12 11:43:25 -05:00
qla_nx2.h scsi: qla2xxx: Remove unused symbols 2018-02-12 11:43:24 -05:00
qla_nx.c treewide: kmalloc() -> kmalloc_array() 2018-06-12 16:19:22 -07:00
qla_nx.h scsi: qla2xxx: remove writeq/readq function definitions 2017-06-12 20:48:08 -04:00
qla_os.c scsi: qla2xxx: Fix NVMe Target discovery 2018-09-27 20:15:05 -04:00
qla_settings.h
qla_sup.c scsi: qla2xxx: Fix driver unload by shutting down chip 2018-07-19 22:02:34 -04:00
qla_target.c scsi: qla2xxx: Fix re-using LoopID when handle is in use 2018-09-27 20:15:05 -04:00
qla_target.h scsi: qla2xxx: Fix premature command free 2018-09-11 20:28:10 -04:00
qla_tmpl.c scsi: qla2xxx: Silent erroneous message 2018-08-02 16:56:18 -04:00
qla_tmpl.h
qla_version.h scsi: qla2xxx: Update driver version to 10.00.00.11-k 2018-09-11 20:28:10 -04:00
tcm_qla2xxx.c scsi: qla2xxx: Remove stale debug trace message from tcm_qla2xxx 2018-09-11 20:28:10 -04:00
tcm_qla2xxx.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00