iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/kernel
History
Shang XiaoJing e57daa7503 tracing: kprobe: Fix potential null-ptr-deref on trace_array in kprobe_event_gen_test_exit() 
commit 22ea4ca9631eb137e64e5ab899e9c89cb6670959 upstream.

When test_gen_kprobe_cmd() failed after kprobe_event_gen_cmd_end(), it
will goto delete, which will call kprobe_event_delete() and release the
corresponding resource. However, the trace_array in gen_kretprobe_test
will point to the invalid resource. Set gen_kretprobe_test to NULL
after called kprobe_event_delete() to prevent null-ptr-deref.

BUG: kernel NULL pointer dereference, address: 0000000000000070
PGD 0 P4D 0
Oops: 0000 [#1] SMP PTI
CPU: 0 PID: 246 Comm: modprobe Tainted: G        W
6.1.0-rc1-00174-g9522dc5c87da-dirty #248
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
rel-1.15.0-0-g2dd4b9b3f840-prebuilt.qemu.org 04/01/2014
RIP: 0010:__ftrace_set_clr_event_nolock+0x53/0x1b0
Code: e8 82 26 fc ff 49 8b 1e c7 44 24 0c ea ff ff ff 49 39 de 0f 84 3c
01 00 00 c7 44 24 18 00 00 00 00 e8 61 26 fc ff 48 8b 6b 10 <44> 8b 65
70 4c 8b 6d 18 41 f7 c4 00 02 00 00 75 2f
RSP: 0018:ffffc9000159fe00 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffff88810971d268 RCX: 0000000000000000
RDX: ffff8881080be600 RSI: ffffffff811b48ff RDI: ffff88810971d058
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000001
R10: ffffc9000159fe58 R11: 0000000000000001 R12: ffffffffa0001064
R13: ffffffffa000106c R14: ffff88810971d238 R15: 0000000000000000
FS:  00007f89eeff6540(0000) GS:ffff88813b600000(0000)
knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000070 CR3: 000000010599e004 CR4: 0000000000330ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 __ftrace_set_clr_event+0x3e/0x60
 trace_array_set_clr_event+0x35/0x50
 ? 0xffffffffa0000000
 kprobe_event_gen_test_exit+0xcd/0x10b [kprobe_event_gen_test]
 __x64_sys_delete_module+0x206/0x380
 ? lockdep_hardirqs_on_prepare+0xd8/0x190
 ? syscall_enter_from_user_mode+0x1c/0x50
 do_syscall_64+0x3f/0x90
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f89eeb061b7

Link: https://lore.kernel.org/all/20221108015130.28326-3-shangxiaojing@huawei.com/

Fixes: 64836248dda2 ("tracing: Add kprobe event command generation test module")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Cc: stable@vger.kernel.org
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-11-26 09:24:43 +01:00
..
bpf
bpf: Initialize same number of free nodes for each pcpu_freelist
2022-11-26 09:24:38 +01:00
cgroup
cgroup/cpuset: Enable update_tasks_cpumask() on top_cpuset
2022-10-26 12:35:25 +02:00
configs
…
debug
lockdown: also lock down previous kgdb use
2022-05-25 09:57:37 +02:00
dma
swiotlb: max mapping size takes min align mask into account
2022-10-05 10:39:40 +02:00
entry
lockdep: Fix -Wunused-parameter for _THIS_IP_
2022-09-20 12:39:42 +02:00
events
perf: Fix missing SIGTRAPs
2022-11-03 23:59:15 +09:00
gcov
gcov: support GCC 12.1 and newer compilers
2022-10-26 12:35:56 +02:00
irq
irqdomain: Report irq number for NOMAP domains
2022-08-17 14:23:14 +02:00
kcsan
LKMM updates:
2021-09-02 13:00:15 -07:00
livepatch
livepatch: fix race between fork and KLP transition
2022-10-26 12:34:30 +02:00
locking
lockdep: Fix -Wunused-parameter for _THIS_IP_
2022-09-20 12:39:42 +02:00
power
PM: hibernate: Allow hybrid sleep to work with s2idle
2022-11-03 23:59:17 +09:00
printk
printk: wake waiters for safe and NMI contexts
2022-06-09 10:22:49 +02:00
rcu
rcu-tasks: Convert RCU_LOCKDEP_WARN() to WARN_ONCE()
2022-10-26 12:35:29 +02:00
sched
sched/core: Fix comparison in sched_group_cookie_match()
2022-11-03 23:59:15 +09:00
time
timekeeping: contribute wall clock to rng on time change
2022-08-17 14:24:24 +02:00
trace
tracing: kprobe: Fix potential null-ptr-deref on trace_array in kprobe_event_gen_test_exit()
2022-11-26 09:24:43 +01:00
.gitignore
…
acct.c
kernel/acct.c: use dedicated helper to access rlimit values
2021-09-08 11:50:26 -07:00
async.c
Revert "module, async: async_synchronize_full() on module init iff async is used"
2022-02-23 12:03:07 +01:00
audit_fsnotify.c
audit: fix potential double free on error path from fsnotify_add_inode_mark
2022-08-31 17:16:33 +02:00
audit_tree.c
audit: move put_tree() to avoid trim_trees refcount underflow and UAF
2021-08-24 18:52:36 -04:00
audit_watch.c
…
audit.c
audit: improve audit queue handling when "audit=1" on cmdline
2022-02-08 18:34:03 +01:00
audit.h
audit: log AUDIT_TIME_* records only from rules
2022-04-08 14:23:06 +02:00
auditfilter.c
…
auditsc.c
audit: log AUDIT_TIME_* records only from rules
2022-04-08 14:23:06 +02:00
backtracetest.c
…
bounds.c
…
capability.c
…
cfi.c
cfi: Fix __cfi_slowpath_diag RCU usage with cpuidle
2022-06-22 14:22:04 +02:00
compat.c
arch: remove compat_alloc_user_space
2021-09-08 15:32:35 -07:00
configs.c
…
context_tracking.c
…
cpu_pm.c
PM: cpu: Make notifier chain use a raw_spinlock_t
2021-08-16 18:55:32 +02:00
cpu.c
random: clear fast pool, crng, and batches in cpuhp bring up
2022-05-30 09:29:09 +02:00
crash_core.c
kernel/crash_core: suppress unknown crashkernel parameter warning
2021-12-29 12:28:49 +01:00
crash_dump.c
…
cred.c
ucounts: Base set_cred_ucounts changes on the real user
2022-02-23 12:03:20 +01:00
delayacct.c
…
dma.c
…
exec_domain.c
…
exit.c
fix race between exit_itimers() and /proc/pid/timers
2022-07-21 21:24:11 +02:00
extable.c
…
fail_function.c
…
fork.c
IB/core: Fix a nested dead lock as part of ODP flow
2022-09-15 11:30:06 +02:00
freezer.c
sched: Add get_current_state()
2021-06-18 11:43:08 +02:00
futex.c
futex: Remove unused variable 'vpid' in futex_proxy_trylock_atomic()
2021-09-03 23:00:22 +02:00
gen_kheaders.sh
kbuild: clean up ${quiet} checks in shell scripts
2021-05-27 04:01:50 +09:00
groups.c
…
hung_task.c
Merge branch 'akpm' (patches from Andrew)
2021-07-02 12:08:10 -07:00
iomem.c
…
irq_work.c
irq_work: Make irq_work_queue() NMI-safe again
2021-06-10 10:00:08 +02:00
jump_label.c
jump_label: Fix jump_label_text_reserved() vs __init
2021-07-05 10:46:20 +02:00
kallsyms.c
module: add printk formats to add module build ID to stacktraces
2021-07-08 11:48:22 -07:00
kcmp.c
…
Kconfig.freezer
…
Kconfig.hz
…
Kconfig.locks
locking/rwlock: Provide RT variant
2021-08-17 17:50:51 +02:00
Kconfig.preempt
sched/core: Disable CONFIG_SCHED_CORE by default
2021-06-28 22:43:05 +02:00
kcov.c
…
kexec_core.c
Merge branch 'rework/printk_safe-removal' into for-linus
2021-08-30 16:36:10 +02:00
kexec_elf.c
…
kexec_file.c
ima: force signature verification when CONFIG_KEXEC_SIG is configured
2022-07-21 21:24:29 +02:00
kexec_internal.h
…
kexec.c
kexec: avoid compat_alloc_user_space
2021-09-08 15:32:34 -07:00
kheaders.c
…
kmod.c
…
kprobes.c
kprobe: reverse kp->flags when arm_kprobe failed
2022-11-10 18:15:38 +01:00
ksysfs.c
…
kthread.c
Merge branch 'akpm' (patches from Andrew)
2021-06-29 17:29:11 -07:00
latencytop.c
…
Makefile
static_call: Don't make __static_call_return0 static
2022-04-13 20:59:28 +02:00
module_signature.c
…
module_signing.c
…
module-internal.h
…
module.c
module: fix [e_shstrndx].sh_size=0 OOB access
2022-07-12 16:35:09 +02:00
notifier.c
notifier: Remove atomic_notifier_call_chain_robust()
2021-08-16 18:55:32 +02:00
nsproxy.c
memcg: enable accounting for new namesapces and struct nsproxy
2021-09-03 09:58:12 -07:00
padata.c
padata: Remove repeated verbose license text
2021-08-27 16:30:18 +08:00
panic.c
Merge branch 'rework/printk_safe-removal' into for-linus
2021-08-30 16:36:10 +02:00
params.c
params: lift param_set_uint_minmax to common code
2021-08-16 14:42:22 +02:00
pid_namespace.c
memcg: enable accounting for new namesapces and struct nsproxy
2021-09-03 09:58:12 -07:00
pid.c
kernel/pid.c: implement additional checks upon pidfd_create() parameters
2021-08-10 12:53:07 +02:00
profile.c
profiling: fix shift too large makes kernel panic
2022-08-17 14:24:04 +02:00
ptrace.c
ptrace: Reimplement PTRACE_KILL by always sending SIGKILL
2022-06-09 10:22:29 +02:00
range.c
…
reboot.c
reboot: Add hardware protection power-off
2021-06-21 13:08:36 +01:00
regset.c
…
relay.c
…
resource_kunit.c
…
resource.c
kernel/resource: fix kfree() of bootmem memory again
2022-04-08 14:23:43 +02:00
rseq.c
rseq: Remove broken uapi field layout on 32-bit little endian
2022-04-08 14:23:10 +02:00
scftorture.c
scftorture: Fix distribution of short handler delays
2022-06-09 10:22:46 +02:00
scs.c
scs: Release kasan vmalloc poison in scs_free process
2021-11-18 19:16:29 +01:00
seccomp.c
seccomp: Invalidate seccomp mode to catch death failures
2022-02-16 12:56:38 +01:00
signal.c
signal handling: don't use BUG_ON() for debugging
2022-07-21 21:24:42 +02:00
smp.c
locking/csd_lock: Change csdlock_debug from early_param to __setup
2022-08-17 14:24:24 +02:00
smpboot.c
smpboot: Replace deprecated CPU-hotplug functions.
2021-08-10 14:57:42 +02:00
smpboot.h
…
softirq.c
genirq: Change force_irqthreads to a static key
2021-08-10 22:50:07 +02:00
stackleak.c
gcc-plugins/stackleak: Use noinstr in favor of notrace
2022-02-23 12:03:07 +01:00
stacktrace.c
stacktrace: move filter_irq_stacks() to kernel/stacktrace.c
2022-04-13 20:59:28 +02:00
static_call_inline.c
static_call: Don't make __static_call_return0 static
2022-04-13 20:59:28 +02:00
static_call.c
static_call: Don't make __static_call_return0 static
2022-04-13 20:59:28 +02:00
stop_machine.c
…
sys_ni.c
kernel/sys_ni: add compat entry for fadvise64_64
2022-08-31 17:16:33 +02:00
sys.c
ucounts: Move RLIMIT_NPROC handling after set_user
2022-02-23 12:03:20 +01:00
sysctl-test.c
kernel/sysctl-test: Remove some casts which are no-longer required
2021-06-23 16:41:24 -06:00
sysctl.c
sysctl: move some boundary constants from sysctl.c to sysctl_vals
2022-07-29 17:25:11 +02:00
task_work.c
…
taskstats.c
…
test_kprobes.c
…
torture.c
torture: Replace deprecated CPU-hotplug functions.
2021-08-10 10:48:07 -07:00
tracepoint.c
tracepoint: Fix kerneldoc comments
2021-08-16 11:39:51 -04:00
tsacct.c
taskstats: Cleanup the use of task->exit_code
2022-01-27 11:05:35 +01:00
ucount.c
ucounts: Handle wrapping in is_ucounts_overlimit
2022-02-23 12:03:20 +01:00
uid16.c
…
uid16.h
…
umh.c
…
up.c
…
user_namespace.c
ucounts: Fix systemd LimitNPROC with private users regression
2022-03-08 19:12:42 +01:00
user-return-notifier.c
…
user.c
fs/epoll: use a per-cpu counter for user's watches count
2021-09-08 11:50:27 -07:00
usermode_driver.c
Merge branch 'work.namei' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2021-07-03 11:41:14 -07:00
utsname_sysctl.c
…
utsname.c
…
watch_queue.c
watch_queue: Fix missing locking in add_watch_to_object()
2022-08-03 12:03:43 +02:00
watchdog_hld.c
…
watchdog.c
watchdog: export lockup_detector_reconfigure
2022-08-25 11:40:43 +02:00
workqueue_internal.h
workqueue: Assign a color to barrier work items
2021-08-17 07:49:10 -10:00
workqueue.c
workqueue: don't skip lockdep work dependency in cancel_work_sync()
2022-09-28 11:11:56 +02:00