Linu Cherian
bd2767ec3d
coresight: Fix run time warnings while reusing ETR buffer
...
Fix the below warning by avoding calls to tmc_etr_enable_hw,
if we are reusing the ETR buffer for multiple sources in sysfs mode.
echo 1 > /sys/bus/coresight/devices/tmc_etr0/enable_sink
echo 1 > /sys/bus/coresight/devices/ete1/enable_source
echo 1 > /sys/bus/coresight/devices/ete2/enable_source
[ 166.918290] ------------[ cut here ]------------
[ 166.922905] WARNING: CPU: 4 PID: 2288 at
drivers/hwtracing/coresight/coresight-tmc-etr.c:1037
tmc_etr_enable_hw+0xb0/0xc8
[ 166.933862] Modules linked in:
[ 166.936911] CPU: 4 PID: 2288 Comm: bash Not tainted 6.5.0-rc7 #132
[ 166.943084] Hardware name: Marvell CN106XX board (DT)
[ 166.948127] pstate: 834000c9 (Nzcv daIF +PAN -UAO +TCO +DIT -SSBS
BTYPE=--)
[ 166.955083] pc : tmc_etr_enable_hw+0xb0/0xc8
[ 166.959345] lr : tmc_enable_etr_sink+0x134/0x210
snip..
167.038545] Call trace:
[ 167.040982] tmc_etr_enable_hw+0xb0/0xc8
[ 167.044897] tmc_enable_etr_sink+0x134/0x210
[ 167.049160] coresight_enable_path+0x160/0x278
[ 167.053596] coresight_enable+0xd4/0x298
[ 167.057510] enable_source_store+0x54/0xa0
[ 167.061598] dev_attr_store+0x20/0x40
[ 167.065254] sysfs_kf_write+0x4c/0x68
[ 167.068909] kernfs_fop_write_iter+0x128/0x200
[ 167.073345] vfs_write+0x1ac/0x2f8
[ 167.076739] ksys_write+0x74/0x110
[ 167.080132] __arm64_sys_write+0x24/0x38
[ 167.084045] invoke_syscall.constprop.0+0x58/0xf8
[ 167.088744] do_el0_svc+0x60/0x160
[ 167.092137] el0_svc+0x40/0x170
[ 167.095273] el0t_64_sync_handler+0x100/0x130
[ 167.099621] el0t_64_sync+0x190/0x198
[ 167.103277] ---[ end trace 0000000000000000 ]---
-bash: echo: write error: Device or resource busy
Fixes: 296b01fd106e ("coresight: Refactor out buffer allocation function for ETR")
Signed-off-by: Linu Cherian <lcherian@marvell.com>
Reviewed-by: James Clark <james.clark@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230823042948.12879-1-lcherian@marvell.com
2023-09-15 16:09:18 +01:00
..
2023-09-08 06:36:36 +10:00
2023-09-04 15:17:28 -07:00
2023-08-22 15:50:57 +02:00
2023-09-01 09:53:54 -07:00
2023-09-09 12:01:33 -07:00
2023-08-30 13:34:34 -07:00
2023-09-01 09:43:18 -07:00
2023-09-08 21:39:54 -07:00
2023-09-01 09:38:00 -07:00
2023-09-01 09:53:54 -07:00
2023-09-01 09:08:59 -07:00
2023-09-04 21:57:59 +03:00
2023-08-30 19:53:39 -07:00
2023-09-04 13:15:57 -07:00
2023-09-04 13:47:59 -07:00
2023-08-29 20:51:40 +02:00
2023-08-31 12:43:10 -07:00
2023-08-29 11:23:29 -07:00
2023-08-24 16:20:30 -07:00
2023-09-03 10:49:42 -07:00
2023-08-30 13:34:34 -07:00
2023-08-30 19:23:00 -07:00
2023-09-09 14:25:11 -07:00
2023-08-22 15:51:33 +02:00
2023-08-30 16:42:21 -07:00
2023-09-06 17:08:51 +02:00
2023-09-10 11:55:26 -07:00
2023-09-01 12:31:44 -07:00
2023-08-28 13:31:06 -05:00
2023-09-04 11:26:29 -07:00
2023-09-01 09:53:54 -07:00
2023-09-15 16:09:18 +01:00
2023-09-04 13:44:11 -07:00
2023-09-06 01:21:47 +02:00
2023-08-28 16:35:01 -07:00
2023-09-01 09:53:54 -07:00
2023-09-02 12:02:41 -07:00
2023-09-06 09:24:25 -07:00
2023-08-30 19:53:39 -07:00
2023-09-01 16:54:25 -07:00
2023-08-30 20:05:42 -07:00
2023-09-04 13:52:58 -07:00
2023-08-31 12:43:10 -07:00
2023-09-05 10:11:01 -05:00
2023-08-29 20:21:42 -07:00
2023-09-09 08:15:11 +01:00
2023-08-29 09:47:33 -07:00
2023-09-01 09:53:54 -07:00
2023-09-01 09:38:00 -07:00
2023-09-04 13:47:59 -07:00
2023-08-28 13:36:24 -05:00
2023-09-07 18:33:07 -07:00
2023-08-30 18:32:24 -07:00
2023-08-22 12:38:19 -04:00
2023-08-30 20:52:08 -07:00
2023-08-29 20:21:42 -07:00
2023-08-23 16:34:02 +02:00
2023-08-30 16:59:03 -07:00
2023-08-28 18:00:27 +02:00
2023-09-01 09:38:00 -07:00
2023-09-09 11:35:28 -07:00
2023-09-08 12:48:37 -07:00
2023-09-03 10:38:02 -07:00
2023-08-30 19:36:19 -07:00
2023-09-01 09:23:34 -07:00
2023-09-05 21:42:18 +02:00
2023-09-06 22:21:22 +02:00
2023-09-07 18:05:58 -07:00
2023-09-07 15:51:07 -07:00
2023-09-04 15:12:26 -07:00
2023-08-30 19:53:39 -07:00
2023-09-04 15:08:52 -07:00
2023-09-07 16:07:35 -07:00
2023-09-08 21:39:54 -07:00
2023-08-28 13:36:24 -05:00
2023-09-09 12:01:33 -07:00
2023-09-08 11:25:29 -07:00
2023-09-03 10:20:57 -07:00
2023-09-07 15:49:20 -07:00
2023-09-09 08:15:11 +01:00
2023-09-02 12:02:41 -07:00
2023-09-05 21:42:18 +02:00
2023-09-01 09:38:00 -07:00
2023-09-02 08:25:19 +01:00
2023-09-07 10:35:14 -07:00
2023-09-04 10:43:44 -07:00
2023-08-30 20:41:37 -07:00
2023-09-03 18:10:22 -04:00
2023-09-06 09:00:37 -07:00
2023-08-24 16:20:18 -07:00
2023-09-03 18:10:24 -04:00
2023-09-06 09:19:12 -07:00
2023-08-29 20:32:10 -07:00
2023-09-08 11:24:34 -07:00
2023-09-08 11:24:34 -07:00