iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/kernel
History
Chen Zhongjin 55404cf492 profiling: fix shift too large makes kernel panic 
[ Upstream commit 0fe6ee8f123a4dfb529a5aff07536bb481f34043 ]

2d186afd04d6 ("profiling: fix shift-out-of-bounds bugs") limits shift
value by [0, BITS_PER_LONG -1], which means [0, 63].

However, syzbot found that the max shift value should be the bit number of
(_etext - _stext).  If shift is outside of this, the "buffer_bytes" will
be zero and will cause kzalloc(0).  Then the kernel panics due to
dereferencing the returned pointer 16.

This can be easily reproduced by passing a large number like 60 to enable
profiling and then run readprofile.

LOGS:
 BUG: kernel NULL pointer dereference, address: 0000000000000010
 #PF: supervisor write access in kernel mode
 #PF: error_code(0x0002) - not-present page
 PGD 6148067 P4D 6148067 PUD 6142067 PMD 0
 PREEMPT SMP
 CPU: 4 PID: 184 Comm: readprofile Not tainted 5.18.0+ #162
 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.15.0-0-g2dd4b9b3f840-prebuilt.qemu.org 04/01/2014
 RIP: 0010:read_profile+0x104/0x220
 RSP: 0018:ffffc900006fbe80 EFLAGS: 00000202
 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
 RDX: ffff888006150000 RSI: 0000000000000001 RDI: ffffffff82aba4a0
 RBP: 000000000188bb60 R08: 0000000000000010 R09: ffff888006151000
 R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff82aba4a0
 R13: 0000000000000000 R14: ffffc900006fbf08 R15: 0000000000020c30
 FS:  000000000188a8c0(0000) GS:ffff88803ed00000(0000) knlGS:0000000000000000
 CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 0000000000000010 CR3: 0000000006144000 CR4: 00000000000006e0
 Call Trace:
  <TASK>
  proc_reg_read+0x56/0x70
  vfs_read+0x9a/0x1b0
  ksys_read+0xa1/0xe0
  ? fpregs_assert_state_consistent+0x1e/0x40
  do_syscall_64+0x3a/0x80
  entry_SYSCALL_64_after_hwframe+0x46/0xb0
 RIP: 0033:0x4d4b4e
 RSP: 002b:00007ffebb668d58 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
 RAX: ffffffffffffffda RBX: 000000000188a8a0 RCX: 00000000004d4b4e
 RDX: 0000000000000400 RSI: 000000000188bb60 RDI: 0000000000000003
 RBP: 0000000000000003 R08: 000000000000006e R09: 0000000000000000
 R10: 0000000000000041 R11: 0000000000000246 R12: 000000000188bb60
 R13: 0000000000000400 R14: 0000000000000000 R15: 000000000188bb60
  </TASK>
 Modules linked in:
 CR2: 0000000000000010
Killed
 ---[ end trace 0000000000000000 ]---

Check prof_len in profile_init() to prevent it be zero.

Link: https://lkml.kernel.org/r/20220531012854.229439-1-chenzhongjin@huawei.com
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-08-17 15:15:46 +02:00
..
bpf
bpf: fix potential 32-bit overflow when accessing ARRAY map element
2022-08-17 15:14:51 +02:00
cgroup
cgroup: Use separate src/dst nodes when preloading css_sets for migration
2022-06-16 09:37:02 -10:00
configs
x86/configs: Update configs in x86_debug.config
2022-07-27 18:09:11 +02:00
debug
Modules updates for v5.19-rc1
2022-05-26 17:13:43 -07:00
dma
dma-direct: use the correct size for dma_set_encrypted()
2022-06-23 15:26:59 +02:00
entry
* Fix syzkaller NULL pointer dereference
2022-06-08 09:16:31 -07:00
events
perf/core: Fix data race between perf_event_set_output() and perf_mmap_close()
2022-07-13 11:29:12 +02:00
futex
drm for 5.19-rc1
2022-05-25 16:18:27 -07:00
gcov
gcov: Remove compiler version check
2021-12-02 17:25:21 +09:00
irq
irqdomain: Report irq number for NOMAP domains
2022-08-17 15:14:19 +02:00
kcsan
linux-kselftest-kunit-5.19-rc1
2022-05-25 11:32:53 -07:00
livepatch
Livepatching changes for 5.19
2022-06-02 08:55:01 -07:00
locking
locking/lockdep: Fix lockdep_init_map_*() confusion
2022-08-17 15:14:10 +02:00
module
module: kallsyms: Ensure preemption in add_kallsyms() with PREEMPT_RT
2022-07-11 10:19:09 -07:00
power
PM: hibernate: defer device probing when resuming from hibernation
2022-08-17 15:14:06 +02:00
printk
printk: do not wait for consoles when suspended
2022-07-15 10:52:11 +02:00
rcu
rcutorture: Fix ksoftirqd boosting timing and iteration
2022-08-17 15:14:33 +02:00
sched
io_uring: move to separate directory
2022-08-17 15:14:20 +02:00
time
wireguard: ratelimiter: use hrtimer in selftest
2022-08-17 15:14:59 +02:00
trace
blktrace: Trace remapped requests correctly
2022-08-17 15:14:17 +02:00
.gitignore
…
acct.c
kernel/acct: move acct sysctls to its own file
2022-04-06 13:43:44 -07:00
async.c
Revert "module, async: async_synchronize_full() on module init iff async is used"
2022-02-03 11:20:34 -08:00
audit_fsnotify.c
fsnotify: make allow_dups a property of the group
2022-04-25 14:37:18 +02:00
audit_tree.c
audit: use fsnotify group lock helpers
2022-04-25 14:37:28 +02:00
audit_watch.c
fsnotify: pass flags argument to fsnotify_alloc_group()
2022-04-25 14:37:12 +02:00
audit.c
audit: improve audit queue handling when "audit=1" on cmdline
2022-01-25 13:22:51 -05:00
audit.h
audit: log AUDIT_TIME_* records only from rules
2022-02-22 13:51:40 -05:00
auditfilter.c
audit/stable-5.17 PR 20220110
2022-01-11 13:08:21 -08:00
auditsc.c
audit: free module name
2022-06-15 19:28:44 -04:00
backtracetest.c
…
bounds.c
…
capability.c
xfs: don't generate selinux audit messages for capability testing
2022-03-09 10:32:06 -08:00
cfi.c
cfi: Fix __cfi_slowpath_diag RCU usage with cpuidle
2022-06-13 09:18:46 -07:00
compat.c
…
configs.c
…
context_tracking.c
…
cpu_pm.c
…
cpu.c
Intel Trust Domain Extensions
2022-05-23 17:51:12 -07:00
crash_core.c
Not a lot of material this cycle. Many singleton patches against various
2022-05-27 11:22:03 -07:00
crash_dump.c
…
cred.c
x86: Mark __invalid_creds() __noreturn
2022-03-15 10:32:44 +01:00
delayacct.c
delayacct: track delays from write-protect copy
2022-06-01 15:55:25 -07:00
dma.c
…
exec_domain.c
…
exit.c
fix race between exit_itimers() and /proc/pid/timers
2022-07-11 09:52:59 -07:00
extable.c
lkdtm: Really write into kernel text in WRITE_KERN
2022-02-16 23:25:12 +11:00
fail_function.c
…
fork.c
This set of changes updates init and user mode helper tasks to be
2022-06-03 16:03:05 -07:00
freezer.c
…
gen_kheaders.sh
kheaders: Have cpio unconditionally replace files
2022-05-08 03:16:59 +09:00
groups.c
…
hung_task.c
Merge branch 'rework/kthreads' into for-linus
2022-06-23 19:11:28 +02:00
iomem.c
…
irq_work.c
irq_work: use kasan_record_aux_stack_noalloc() record callstack
2022-04-15 14:49:55 -07:00
jump_label.c
…
kallsyms.c
ftrace: Add ftrace_lookup_symbols function
2022-05-10 14:42:06 -07:00
kcmp.c
…
Kconfig.freezer
…
Kconfig.hz
…
Kconfig.locks
…
Kconfig.preempt
Revert "signal, x86: Delay calling signals in atomic on RT enabled kernels"
2022-03-31 10:36:55 +02:00
kcov.c
kcov: update pos before writing pc in trace function
2022-05-25 13:05:42 -07:00
kexec_core.c
Not a lot of material this cycle. Many singleton patches against various
2022-05-27 11:22:03 -07:00
kexec_elf.c
…
kexec_file.c
ima: force signature verification when CONFIG_KEXEC_SIG is configured
2022-07-13 10:13:41 -04:00
kexec_internal.h
…
kexec.c
…
kheaders.c
…
kmod.c
…
kprobes.c
tracing updates for 5.19:
2022-05-29 10:31:36 -07:00
ksysfs.c
kernel/ksysfs.c: use helper macro __ATTR_RW
2022-03-23 19:00:33 -07:00
kthread.c
kthread: make it clear that kthread_create_on_node() might be terminated by any fatal signal
2022-06-16 19:11:30 -07:00
latencytop.c
latencytop: move sysctl to its own file
2022-04-21 11:40:59 -07:00
Makefile
kernel: add platform_has() infrastructure
2022-06-06 08:06:00 +02:00
module_signature.c
…
notifier.c
notifier: Add blocking/atomic_notifier_chain_register_unique_prio()
2022-05-19 19:30:30 +02:00
nsproxy.c
…
padata.c
padata: replace cpumask_weight with cpumask_empty in padata.c
2022-01-31 11:21:46 +11:00
panic.c
Merge branch 'rework/kthreads' into for-linus
2022-06-23 19:11:28 +02:00
params.c
kobject: remove kset from struct kset_uevent_ops callbacks
2021-12-28 11:26:18 +01:00
pid_namespace.c
kernel: pid_namespace: use NULL instead of using plain integer as pointer
2022-04-29 14:38:00 -07:00
pid.c
…
platform-feature.c
kernel: add platform_has() infrastructure
2022-06-06 08:06:00 +02:00
profile.c
profiling: fix shift too large makes kernel panic
2022-08-17 15:15:46 +02:00
ptrace.c
ptrace: fix clearing of JOBCTL_TRACED in ptrace_unfreeze_traced()
2022-07-09 11:06:19 -07:00
range.c
…
reboot.c
Merge branch 'rework/kthreads' into for-linus
2022-06-23 19:11:28 +02:00
regset.c
…
relay.c
relay: remove redundant assignment to pointer buf
2022-05-12 20:38:37 -07:00
resource_kunit.c
…
resource.c
kernel/resource: fix kfree() of bootmem memory again
2022-03-23 19:00:35 -07:00
rseq.c
rseq: Remove broken uapi field layout on 32-bit little endian
2022-02-02 13:11:34 +01:00
scftorture.c
scftorture: Fix distribution of short handler delays
2022-04-11 17:07:29 -07:00
scs.c
kasan, vmalloc: only tag normal vmalloc allocations
2022-03-24 19:06:48 -07:00
seccomp.c
seccomp: Add wait_killable semantic to seccomp user notifier
2022-05-03 14:11:58 -07:00
signal.c
signal handling: don't use BUG_ON() for debugging
2022-07-07 09:53:43 -07:00
smp.c
Scheduler changes in this cycle were:
2022-05-24 11:11:13 -07:00
smpboot.c
cpu/hotplug: Allow the CPU in CPU_UP_PREPARE state to be brought up again.
2022-04-12 14:13:01 +02:00
smpboot.h
…
softirq.c
smp: Make softirq handling RT safe in flush_smp_call_function_queue()
2022-05-01 10:03:43 +02:00
stackleak.c
stackleak: add on/off stack variants
2022-05-08 01:33:09 -07:00
stacktrace.c
uaccess: remove CONFIG_SET_FS
2022-02-25 09:36:06 +01:00
static_call_inline.c
static_call: Don't make __static_call_return0 static
2022-04-05 09:59:38 +02:00
static_call.c
static_call: Don't make __static_call_return0 static
2022-04-05 09:59:38 +02:00
stop_machine.c
Scheduler changes in this cycle were:
2022-05-24 11:11:13 -07:00
sys_ni.c
mm/mempolicy: wire up syscall set_mempolicy_home_node
2022-01-15 16:30:30 +02:00
sys.c
arm64/sme: Implement vector length configuration prctl()s
2022-04-22 18:50:54 +01:00
sysctl-test.c
…
sysctl.c
Only one fix for sysctl
2022-07-15 09:52:35 -07:00
task_work.c
task_work: allow TWA_SIGNAL without a rescheduling IPI
2022-04-30 08:39:32 -06:00
taskstats.c
kernel: make taskstats available from all net namespaces
2022-04-29 14:38:03 -07:00
torture.c
torture: Wake up kthreads after storing task_struct pointer
2022-02-01 17:24:39 -08:00
tracepoint.c
…
tsacct.c
taskstats: version 12 with thread group and exe info
2022-04-29 14:38:03 -07:00
ucount.c
ucounts: Handle wrapping in is_ucounts_overlimit
2022-02-17 09:11:57 -06:00
uid16.c
…
uid16.h
…
umh.c
kthread: Don't allocate kthread_struct for init and umh
2022-05-06 14:49:44 -05:00
up.c
…
user_namespace.c
ucounts: Fix systemd LimitNPROC with private users regression
2022-02-25 10:40:14 -06:00
user-return-notifier.c
…
user.c
…
usermode_driver.c
blob_to_mnt(): kern_unmount() is needed to undo kern_mount()
2022-05-19 23:25:47 -04:00
utsname_sysctl.c
…
utsname.c
…
watch_queue.c
watch_queue: Fix missing locking in add_watch_to_object()
2022-07-28 10:06:49 -07:00
watchdog_hld.c
Revert "printk: add functions to prefer direct printing"
2022-06-23 18:41:40 +02:00
watchdog.c
Merge branch 'rework/kthreads' into for-linus
2022-06-23 19:11:28 +02:00
workqueue_internal.h
…
workqueue.c
workqueue: Avoid a false warning in unbind_workers()
2022-07-29 07:49:02 -10:00