linux

iv/linux

History

Takashi Sakamoto 986c20bb3e firewire: core: fill model field in modalias of unit device for legacy layout of configuration ROM

As the last part of support for legacy layout of configuration ROM, this
commit traverses vendor directory as well as root directory when
constructing modalias for unit device. The change brings loss of backward
compatibility since it can fill model field ('mo') which is 0 at current
implementation in the case. However, we can be optimistic against
regression for unit drivers in kernel, due to some points:

1. ALSA drivers for audio and music units use the model fields to match
   device, however all of supported devices does not have such legacy
   layout.
2. the other unit drivers (e.g. sbp2) does not use the model field to
   match device.

The rest of concern is user space application. The most of applications
just take care of node device and does not use the modalias of unit
device, thus the change does not affect to them. But systemd project is
known to get affects from the change since it includes hwdb to take udev
to configure fw character device conveniently. I have a plan to work for
systemd so that the access permission of character device could be kept
across the change.

Suggested-by: Adam Goldman <adamg@pobox.com>
Link: https://lore.kernel.org/r/20231221134849.603857-9-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

2024-01-10 18:37:13 +09:00

.kunitconfig

firewire: test: add KUnit test for device attributes

2024-01-08 09:36:56 +09:00

core-card.c

Merge branch 'for-linus' into for-next

2022-05-23 07:48:27 +02:00

core-cdev.c

firewire: cdev: implement new event relevant to phy packet with time stamp

2023-05-30 08:12:40 +09:00

core-device.c

firewire: core: fill model field in modalias of unit device for legacy layout of configuration ROM